Title: fix: Correct the returning class proto type of StreamFeatureView to StreamFeatureViewProto instead of FeatureViewProto. by shuchu · Pull Request #3843 · feast-dev/feast · GitHub
Open Graph Title: fix: Correct the returning class proto type of StreamFeatureView to StreamFeatureViewProto instead of FeatureViewProto. by shuchu · Pull Request #3843 · feast-dev/feast
X Title: fix: Correct the returning class proto type of StreamFeatureView to StreamFeatureViewProto instead of FeatureViewProto. by shuchu · Pull Request #3843 · feast-dev/feast
Description: What this PR does / why we need it: There is a logic error while checking the StreamFeatureView's proto_class. In function "_check_conflicting_feature_view_names()" of "feast/infra/registry/regist...
Open Graph Description: What this PR does / why we need it: There is a logic error while checking the StreamFeatureView's proto_class. In function "_check_conflicting_feature_view_names()" of "feast/in...
X Description: What this PR does / why we need it: There is a logic error while checking the StreamFeatureView's proto_class. In function "_check_conflicting_feature_view_names()" of &a...
Opengraph URL: https://github.com/feast-dev/feast/pull/3843
X: @github
Domain: github.com
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6842c5ba-7c70-1c10-8a4d-7b9f05f3ce83 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CF26:30CF41:1B7CD7C:245D357:6971A511 |
| html-safe-nonce | e52292515b84fc0de4309339bba6480030414b0cda5ab0fe56ba76c9ac0968f9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjI2OjMwQ0Y0MToxQjdDRDdDOjI0NUQzNTc6Njk3MUE1MTEiLCJ2aXNpdG9yX2lkIjoiMzk3NDUyNTkxNjczMjgyNjg5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 39fb8115274c63e23fefbb7a38148bfbf2088ceee5c1e9bdf420bf0d4ac61789 |
| hovercard-subject-tag | pull_request:1613675276 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/3843/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6ee77996d3238143b00fc4ccf0b8fa51f77ee808ed527bbe7305cf4a64b97196/feast-dev/feast/pull/3843 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6ee77996d3238143b00fc4ccf0b8fa51f77ee808ed527bbe7305cf4a64b97196/feast-dev/feast/pull/3843 |
| og:image:alt | What this PR does / why we need it: There is a logic error while checking the StreamFeatureView's proto_class. In function "_check_conflicting_feature_view_names()" of "feast/in... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | shuchu |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdfdce9cd4f6ab85dca2b0d11264270829297c962dd5a79df449062d7822258f |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 51c736e60b302bd039c9d5164573d176ceb24bb2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width