| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e883c6fc-8400-dcc3-97c4-8ebbafaec891 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 83F4:13A3EC:1723D0:203D0D:69720D19 |
| html-safe-nonce | bfafca6baeb906a112f98b49d67aab4ed69a63d142f0901aad966ca329f80598 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0Y0OjEzQTNFQzoxNzIzRDA6MjAzRDBEOjY5NzIwRDE5IiwidmlzaXRvcl9pZCI6IjYyNjg5NDIyMDQxMTAyNDUxNDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ac37736b5180ee378188db9e3258effbbd8d707e23584e4c381c83142ae3662d |
| hovercard-subject-tag | pull_request:1573774316 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/3819/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8d0ed8d8c5b6b3a2699e8929ebb2863f716fc3dd9d3cf48edcf3fc36564c0e5c/feast-dev/feast/pull/3819 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8d0ed8d8c5b6b3a2699e8929ebb2863f716fc3dd9d3cf48edcf3fc36564c0e5c/feast-dev/feast/pull/3819 |
| og:image:alt | What this PR does / why we need it:
This updates the SparkSource data type to be properly comparable. The previous form defaults to using the __eq__ implementation from the DataSource class. This m... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | thechopkins |
| hostname | github.com |
| expected-hostname | github.com |
| None | 453de246939b1e04d711e109432e2df10933270413df93b7a8f8f1df8dda7f18 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 12756e5bdb9000be815bbf20a1acc7935638e596 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/3819#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3819 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3819 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/3819 |
| Reload | https://github.com/feast-dev/feast/pull/3819 |
| Reload | https://github.com/feast-dev/feast/pull/3819 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.6k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
179
| https://github.com/feast-dev/feast/issues |
|
Pull requests
63
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/feast-dev/feast/security |
| Please reload this page | https://github.com/feast-dev/feast/pull/3819 |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/3819#issue-comment-box |
| thechopkins | https://github.com/thechopkins |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| thechopkins:master | https://github.com/thechopkins/feast/tree/master |
|
fix: Update SparkSource to have proper comparable that inspects SparkOptions
| https://github.com/feast-dev/feast/pull/3819#top |
| thechopkins | https://github.com/thechopkins |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| thechopkins:master | https://github.com/thechopkins/feast/tree/master |
|
Conversation
3
| https://github.com/feast-dev/feast/pull/3819 |
|
Commits
3
| https://github.com/feast-dev/feast/pull/3819/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/3819/checks |
|
Files changed
2
| https://github.com/feast-dev/feast/pull/3819/files |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/thechopkins |
| thechopkins | https://github.com/thechopkins |
| Oct 25, 2023 | https://github.com/feast-dev/feast/pull/3819#issue-1962355422 |
| Please reload this page | https://github.com/feast-dev/feast/pull/3819 |
| https://github.com/thechopkins |
| thechopkins | https://github.com/thechopkins |
| kevjumba | https://github.com/kevjumba |
| niklasvm | https://github.com/niklasvm |
| code owners | https://github.com/feast-dev/feast/blob/015196119945d962bb67db84de787364667cecca/CODEOWNERS#L31 |
| October 25, 2023 22:26 | https://github.com/feast-dev/feast/pull/3819#event-10772922466 |
|
| https://github.com/thechopkins |
| Update SparkSource to have proper comparable | https://github.com/feast-dev/feast/pull/3819/commits/c1e869e555c456e696951bdb459f3b92b8fa0886 |
| c1e869e | https://github.com/feast-dev/feast/pull/3819/commits/c1e869e555c456e696951bdb459f3b92b8fa0886 |
| https://github.com/thechopkins |
| thechopkins | https://github.com/thechopkins |
| force-pushed | https://github.com/feast-dev/feast/compare/9852b6d88e420b3830c184e4bd330d45ed7c6db1..c1e869e555c456e696951bdb459f3b92b8fa0886 |
| 9852b6d | https://github.com/feast-dev/feast/commit/9852b6d88e420b3830c184e4bd330d45ed7c6db1 |
| c1e869e | https://github.com/feast-dev/feast/commit/c1e869e555c456e696951bdb459f3b92b8fa0886 |
|
Compare
| https://github.com/feast-dev/feast/compare/9852b6d88e420b3830c184e4bd330d45ed7c6db1..c1e869e555c456e696951bdb459f3b92b8fa0886 |
| October 25, 2023 22:27 | https://github.com/feast-dev/feast/pull/3819#event-10772929090 |
| https://github.com/thechopkins |
| thechopkins | https://github.com/thechopkins |
| Oct 25, 2023 | https://github.com/feast-dev/feast/pull/3819#event-10772936074 |
| https://github.com/thechopkins |
| thechopkins | https://github.com/thechopkins |
| Oct 25, 2023 | https://github.com/feast-dev/feast/pull/3819#event-10772941877 |
| thechopkins | https://github.com/thechopkins |
| October 25, 2023 15:41 | https://github.com/feast-dev/feast/pull/3819#commits-pushed-63a22d9 |
|
| https://github.com/thechopkins |
| lint fixes | https://github.com/feast-dev/feast/pull/3819/commits/63a22d9aea08fe036fc2c99424b7520638cdb4be |
| 63a22d9 | https://github.com/feast-dev/feast/pull/3819/commits/63a22d9aea08fe036fc2c99424b7520638cdb4be |
|
| https://github.com/thechopkins |
| force precommit | https://github.com/feast-dev/feast/pull/3819/commits/61f604a0987a2521d6106124ece7f2253feb503f |
| 61f604a | https://github.com/feast-dev/feast/pull/3819/commits/61f604a0987a2521d6106124ece7f2253feb503f |
| https://github.com/rebstastic |
| rebstastic | https://github.com/rebstastic |
|
Oct 26, 2023
| https://github.com/feast-dev/feast/pull/3819#pullrequestreview-1699570473 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/3819/files/61f604a0987a2521d6106124ece7f2253feb503f |
| sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py | https://github.com/feast-dev/feast/pull/3819/files/61f604a0987a2521d6106124ece7f2253feb503f#diff-5adf14693cee066990c26d08bac61fed1fd030a9e02b3f4ad16803b6be0df622 |
| rebstastic | https://github.com/rebstastic |
| Oct 26, 2023 | https://github.com/feast-dev/feast/pull/3819#discussion_r1373131310 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/3819 |
| thechopkins | https://github.com/thechopkins |
| Oct 26, 2023 | https://github.com/feast-dev/feast/pull/3819#discussion_r1373785828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| redshift_source.py example | https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/offline_stores/redshift_source.py#L116-L131 |
| Please reload this page | https://github.com/feast-dev/feast/pull/3819 |
| https://github.com/achals |
| achals | https://github.com/achals |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Oct 31, 2023 | https://github.com/feast-dev/feast/pull/3819#event-10826454370 |
| https://github.com/jeremyary |
| jeremyary | https://github.com/jeremyary |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Mar 4, 2024 | https://github.com/feast-dev/feast/pull/3819#event-12001660503 |
| https://github.com/franciscojavierarceo |
| franciscojavierarceo | https://github.com/franciscojavierarceo |
| Mar 16, 2024 | https://github.com/feast-dev/feast/pull/3819#issuecomment-2001948074 |
| @thechopkins | https://github.com/thechopkins |
| Please reload this page | https://github.com/feast-dev/feast/pull/3819 |
| https://github.com/tokoko |
| tokoko | https://github.com/tokoko |
|
Mar 26, 2024
| https://github.com/feast-dev/feast/pull/3819#ref-pullrequest-2200374499 |
|
fix: Add __eq__, __hash__ to SparkSource for correct comparison
#4028
| https://github.com/feast-dev/feast/pull/4028 |
| https://github.com/jeremyary |
| jeremyary | https://github.com/jeremyary |
| Mar 29, 2024 | https://github.com/feast-dev/feast/pull/3819#issuecomment-2027386844 |
| 4028 | https://github.com/feast-dev/feast/pull/4028 |
| Please reload this page | https://github.com/feast-dev/feast/pull/3819 |
| https://github.com/jeremyary |
| jeremyary | https://github.com/jeremyary |
| Mar 29, 2024 | https://github.com/feast-dev/feast/pull/3819#event-12296052972 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3819 |
|
| https://github.com/niklasvm |
|
niklasvm
| https://github.com/niklasvm |
|
| https://github.com/kevjumba |
|
kevjumba
| https://github.com/kevjumba |
|
| https://github.com/rebstastic |
|
rebstastic
| https://github.com/rebstastic |
|
| https://github.com/feast-dev/feast/pull/3819/files/61f604a0987a2521d6106124ece7f2253feb503f |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
| Please reload this page | https://github.com/feast-dev/feast/pull/3819 |
|
| https://github.com/thechopkins |
|
| https://github.com/franciscojavierarceo |
|
| https://github.com/jeremyary |
|
| https://github.com/rebstastic |
|
| https://github.com/achals |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |