René's URL Explorer Experiment


Title: fix: Support param timeout when persisting by sudohainguyen · Pull Request #3504 · feast-dev/feast · GitHub

Open Graph Title: fix: Support param timeout when persisting by sudohainguyen · Pull Request #3504 · feast-dev/feast

X Title: fix: Support param timeout when persisting by sudohainguyen · Pull Request #3504 · feast-dev/feast

Description: What this PR does / why we need it: to support declaring timeout when persisting historical retrieval job Which issue(s) this PR fixes: Fixes #

Open Graph Description: What this PR does / why we need it: to support declaring timeout when persisting historical retrieval job Which issue(s) this PR fixes: Fixes #

X Description: What this PR does / why we need it: to support declaring timeout when persisting historical retrieval job Which issue(s) this PR fixes: Fixes #

Opengraph URL: https://github.com/feast-dev/feast/pull/3504

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:351867bb-a8da-4597-3d6d-bbbb0dd72714
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E2C:1FEE19:2E51CCD:412B7E9:69791C42
html-safe-nonce05784b55011541453cacd19812ccc38835367bc60179ec6753567434c4bd83c0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTJDOjFGRUUxOToyRTUxQ0NEOjQxMkI3RTk6Njk3OTFDNDIiLCJ2aXNpdG9yX2lkIjoiMTc0MDQzMzkwMTAyMjE1Nzg5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd0e3fc30dd2969c3ef4a35b236e355078d9de0a4143fad25eca5082fd6f21e2e
hovercard-subject-tagpull_request:1248066697
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/3504/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f04ebb33421095d2f59c9d685fb05bb13b3adf1ae3449a91788a65b3c8853b85/feast-dev/feast/pull/3504
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f04ebb33421095d2f59c9d685fb05bb13b3adf1ae3449a91788a65b3c8853b85/feast-dev/feast/pull/3504
og:image:altWhat this PR does / why we need it: to support declaring timeout when persisting historical retrieval job Which issue(s) this PR fixes: Fixes #
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesudohainguyen
hostnamegithub.com
expected-hostnamegithub.com
None3c7f9dd0916337a11e6ea9c7a54b96960b654425bd4240b9643d6c3af745492e
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea2ee5467a024047ab777ae5b5b3ee378f2e75635
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/3504#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3504
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3504
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/3504
Reloadhttps://github.com/feast-dev/feast/pull/3504
Reloadhttps://github.com/feast-dev/feast/pull/3504
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 181 https://github.com/feast-dev/feast/issues
Pull requests 67 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/3504#issue-comment-box
sudohainguyenhttps://github.com/sudohainguyen
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
sudohainguyen:fix/persist_timeouthttps://github.com/sudohainguyen/feast/tree/fix/persist_timeout
fix: Support param timeout when persisting https://github.com/feast-dev/feast/pull/3504#top
sudohainguyenhttps://github.com/sudohainguyen
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
sudohainguyen:fix/persist_timeouthttps://github.com/sudohainguyen/feast/tree/fix/persist_timeout
Conversation 9 https://github.com/feast-dev/feast/pull/3504
Commits 6 https://github.com/feast-dev/feast/pull/3504/commits
Checks 0 https://github.com/feast-dev/feast/pull/3504/checks
Files changed https://github.com/feast-dev/feast/pull/3504/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
Feb 21, 2023https://github.com/feast-dev/feast/pull/3504#issue-1592732388
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
chhabrakadabrahttps://github.com/chhabrakadabra
kevjumbahttps://github.com/kevjumba
mavysavydavhttps://github.com/mavysavydav
niklasvmhttps://github.com/niklasvm
sfc-gh-madkinshttps://github.com/sfc-gh-madkins
younggyu-ohhttps://github.com/younggyu-oh
code ownershttps://github.com/feast-dev/feast/blob/f2cbf43d4be6829ce3affb72b8a5416d8e084ba9/CODEOWNERS#L14
February 21, 2023 03:50https://github.com/feast-dev/feast/pull/3504#event-8566548432
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
do-not-merge/work-in-progress https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress
Feb 21, 2023https://github.com/feast-dev/feast/pull/3504#event-8566548517
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Feb 21, 2023https://github.com/feast-dev/feast/pull/3504#issuecomment-1437821445
sudohainguyenhttps://github.com/feast-dev/feast/pull/3504
pull request processhttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
herehttps://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast
OWNERShttps://github.com/feast-dev/feast/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/S https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FS
Feb 21, 2023https://github.com/feast-dev/feast/pull/3504#event-8566549142
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
force-pushedhttps://github.com/feast-dev/feast/compare/98aaa1b65ec10517a51d9feaf6d1238392be1341..948ac8e60cab5197902e17370be31fbef11df8c5
98aaa1bhttps://github.com/feast-dev/feast/commit/98aaa1b65ec10517a51d9feaf6d1238392be1341
948ac8ehttps://github.com/feast-dev/feast/commit/948ac8e60cab5197902e17370be31fbef11df8c5
Compare https://github.com/feast-dev/feast/compare/98aaa1b65ec10517a51d9feaf6d1238392be1341..948ac8e60cab5197902e17370be31fbef11df8c5
February 21, 2023 03:50https://github.com/feast-dev/feast/pull/3504#event-8566550024
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
Feb 21, 2023https://github.com/feast-dev/feast/pull/3504#event-8566554449
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
do-not-merge/work-in-progress https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress
Feb 21, 2023https://github.com/feast-dev/feast/pull/3504#event-8566554511
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
force-pushedhttps://github.com/feast-dev/feast/compare/948ac8e60cab5197902e17370be31fbef11df8c5..faace823d1faa1e8e843125a047221973e6d7295
948ac8ehttps://github.com/feast-dev/feast/commit/948ac8e60cab5197902e17370be31fbef11df8c5
faace82https://github.com/feast-dev/feast/commit/faace823d1faa1e8e843125a047221973e6d7295
Compare https://github.com/feast-dev/feast/compare/948ac8e60cab5197902e17370be31fbef11df8c5..faace823d1faa1e8e843125a047221973e6d7295
February 21, 2023 04:02https://github.com/feast-dev/feast/pull/3504#event-8566593245
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/M https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM
size/S https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FS
Feb 21, 2023https://github.com/feast-dev/feast/pull/3504#event-8566594366
https://github.com/gbmarc1
gbmarc1https://github.com/gbmarc1
Feb 22, 2023https://github.com/feast-dev/feast/pull/3504#issuecomment-1440532083
@sudohainguyenhttps://github.com/sudohainguyen
PRhttps://github.com/feast-dev/feast/pull/3505
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
Feb 23, 2023https://github.com/feast-dev/feast/pull/3504#issuecomment-1441085786
@sudohainguyenhttps://github.com/sudohainguyen
PRhttps://github.com/feast-dev/feast/pull/3505
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
Feb 23, 2023https://github.com/feast-dev/feast/pull/3504#issuecomment-1441086808
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
@gbmarc1https://github.com/gbmarc1
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
https://github.com/achals
achalshttps://github.com/achals
Mar 2, 2023 https://github.com/feast-dev/feast/pull/3504#pullrequestreview-1321013370
View reviewed changes https://github.com/feast-dev/feast/pull/3504/files
sdk/python/feast/infra/offline_stores/bigquery.pyhttps://github.com/feast-dev/feast/pull/3504/files#diff-14f38fcbdc2240bb60b9f558d133b174f5b6059cfcd959eef8b9c49bb5be8838
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
https://github.com/achals
achalshttps://github.com/achals
Mar 2, 2023 https://github.com/feast-dev/feast/pull/3504#pullrequestreview-1321014668
View reviewed changes https://github.com/feast-dev/feast/pull/3504/files
sdk/python/feast/infra/offline_stores/offline_store.pyhttps://github.com/feast-dev/feast/pull/3504/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
sudohainguyenhttps://github.com/sudohainguyen
March 2, 2023 23:39https://github.com/feast-dev/feast/pull/3504#commits-pushed-f416337
https://github.com/sudohainguyen
fix: Support param timeout when persistinghttps://github.com/feast-dev/feast/pull/3504/commits/f4163379e946a2ccbc542aca0a87bd3f00372b1a
f416337https://github.com/feast-dev/feast/pull/3504/commits/f4163379e946a2ccbc542aca0a87bd3f00372b1a
https://github.com/sudohainguyen
chore: add type hint to persist methodshttps://github.com/feast-dev/feast/pull/3504/commits/d48a0891412b5c00d21b43d71e473f65402cbf28
d48a089https://github.com/feast-dev/feast/pull/3504/commits/d48a0891412b5c00d21b43d71e473f65402cbf28
https://github.com/sudohainguyen
chore: add type hint to to_bigquery methodhttps://github.com/feast-dev/feast/pull/3504/commits/cd26b6f07025cee3b6321c555a23736865fbdc7f
cd26b6fhttps://github.com/feast-dev/feast/pull/3504/commits/cd26b6f07025cee3b6321c555a23736865fbdc7f
https://github.com/sudohainguyen
fix: set default timeout to None in base offline store classhttps://github.com/feast-dev/feast/pull/3504/commits/65a94ddcf695f16141cf7cac42254c0f27750ddf
65a94ddhttps://github.com/feast-dev/feast/pull/3504/commits/65a94ddcf695f16141cf7cac42254c0f27750ddf
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
force-pushedhttps://github.com/feast-dev/feast/compare/8319cc7ff977be53163dca0676d6adb68164cbe6..65a94ddcf695f16141cf7cac42254c0f27750ddf
8319cc7https://github.com/feast-dev/feast/commit/8319cc7ff977be53163dca0676d6adb68164cbe6
65a94ddhttps://github.com/feast-dev/feast/commit/65a94ddcf695f16141cf7cac42254c0f27750ddf
Compare https://github.com/feast-dev/feast/compare/8319cc7ff977be53163dca0676d6adb68164cbe6..65a94ddcf695f16141cf7cac42254c0f27750ddf
March 2, 2023 16:39https://github.com/feast-dev/feast/pull/3504#event-8651480885
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
Mar 2, 2023https://github.com/feast-dev/feast/pull/3504#issuecomment-1452176811
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
sudohainguyenhttps://github.com/sudohainguyen
March 2, 2023 23:41https://github.com/feast-dev/feast/pull/3504#commits-pushed-69a8091
https://github.com/sudohainguyen
fix: set default timeout to None in to_bigqueryhttps://github.com/feast-dev/feast/pull/3504/commits/69a80910712318793c8c4f9de1d6a7f1b7422f22
69a8091https://github.com/feast-dev/feast/pull/3504/commits/69a80910712318793c8c4f9de1d6a7f1b7422f22
https://github.com/sudohainguyen
chore: update test case due to change of paramhttps://github.com/feast-dev/feast/pull/3504/commits/56e790e19263872ff7aaf2723405ad803a4833d9
56e790ehttps://github.com/feast-dev/feast/pull/3504/commits/56e790e19263872ff7aaf2723405ad803a4833d9
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
force-pushedhttps://github.com/feast-dev/feast/compare/e46fdd2c03419a534531ebd13982dbede3124d06..56e790e19263872ff7aaf2723405ad803a4833d9
e46fdd2https://github.com/feast-dev/feast/commit/e46fdd2c03419a534531ebd13982dbede3124d06
56e790ehttps://github.com/feast-dev/feast/commit/56e790e19263872ff7aaf2723405ad803a4833d9
Compare https://github.com/feast-dev/feast/compare/e46fdd2c03419a534531ebd13982dbede3124d06..56e790e19263872ff7aaf2723405ad803a4833d9
March 2, 2023 17:10https://github.com/feast-dev/feast/pull/3504#event-8651791489
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
Apr 6, 2023https://github.com/feast-dev/feast/pull/3504#issuecomment-1499145240
@achalshttps://github.com/achals
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
https://github.com/sudohainguyen
sudohainguyenhttps://github.com/sudohainguyen
Apr 8, 2023https://github.com/feast-dev/feast/pull/3504#event-8956922937
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3504
https://github.com/achals
achals https://github.com/achals
https://github.com/feast-dev/feast/pull/3504/files/57301e31930b401f384da52955e7f8ae9fd64802
https://github.com/niklasvm
niklasvm https://github.com/niklasvm
https://github.com/kevjumba
kevjumba https://github.com/kevjumba
https://github.com/younggyu-oh
younggyu-oh https://github.com/younggyu-oh
https://github.com/sfc-gh-madkins
sfc-gh-madkins https://github.com/sfc-gh-madkins
https://github.com/chhabrakadabra
chhabrakadabra https://github.com/chhabrakadabra
https://github.com/mavysavydav
mavysavydav https://github.com/mavysavydav
size/M https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM
Please reload this pagehttps://github.com/feast-dev/feast/pull/3504
https://github.com/sudohainguyen
https://github.com/feast-ci-bot
https://github.com/gbmarc1
https://github.com/achals
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.