René's URL Explorer Experiment


Title: fix: Add check for bool type in addition to sample by beauchbum · Pull Request #3452 · feast-dev/feast · GitHub

Open Graph Title: fix: Add check for bool type in addition to sample by beauchbum · Pull Request #3452 · feast-dev/feast

X Title: fix: Add check for bool type in addition to sample by beauchbum · Pull Request #3452 · feast-dev/feast

Description: Signed-off-by: Ryan Beauchamp ryan.beauchamp@ezcater.com What this PR does / why we need it: The current implementation throws an exception when sample == False as it enters this conditional: # Th...

Open Graph Description: Signed-off-by: Ryan Beauchamp ryan.beauchamp@ezcater.com What this PR does / why we need it: The current implementation throws an exception when sample == False as it enters this conditional: # Th...

X Description: Signed-off-by: Ryan Beauchamp ryan.beauchamp@ezcater.com What this PR does / why we need it: The current implementation throws an exception when sample == False as it enters this conditional: # Th...

Mail addresses
ryan.beauchamp@ezcater.com

Opengraph URL: https://github.com/feast-dev/feast/pull/3452

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0f60086f-86ec-c1c0-9fd1-5d4c9221f3fa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC94:3F8B4C:7D6BCA:AD2059:6978AED9
html-safe-nonce5b3ecbc02f8b008587ae0163cc68f18567d5aa4c09088c6819e6636e125a500e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzk0OjNGOEI0Qzo3RDZCQ0E6QUQyMDU5OjY5NzhBRUQ5IiwidmlzaXRvcl9pZCI6IjQxMTQ0NzUxODQxMDA1MTk2NDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac27fef0b680b61dc3fba3f7eb63b86006dcb598362a05bf306745ec923e793ec2
hovercard-subject-tagpull_request:1210050203
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/3452/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/882bbd4e8647b337fec7678bc85291b48ede1f931482d0dec2eb80609fa67646/feast-dev/feast/pull/3452
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/882bbd4e8647b337fec7678bc85291b48ede1f931482d0dec2eb80609fa67646/feast-dev/feast/pull/3452
og:image:altSigned-off-by: Ryan Beauchamp ryan.beauchamp@ezcater.com What this PR does / why we need it: The current implementation throws an exception when sample == False as it enters this conditional: # Th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebeauchbum
hostnamegithub.com
expected-hostnamegithub.com
None2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef8aa86d87c47054170094daaf9699b27a28a8448
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/3452#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3452
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3452
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/3452
Reloadhttps://github.com/feast-dev/feast/pull/3452
Reloadhttps://github.com/feast-dev/feast/pull/3452
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 182 https://github.com/feast-dev/feast/issues
Pull requests 67 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/3452#issue-comment-box
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
beauchbum:fix_type_maphttps://github.com/beauchbum/feast/tree/fix_type_map
fix: Add check for bool type in addition to sample https://github.com/feast-dev/feast/pull/3452#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
beauchbum:fix_type_maphttps://github.com/beauchbum/feast/tree/fix_type_map
Conversation 2 https://github.com/feast-dev/feast/pull/3452
Commits 1 https://github.com/feast-dev/feast/pull/3452/commits
Checks 0 https://github.com/feast-dev/feast/pull/3452/checks
Files changed https://github.com/feast-dev/feast/pull/3452/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/3452
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/beauchbum
beauchbumhttps://github.com/beauchbum
Jan 19, 2023https://github.com/feast-dev/feast/pull/3452#issue-1549158884
Please reload this pagehttps://github.com/feast-dev/feast/pull/3452
#3451https://github.com/feast-dev/feast/issues/3451
Please reload this pagehttps://github.com/feast-dev/feast/pull/3452
https://github.com/beauchbum
fix: add check for bool type in addition to samplehttps://github.com/feast-dev/feast/pull/3452/commits/5dcd9fbd9eed7ab3ce971c23690f386cc5b03bd3
5dcd9fbhttps://github.com/feast-dev/feast/pull/3452/commits/5dcd9fbd9eed7ab3ce971c23690f386cc5b03bd3
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/XS https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXS
Jan 19, 2023https://github.com/feast-dev/feast/pull/3452#event-8312006618
https://github.com/beauchbum
beauchbumhttps://github.com/beauchbum
Jan 19, 2023https://github.com/feast-dev/feast/pull/3452#event-8312060000
https://github.com/adchia
adchiahttps://github.com/adchia
Jan 20, 2023 https://github.com/feast-dev/feast/pull/3452#pullrequestreview-1264147913
View reviewed changes https://github.com/feast-dev/feast/pull/3452/files/5dcd9fbd9eed7ab3ce971c23690f386cc5b03bd3
adchiahttps://github.com/adchia
https://github.com/feast-dev/feast/pull/3452#pullrequestreview-1264147913
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/3452
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
adchiahttps://github.com/adchia
Jan 20, 2023https://github.com/feast-dev/feast/pull/3452#event-8324161517
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Jan 20, 2023https://github.com/feast-dev/feast/pull/3452#issuecomment-1398781707
adchiahttps://github.com/feast-dev/feast/pull/3452#pullrequestreview-1264147913
beauchbumhttps://github.com/feast-dev/feast/pull/3452
herehttps://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/feast-dev/feast/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/3452
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
Jan 20, 2023https://github.com/feast-dev/feast/pull/3452#event-8324161657
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
1c7c491https://github.com/feast-dev/feast/commit/1c7c491378c9a5dc892ec58f2d81d4e95b800580
Jan 20, 2023https://github.com/feast-dev/feast/pull/3452#event-8324343026
kevjumbahttps://github.com/kevjumba
Jan 31, 2023 https://github.com/feast-dev/feast/pull/3452#ref-commit-d3b7c06
https://github.com/feast-ci-bot
chore(release): release 0.29.0https://github.com/feast-dev/feast/commit/d3b7c060bdc2a4d2b19dbd4e0dd8f35e76589d5f
d3b7c06https://github.com/feast-dev/feast/commit/d3b7c060bdc2a4d2b19dbd4e0dd8f35e76589d5f
v0.28.0...v0.29.0https://github.com/feast-dev/feast/compare/v0.28.0...v0.29.0
#3452https://github.com/feast-dev/feast/pull/3452
#3452https://github.com/feast-dev/feast/pull/3452
1c7c491https://github.com/feast-dev/feast/commit/1c7c491378c9a5dc892ec58f2d81d4e95b800580
1c7c491https://github.com/feast-dev/feast/commit/1c7c491378c9a5dc892ec58f2d81d4e95b800580
#3424https://github.com/feast-dev/feast/pull/3424
#3424https://github.com/feast-dev/feast/pull/3424
1ea100ehttps://github.com/feast-dev/feast/commit/1ea100ef472a7cc5b750d4b84992a254b4582de6
1ea100ehttps://github.com/feast-dev/feast/commit/1ea100ef472a7cc5b750d4b84992a254b4582de6
#3460https://github.com/feast-dev/feast/pull/3460
#3460https://github.com/feast-dev/feast/pull/3460
08ffa8dhttps://github.com/feast-dev/feast/commit/08ffa8dff61acd7047d205083b78efa98e2dccb8
08ffa8dhttps://github.com/feast-dev/feast/commit/08ffa8dff61acd7047d205083b78efa98e2dccb8
#3466https://github.com/feast-dev/feast/pull/3466
#3466https://github.com/feast-dev/feast/pull/3466
dfd5eaehttps://github.com/feast-dev/feast/commit/dfd5eaec6bab4961a7981e4f6a70b45e4d72bce4
dfd5eaehttps://github.com/feast-dev/feast/commit/dfd5eaec6bab4961a7981e4f6a70b45e4d72bce4
#3464https://github.com/feast-dev/feast/pull/3464
#3464https://github.com/feast-dev/feast/pull/3464
1ef5137https://github.com/feast-dev/feast/commit/1ef51376a67347c31ee2e7a037be844526ecc48d
1ef5137https://github.com/feast-dev/feast/commit/1ef51376a67347c31ee2e7a037be844526ecc48d
#3450https://github.com/feast-dev/feast/pull/3450
#3450https://github.com/feast-dev/feast/pull/3450
2f7c4edhttps://github.com/feast-dev/feast/commit/2f7c4ede8f9e66703714261f1152f78526d4bf43
2f7c4edhttps://github.com/feast-dev/feast/commit/2f7c4ede8f9e66703714261f1152f78526d4bf43
#3411https://github.com/feast-dev/feast/pull/3411
#3411https://github.com/feast-dev/feast/pull/3411
01ab462https://github.com/feast-dev/feast/commit/01ab462d49442d8c7f4de418132665e48552c22d
01ab462https://github.com/feast-dev/feast/commit/01ab462d49442d8c7f4de418132665e48552c22d
#3401https://github.com/feast-dev/feast/pull/3401
#3401https://github.com/feast-dev/feast/pull/3401
#3449https://github.com/feast-dev/feast/pull/3449
#3449https://github.com/feast-dev/feast/pull/3449
fbbb293https://github.com/feast-dev/feast/commit/fbbb2935fd7c722dbe85f19a8ddf788765116360
fbbb293https://github.com/feast-dev/feast/commit/fbbb2935fd7c722dbe85f19a8ddf788765116360
#3436https://github.com/feast-dev/feast/pull/3436
#3436https://github.com/feast-dev/feast/pull/3436
21dd253https://github.com/feast-dev/feast/commit/21dd253adda26c18366cf4338512bdc2c00882cf
21dd253https://github.com/feast-dev/feast/commit/21dd253adda26c18366cf4338512bdc2c00882cf
#3428https://github.com/feast-dev/feast/pull/3428
#3428https://github.com/feast-dev/feast/pull/3428
753d8dbhttps://github.com/feast-dev/feast/commit/753d8dbb5e34c24cf065f599a2cd370b3723de9c
753d8dbhttps://github.com/feast-dev/feast/commit/753d8dbb5e34c24cf065f599a2cd370b3723de9c
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3452
https://github.com/adchia
adchia https://github.com/adchia
https://github.com/feast-dev/feast/pull/3452/files/5dcd9fbd9eed7ab3ce971c23690f386cc5b03bd3
https://github.com/adchia
adchia https://github.com/adchia
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
size/XS https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXS
0.28.0 Python SDK: Assertion failure on Boolean types in type_map.py #3443 https://github.com/feast-dev/feast/issues/3451
Please reload this pagehttps://github.com/feast-dev/feast/pull/3452
https://github.com/beauchbum
https://github.com/feast-ci-bot
https://github.com/adchia
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.