| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:19511e35-9ed6-fe1e-a721-8f7f2b3b7151 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C0D4:181429:937FA8:D2D3A1:6978C2DE |
| html-safe-nonce | a48d526fbcc417db76b24695ea4e4100027917decf09949b54a4a9b72e015040 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEQ0OjE4MTQyOTo5MzdGQTg6RDJEM0ExOjY5NzhDMkRFIiwidmlzaXRvcl9pZCI6IjMwMDY3Nzc5MDI3MDkxMjk5NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 03009b14deb9e4daa5210d4a910a9dde8aa2d6448fbe0b344279af187a9c7901 |
| hovercard-subject-tag | pull_request:995067311 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/2936/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0818a04d955fe9195b793e53a65ff0d9993af09d002dc39b719bb0732ceeaf82/feast-dev/feast/pull/2936 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0818a04d955fe9195b793e53a65ff0d9993af09d002dc39b719bb0732ceeaf82/feast-dev/feast/pull/2936 |
| og:image:alt | Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | achals |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8a71ca1f7ab5436216e1df86f398ef7a51ed3152c90e3f7332fc70cf97fcb9d6 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | eaed570eead52a9920afef75dc3eb6d826fdc5ef |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/2936#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2936 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2936 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/2936 |
| Reload | https://github.com/feast-dev/feast/pull/2936 |
| Reload | https://github.com/feast-dev/feast/pull/2936 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
181
| https://github.com/feast-dev/feast/issues |
|
Pull requests
67
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/2936#issue-comment-box |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| achals:acha/go-wip | https://github.com/achals/feast/tree/acha/go-wip |
|
chore: Fixes and Readme for python<>go interface
| https://github.com/feast-dev/feast/pull/2936#top |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| achals:acha/go-wip | https://github.com/achals/feast/tree/acha/go-wip |
|
Conversation
12
| https://github.com/feast-dev/feast/pull/2936 |
|
Commits
10
| https://github.com/feast-dev/feast/pull/2936/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/2936/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/2936/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/achals |
| achals | https://github.com/achals |
| Jul 13, 2022 | https://github.com/feast-dev/feast/pull/2936#issue-1302947367 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
size/L
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL |
| Jul 13, 2022 | https://github.com/feast-dev/feast/pull/2936#event-6983020899 |
| https://github.com/codecov-commenter |
| codecov-commenter | https://github.com/codecov-commenter |
| Jul 13, 2022 | https://github.com/feast-dev/feast/pull/2936#issuecomment-1182808538 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| Codecov | https://codecov.io/gh/feast-dev/feast/pull/2936?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| #2936 | https://codecov.io/gh/feast-dev/feast/pull/2936?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| 78b046d | https://github.com/feast-dev/feast/commit/78b046d4ab8ac7d3b27a45959b3b2d187345e7eb |
| master | https://codecov.io/gh/feast-dev/feast/commit/054446cca05b7341dcb5ebe5ee3bc9d679f632e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| 054446c | https://github.com/feast-dev/feast/commit/054446cca05b7341dcb5ebe5ee3bc9d679f632e5 |
| Click here | https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment |
| Impacted Files | https://codecov.io/gh/feast-dev/feast/pull/2936?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| ...ython/feast/embedded_go/online_features_service.py | https://codecov.io/gh/feast-dev/feast/pull/2936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9lbWJlZGRlZF9nby9vbmxpbmVfZmVhdHVyZXNfc2VydmljZS5weQ== |
| .../integration/online_store/test_online_retrieval.py | https://codecov.io/gh/feast-dev/feast/pull/2936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9vbmxpbmVfc3RvcmUvdGVzdF9vbmxpbmVfcmV0cmlldmFsLnB5 |
| sdk/python/tests/utils/online_read_write_test.py | https://codecov.io/gh/feast-dev/feast/pull/2936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy91dGlscy9vbmxpbmVfcmVhZF93cml0ZV90ZXN0LnB5 |
| ...fline_store/test_universal_historical_retrieval.py | https://codecov.io/gh/feast-dev/feast/pull/2936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9vZmZsaW5lX3N0b3JlL3Rlc3RfdW5pdmVyc2FsX2hpc3RvcmljYWxfcmV0cmlldmFsLnB5 |
| ...ts/integration/offline_store/test_offline_write.py | https://codecov.io/gh/feast-dev/feast/pull/2936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9vZmZsaW5lX3N0b3JlL3Rlc3Rfb2ZmbGluZV93cml0ZS5weQ== |
| ...dk/python/tests/integration/e2e/test_validation.py | https://codecov.io/gh/feast-dev/feast/pull/2936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9lMmUvdGVzdF92YWxpZGF0aW9uLnB5 |
| sdk/python/feast/wait.py | https://codecov.io/gh/feast-dev/feast/pull/2936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC93YWl0LnB5 |
| ...ests/integration/e2e/test_python_feature_server.py | https://codecov.io/gh/feast-dev/feast/pull/2936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9lMmUvdGVzdF9weXRob25fZmVhdHVyZV9zZXJ2ZXIucHk= |
| ...ion/registration/test_stream_feature_view_apply.py | https://codecov.io/gh/feast-dev/feast/pull/2936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9yZWdpc3RyYXRpb24vdGVzdF9zdHJlYW1fZmVhdHVyZV92aWV3X2FwcGx5LnB5 |
| ...gration/registration/test_feature_service_apply.py | https://codecov.io/gh/feast-dev/feast/pull/2936/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9yZWdpc3RyYXRpb24vdGVzdF9mZWF0dXJlX3NlcnZpY2VfYXBwbHkucHk= |
| 78 more | https://codecov.io/gh/feast-dev/feast/pull/2936/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Continue to review full report at Codecov | https://codecov.io/gh/feast-dev/feast/pull/2936?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Codecov | https://codecov.io/gh/feast-dev/feast/pull/2936?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| 054446c...78b046d | https://codecov.io/gh/feast-dev/feast/pull/2936?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| comment docs | https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
|
Jul 13, 2022
| https://github.com/feast-dev/feast/pull/2936#pullrequestreview-1037686452 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/2936/files |
| kevjumba | https://github.com/kevjumba |
| https://github.com/feast-dev/feast/pull/2936#pullrequestreview-1037686452 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @achals | https://github.com/achals |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| go/README.md | https://github.com/feast-dev/feast/pull/2936/files#diff-c6fc62c6b8d55a99557d915c8271e03b88d701c19291fcd74021640031504292 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| go/README.md | https://github.com/feast-dev/feast/pull/2936/files#diff-c6fc62c6b8d55a99557d915c8271e03b88d701c19291fcd74021640031504292 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| go/README.md | https://github.com/feast-dev/feast/pull/2936/files#diff-c6fc62c6b8d55a99557d915c8271e03b88d701c19291fcd74021640031504292 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| https://github.com/achals |
| achals | https://github.com/achals |
| Jul 13, 2022 | https://github.com/feast-dev/feast/pull/2936#issuecomment-1183537003 |
| @achals | https://github.com/achals |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| achals | https://github.com/achals |
| July 13, 2022 14:26 | https://github.com/feast-dev/feast/pull/2936#commits-pushed-a5e270d |
|
| https://github.com/achals |
|
| https://github.com/felixwang9817 |
| chore: Fixes and Readme for python<>go interface | https://github.com/feast-dev/feast/pull/2936/commits/a5e270dbb9c1233dd865374899aefeaa869f43b7 |
| a5e270d | https://github.com/feast-dev/feast/pull/2936/commits/a5e270dbb9c1233dd865374899aefeaa869f43b7 |
|
| https://github.com/achals |
|
| https://github.com/felixwang9817 |
| cr | https://github.com/feast-dev/feast/pull/2936/commits/492dc91175b57517486a9b6a06ad90163405460b |
| 492dc91 | https://github.com/feast-dev/feast/pull/2936/commits/492dc91175b57517486a9b6a06ad90163405460b |
|
| https://github.com/felixwang9817 |
| Switch to cgo allocator | https://github.com/feast-dev/feast/pull/2936/commits/f205e41dde9b3db2b285a0a1fbc1077f7617a8af |
| f205e41 | https://github.com/feast-dev/feast/pull/2936/commits/f205e41dde9b3db2b285a0a1fbc1077f7617a8af |
|
| https://github.com/felixwang9817 |
| Fix memory leak | https://github.com/feast-dev/feast/pull/2936/commits/ae71efa50aedb4e5b6b8513e9cd705fe27430afc |
| ae71efa | https://github.com/feast-dev/feast/pull/2936/commits/ae71efa50aedb4e5b6b8513e9cd705fe27430afc |
|
| https://github.com/felixwang9817 |
| Fix another memory leak | https://github.com/feast-dev/feast/pull/2936/commits/a6232d964cf24d27eca5b77247fb2a03354eba75 |
| a6232d9 | https://github.com/feast-dev/feast/pull/2936/commits/a6232d964cf24d27eca5b77247fb2a03354eba75 |
| https://github.com/felixwang9817 |
| felixwang9817 | https://github.com/felixwang9817 |
| force-pushed | https://github.com/feast-dev/feast/compare/2b56aa9b3461ea525f6f86f613c46d257e3760c8..a6232d964cf24d27eca5b77247fb2a03354eba75 |
| 2b56aa9 | https://github.com/feast-dev/feast/commit/2b56aa9b3461ea525f6f86f613c46d257e3760c8 |
| a6232d9 | https://github.com/feast-dev/feast/commit/a6232d964cf24d27eca5b77247fb2a03354eba75 |
|
Compare
| https://github.com/feast-dev/feast/compare/2b56aa9b3461ea525f6f86f613c46d257e3760c8..a6232d964cf24d27eca5b77247fb2a03354eba75 |
| July 14, 2022 00:45 | https://github.com/feast-dev/feast/pull/2936#event-6990059104 |
|
| https://github.com/felixwang9817 |
| Do not use cgo allocator for memory buffers | https://github.com/feast-dev/feast/pull/2936/commits/b0283ed65e0c274336473e11fa0f501776d7caf6 |
| b0283ed | https://github.com/feast-dev/feast/pull/2936/commits/b0283ed65e0c274336473e11fa0f501776d7caf6 |
| https://github.com/achals |
| achals | https://github.com/achals |
|
Jul 14, 2022
| https://github.com/feast-dev/feast/pull/2936#pullrequestreview-1039375738 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/2936/files/b0283ed65e0c274336473e11fa0f501776d7caf6 |
| go/internal/feast/featurestore.go | https://github.com/feast-dev/feast/pull/2936/files/b0283ed65e0c274336473e11fa0f501776d7caf6#diff-3594557be3f2a76645dbe218b5f0318dcc37d0ac406868b8f4229615b82cb8fe |
| achals | https://github.com/achals |
| Jul 14, 2022 | https://github.com/feast-dev/feast/pull/2936#discussion_r921499694 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| felixwang9817 | https://github.com/felixwang9817 |
| Jul 14, 2022 | https://github.com/feast-dev/feast/pull/2936#discussion_r921699471 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #2940 | https://github.com/feast-dev/feast/pull/2940 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| felixwang9817 | https://github.com/felixwang9817 |
| July 14, 2022 14:12 | https://github.com/feast-dev/feast/pull/2936#commits-pushed-9951db9 |
|
| https://github.com/felixwang9817 |
| Switch to cgo allocator for memory buffers | https://github.com/feast-dev/feast/pull/2936/commits/9951db94003db0e2e998e013ce3ac193cc1287e2 |
| 9951db9 | https://github.com/feast-dev/feast/pull/2936/commits/9951db94003db0e2e998e013ce3ac193cc1287e2 |
|
| https://github.com/felixwang9817 |
| Switch test to pass | https://github.com/feast-dev/feast/pull/2936/commits/656cb40f02973e7385ac5627cc2f00cbdf2d20c6 |
| 656cb40 | https://github.com/feast-dev/feast/pull/2936/commits/656cb40f02973e7385ac5627cc2f00cbdf2d20c6 |
| https://github.com/achals |
| achals | https://github.com/achals |
|
Jul 14, 2022
| https://github.com/feast-dev/feast/pull/2936#pullrequestreview-1039536539 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/2936/files/656cb40f02973e7385ac5627cc2f00cbdf2d20c6 |
| go/internal/feast/server/logging/memorybuffer_test.go | https://github.com/feast-dev/feast/pull/2936/files/b0283ed65e0c274336473e11fa0f501776d7caf6..656cb40f02973e7385ac5627cc2f00cbdf2d20c6#diff-1fa5a5594c1ce8e2136fa11bf83f9fde92604b2a2ed14e225a9c9fa8d6effba8 |
| achals | https://github.com/achals |
| Jul 14, 2022 | https://github.com/feast-dev/feast/pull/2936#discussion_r921612240 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://pkg.go.dev/github.com/stretchr/testify/assert#True | https://pkg.go.dev/github.com/stretchr/testify/assert#True |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| felixwang9817 | https://github.com/felixwang9817 |
| Jul 14, 2022 | https://github.com/feast-dev/feast/pull/2936#discussion_r921699396 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| felixwang9817 | https://github.com/felixwang9817 |
| July 14, 2022 16:53 | https://github.com/feast-dev/feast/pull/2936#commits-pushed-9c0b757 |
|
| https://github.com/felixwang9817 |
| Use more idiomatic way to test truth | https://github.com/feast-dev/feast/pull/2936/commits/9c0b757c0b1056fe87b88bda3108d6d584bfaf29 |
| 9c0b757 | https://github.com/feast-dev/feast/pull/2936/commits/9c0b757c0b1056fe87b88bda3108d6d584bfaf29 |
|
| https://github.com/felixwang9817 |
| Update docs | https://github.com/feast-dev/feast/pull/2936/commits/78b046d4ab8ac7d3b27a45959b3b2d187345e7eb |
| 78b046d | https://github.com/feast-dev/feast/pull/2936/commits/78b046d4ab8ac7d3b27a45959b3b2d187345e7eb |
|
segfaults when using go feature server
#2849
| https://github.com/feast-dev/feast/issues/2849 |
|
Memory leaks in Go feature server
#2943
| https://github.com/feast-dev/feast/issues/2943 |
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
|
Jul 15, 2022
| https://github.com/feast-dev/feast/pull/2936#pullrequestreview-1039680826 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/2936/files/78b046d4ab8ac7d3b27a45959b3b2d187345e7eb |
| kevjumba | https://github.com/kevjumba |
| https://github.com/feast-dev/feast/pull/2936#pullrequestreview-1039680826 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| kevjumba | https://github.com/kevjumba |
| Jul 15, 2022 | https://github.com/feast-dev/feast/pull/2936#event-6998484015 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Jul 15, 2022 | https://github.com/feast-dev/feast/pull/2936#event-6998484053 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Jul 15, 2022 | https://github.com/feast-dev/feast/pull/2936#issuecomment-1185070518 |
| achals | https://github.com/feast-dev/feast/pull/2936 |
| kevjumba | https://github.com/feast-dev/feast/pull/2936#pullrequestreview-1039680826 |
| here | https://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process |
| OWNERS | https://github.com/feast-dev/feast/blob/master/OWNERS |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| 268f28d | https://github.com/feast-dev/feast/commit/268f28db37318f6be3872e4bde5de05f377eac69 |
| Jul 15, 2022 | https://github.com/feast-dev/feast/pull/2936#event-6998544962 |
| https://github.com/achals |
| achals | https://github.com/achals |
| July 15, 2022 03:54 | https://github.com/feast-dev/feast/pull/2936#event-6998979868 |
| adchia | https://github.com/adchia |
|
Jul 15, 2022
| https://github.com/feast-dev/feast/pull/2936#ref-commit-a30bf86 |
|
| https://github.com/achals |
|
| https://github.com/felixwang9817 |
|
| https://github.com/adchia |
| chore: Fixes and Readme for python<>go interface ( | https://github.com/feast-dev/feast/commit/a30bf860bb2f29b4a1ac8dbbcb6f6c2f77adc7a5 |
| #2936 | https://github.com/feast-dev/feast/pull/2936 |
| ) | https://github.com/feast-dev/feast/commit/a30bf860bb2f29b4a1ac8dbbcb6f6c2f77adc7a5 |
| a30bf86 | https://github.com/feast-dev/feast/commit/a30bf860bb2f29b4a1ac8dbbcb6f6c2f77adc7a5 |
| kevjumba | https://github.com/kevjumba |
|
Jul 19, 2022
| https://github.com/feast-dev/feast/pull/2936#ref-commit-922dcd3 |
|
| https://github.com/achals |
|
| https://github.com/felixwang9817 |
|
| https://github.com/kevjumba |
| chore: Fixes and Readme for python<>go interface ( | https://github.com/feast-dev/feast/commit/922dcd3be3c359be64addbd306a29a7424414588 |
| #2936 | https://github.com/feast-dev/feast/pull/2936 |
| ) | https://github.com/feast-dev/feast/commit/922dcd3be3c359be64addbd306a29a7424414588 |
| 922dcd3 | https://github.com/feast-dev/feast/commit/922dcd3be3c359be64addbd306a29a7424414588 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2936 |
|
| https://github.com/felixwang9817 |
|
felixwang9817
| https://github.com/felixwang9817 |
|
| https://github.com/feast-dev/feast/pull/2936/files/b0283ed65e0c274336473e11fa0f501776d7caf6 |
|
| https://github.com/kevjumba |
|
kevjumba
| https://github.com/kevjumba |
|
| https://github.com/feast-dev/feast/pull/2936/files/78b046d4ab8ac7d3b27a45959b3b2d187345e7eb |
|
| https://github.com/kevjumba |
|
kevjumba
| https://github.com/kevjumba |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
size/L
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL |
| Please reload this page | https://github.com/feast-dev/feast/pull/2936 |
|
| https://github.com/achals |
|
| https://github.com/codecov-commenter |
|
| https://github.com/feast-ci-bot |
|
| https://github.com/kevjumba |
|
| https://github.com/felixwang9817 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |