| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f3bbe80e-944c-e86b-6df2-9b7c527e4d64 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECA6:2E8AA4:17C015C:2007026:697980E0 |
| html-safe-nonce | 8f4a81c3aab81552242ea1257366379fa3bf046827764a1c6cd3efd0c6e30f79 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0E2OjJFOEFBNDoxN0MwMTVDOjIwMDcwMjY6Njk3OTgwRTAiLCJ2aXNpdG9yX2lkIjoiNDM4ODA4NDgzMDE1MTczNzU2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b35989350b1fc1865adb618816ff31fd144f373051d536683f6b1c8d7dc9b6bd |
| hovercard-subject-tag | pull_request:985345104 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/2901/files |
| twitter:image | https://avatars.githubusercontent.com/u/1452787?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1452787?s=400&v=4 |
| og:image:alt | Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
This is the first pass implementation of the proposal in RFC-037. It's purely interfaces and refactoring without ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c049b65ec7e54cbf2521f5a560b6527714c612b0bd169188e2ea6e16f83bd5f4 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87b137883e35e2766c3d0f6a257c4044f6390b83 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/2901/changes#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2901%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2901%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/2901/changes |
| Reload | https://github.com/feast-dev/feast/pull/2901/changes |
| Reload | https://github.com/feast-dev/feast/pull/2901/changes |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
181
| https://github.com/feast-dev/feast/issues |
|
Pull requests
69
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| achals:achal/wip-batch-engine | https://github.com/achals/feast/tree/achal/wip-batch-engine |
|
Conversation
36
| https://github.com/feast-dev/feast/pull/2901 |
|
Commits
11
| https://github.com/feast-dev/feast/pull/2901/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/2901/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/2901/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/2901/changes |
|
feat: Add interfaces for batch materialization engine
| https://github.com/feast-dev/feast/pull/2901/changes#top |
|
Show all changes
11 commits
| https://github.com/feast-dev/feast/pull/2901/files |
|
6cc7e75
feat: Add scaffolding for batch materialization engine
achals Jul 1, 2022
| https://github.com/feast-dev/feast/pull/2901/commits/6cc7e75bcde31a760df48b9955786e53788dd142 |
|
1656436
fix tests
achals Jul 5, 2022
| https://github.com/feast-dev/feast/pull/2901/commits/165643675ae866a700e88d57d7d811a7f35c0d81 |
|
c16734b
fix tests
achals Jul 5, 2022
| https://github.com/feast-dev/feast/pull/2901/commits/c16734b4d38f3592520740d8a7a5561bbf5bef54 |
|
ceedbab
a little better
achals Jul 5, 2022
| https://github.com/feast-dev/feast/pull/2901/commits/ceedbabcc7ec7445ddefc0036f02e6e2d05bca70 |
|
37fa081
a little better
achals Jul 5, 2022
| https://github.com/feast-dev/feast/pull/2901/commits/37fa0811456566c4041188db0ad005906bedb7be |
|
795e65a
docs
achals Jul 5, 2022
| https://github.com/feast-dev/feast/pull/2901/commits/795e65a2866c3b1279eccc6e21082e8c92fc2207 |
|
5833556
more api updates'
achals Jul 5, 2022
| https://github.com/feast-dev/feast/pull/2901/commits/5833556863f225bdde05c01ad1cd4e2d671bbcf0 |
|
5d1af33
fix typos
achals Jul 6, 2022
| https://github.com/feast-dev/feast/pull/2901/commits/5d1af3396884a250bce1b21abff9f506638e9971 |
|
ff680a9
make engine importable
achals Jul 6, 2022
| https://github.com/feast-dev/feast/pull/2901/commits/ff680a927bd4c781ac0965d67989ae7f4449efb8 |
|
11b6da0
style stuff
achals Jul 6, 2022
| https://github.com/feast-dev/feast/pull/2901/commits/11b6da04d21b595a1ac84eb83a08945b2e1c5d6b |
|
2e9e7a8
style stuff
achals Jul 6, 2022
| https://github.com/feast-dev/feast/pull/2901/commits/2e9e7a8a034c7d6fe1d984fe4e2c1cec3c5670ee |
|
Clear filters
| https://github.com/feast-dev/feast/pull/2901/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/2901/changes |
| Please reload this page | https://github.com/feast-dev/feast/pull/2901/changes |
|
__init__.py
| https://github.com/feast-dev/feast/pull/2901/changes#diff-2536cfa5bde84b127a36ae7c8bf696b63411d805da4135b27585b3a5228862af |
|
batch_materialization_engine.py
| https://github.com/feast-dev/feast/pull/2901/changes#diff-c2c4d8ac0bb5f21f5836d5e1dde0f2a8cc14c9e3d492aa7843f4948283a1a391 |
|
local_engine.py
| https://github.com/feast-dev/feast/pull/2901/changes#diff-f4d4e10809e34d1c6bcec2251c264bb5a914c674baa7b2681a7dc8960311466b |
|
file.py
| https://github.com/feast-dev/feast/pull/2901/changes#diff-88364623e2505581c76f2dcc9afd28eb7090c086631a38f40433715d4db75d63 |
|
offline_utils.py
| https://github.com/feast-dev/feast/pull/2901/changes#diff-f515f3d334f6ab63f082e3d078bcf23f460538b468a5177105cd79440178f376 |
|
passthrough_provider.py
| https://github.com/feast-dev/feast/pull/2901/changes#diff-d9f79a3598724f611628ace828bfb01721e6ffe34cc8f16e313ed9fdd48e8ab2 |
|
provider.py
| https://github.com/feast-dev/feast/pull/2901/changes#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5 |
|
repo_config.py
| https://github.com/feast-dev/feast/pull/2901/changes#diff-c90c6781dcec3cdcc26843e013d3d6e9c1ce89d084b3a67e818fe76a0c7d0436 |
|
utils.py
| https://github.com/feast-dev/feast/pull/2901/changes#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0 |
|
test_provider.py
| https://github.com/feast-dev/feast/pull/2901/changes#diff-4b132cec67a550753c52b0d4d2f9cfa68214d2401ae748312229bc318203fba0 |
|
online_write_benchmark.py
| https://github.com/feast-dev/feast/pull/2901/changes#diff-cb754ef699d5f0e7f03a36c84ba9c5885d621a3f2b604b5a2139b8d030c9b88c |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/infra/materialization/__init__.py | https://github.com/feast-dev/feast/pull/2901/changes#diff-2536cfa5bde84b127a36ae7c8bf696b63411d805da4135b27585b3a5228862af |
|
View file
| https://github.com/achals/feast/blob/2e9e7a8a034c7d6fe1d984fe4e2c1cec3c5670ee/sdk/python/feast/infra/materialization/__init__.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/2901/{{ revealButtonHref }} |
| Please reload this page | https://github.com/feast-dev/feast/pull/2901/changes |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/infra/materialization/batch_materialization_engine.py | https://github.com/feast-dev/feast/pull/2901/changes#diff-c2c4d8ac0bb5f21f5836d5e1dde0f2a8cc14c9e3d492aa7843f4948283a1a391 |
|
View file
| https://github.com/achals/feast/blob/2e9e7a8a034c7d6fe1d984fe4e2c1cec3c5670ee/sdk/python/feast/infra/materialization/batch_materialization_engine.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/2901/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/infra/materialization/local_engine.py | https://github.com/feast-dev/feast/pull/2901/changes#diff-f4d4e10809e34d1c6bcec2251c264bb5a914c674baa7b2681a7dc8960311466b |
|
View file
| https://github.com/achals/feast/blob/2e9e7a8a034c7d6fe1d984fe4e2c1cec3c5670ee/sdk/python/feast/infra/materialization/local_engine.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/2901/{{ revealButtonHref }} |
| Please reload this page | https://github.com/feast-dev/feast/pull/2901/changes |
| Please reload this page | https://github.com/feast-dev/feast/pull/2901/changes |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/infra/offline_stores/file.py | https://github.com/feast-dev/feast/pull/2901/changes#diff-88364623e2505581c76f2dcc9afd28eb7090c086631a38f40433715d4db75d63 |
|
View file
| https://github.com/achals/feast/blob/2e9e7a8a034c7d6fe1d984fe4e2c1cec3c5670ee/sdk/python/feast/infra/offline_stores/file.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/2901/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/2901/changes#diff-88364623e2505581c76f2dcc9afd28eb7090c086631a38f40433715d4db75d63 |
|
| https://github.com/feast-dev/feast/pull/2901/changes#diff-88364623e2505581c76f2dcc9afd28eb7090c086631a38f40433715d4db75d63 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L20 |
| sdk/python/feast/infra/offline_stores/offline_utils.py | https://github.com/feast-dev/feast/pull/2901/changes#diff-f515f3d334f6ab63f082e3d078bcf23f460538b468a5177105cd79440178f376 |
|
View file
| https://github.com/achals/feast/blob/2e9e7a8a034c7d6fe1d984fe4e2c1cec3c5670ee/sdk/python/feast/infra/offline_stores/offline_utils.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/2901/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/2901/changes#diff-f515f3d334f6ab63f082e3d078bcf23f460538b468a5177105cd79440178f376 |
|
| https://github.com/feast-dev/feast/pull/2901/changes#diff-f515f3d334f6ab63f082e3d078bcf23f460538b468a5177105cd79440178f376 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2901/changes |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |