| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2ff272e8-000a-1b41-ac65-11d5427a9603 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A732:11E2A6:2C317A:3CCE34:6978B297 |
| html-safe-nonce | fd638647f2a11aa3dcd74c2845fe41a2d7dc2ded5fb060ffb78d4aa76c818bca |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzMyOjExRTJBNjoyQzMxN0E6M0NDRTM0OjY5NzhCMjk3IiwidmlzaXRvcl9pZCI6Ijg5MDU2NTAzMTY3NzkyMzgwNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 11404582c839e4d368350efb06a152c2815a77ed748de0367eff2bf4288f1f2e |
| hovercard-subject-tag | pull_request:976347054 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/2841/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/59efc186e2db9a48088b1b7261859f82d0f52438a86e0c9f73f72c3ee76e5ad7/feast-dev/feast/pull/2841 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/59efc186e2db9a48088b1b7261859f82d0f52438a86e0c9f73f72c3ee76e5ad7/feast-dev/feast/pull/2841 |
| og:image:alt | Signed-off-by: Kevin Zhang kzhang@tecton.ai
What this PR does / why we need it:
Undoes part of #2815 and does so because of #2839.
Which issue(s) this PR fixes:
Fixes # |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kevjumba |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8aa86d87c47054170094daaf9699b27a28a8448 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/2841#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2841 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2841 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/2841 |
| Reload | https://github.com/feast-dev/feast/pull/2841 |
| Reload | https://github.com/feast-dev/feast/pull/2841 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
182
| https://github.com/feast-dev/feast/issues |
|
Pull requests
67
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/2841#issue-comment-box |
| kevjumba | https://github.com/kevjumba |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| kevjumba:renable_go_test | https://github.com/kevjumba/feast/tree/renable_go_test |
|
fix: Renable tests after fixing gopy installation issue that was blocking tests.
| https://github.com/feast-dev/feast/pull/2841#top |
| kevjumba | https://github.com/kevjumba |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| kevjumba:renable_go_test | https://github.com/kevjumba/feast/tree/renable_go_test |
|
Conversation
3
| https://github.com/feast-dev/feast/pull/2841 |
|
Commits
2
| https://github.com/feast-dev/feast/pull/2841/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/2841/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/2841/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/2841 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#issue-1281502474 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2841 |
| #2815 | https://github.com/feast-dev/feast/pull/2815 |
| #2839 | https://github.com/feast-dev/feast/pull/2839 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2841 |
|
| https://github.com/kevjumba |
| Renable tests | https://github.com/feast-dev/feast/pull/2841/commits/ae703871dc67f6a3bc351f3beb5cda1fbd8f9401 |
| ae70387 | https://github.com/feast-dev/feast/pull/2841/commits/ae703871dc67f6a3bc351f3beb5cda1fbd8f9401 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#issuecomment-1163837715 |
| kevjumba | https://github.com/feast-dev/feast/pull/2841 |
| here | https://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process |
| OWNERS | https://github.com/feast-dev/feast/blob/master/OWNERS |
| Please reload this page | https://github.com/feast-dev/feast/pull/2841 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#event-6862029847 |
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#event-6862030080 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
size/S
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FS |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#event-6862030462 |
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#event-6862033769 |
| https://github.com/codecov-commenter |
| codecov-commenter | https://github.com/codecov-commenter |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#issuecomment-1163840850 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2841 |
| Codecov | https://codecov.io/gh/feast-dev/feast/pull/2841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| #2841 | https://codecov.io/gh/feast-dev/feast/pull/2841?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| ae70387 | https://github.com/feast-dev/feast/commit/ae703871dc67f6a3bc351f3beb5cda1fbd8f9401 |
| master | https://codecov.io/gh/feast-dev/feast/commit/a88cd30f7925005db6f7c400b391d5e73d1b00f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| a88cd30 | https://github.com/feast-dev/feast/commit/a88cd30f7925005db6f7c400b391d5e73d1b00f6 |
| Click here | https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment |
| Impacted Files | https://codecov.io/gh/feast-dev/feast/pull/2841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| ...on/tests/integration/e2e/test_go_feature_server.py | https://codecov.io/gh/feast-dev/feast/pull/2841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9lMmUvdGVzdF9nb19mZWF0dXJlX3NlcnZlci5weQ== |
| .../integration/online_store/test_universal_online.py | https://codecov.io/gh/feast-dev/feast/pull/2841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9vbmxpbmVfc3RvcmUvdGVzdF91bml2ZXJzYWxfb25saW5lLnB5 |
| .../integration/online_store/test_online_retrieval.py | https://codecov.io/gh/feast-dev/feast/pull/2841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9vbmxpbmVfc3RvcmUvdGVzdF9vbmxpbmVfcmV0cmlldmFsLnB5 |
| sdk/python/tests/utils/online_read_write_test.py | https://codecov.io/gh/feast-dev/feast/pull/2841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy91dGlscy9vbmxpbmVfcmVhZF93cml0ZV90ZXN0LnB5 |
| ...fline_store/test_universal_historical_retrieval.py | https://codecov.io/gh/feast-dev/feast/pull/2841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9vZmZsaW5lX3N0b3JlL3Rlc3RfdW5pdmVyc2FsX2hpc3RvcmljYWxfcmV0cmlldmFsLnB5 |
| ...ts/integration/offline_store/test_offline_write.py | https://codecov.io/gh/feast-dev/feast/pull/2841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9vZmZsaW5lX3N0b3JlL3Rlc3Rfb2ZmbGluZV93cml0ZS5weQ== |
| ...ests/integration/e2e/test_python_feature_server.py | https://codecov.io/gh/feast-dev/feast/pull/2841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9lMmUvdGVzdF9weXRob25fZmVhdHVyZV9zZXJ2ZXIucHk= |
| ...dk/python/tests/integration/e2e/test_validation.py | https://codecov.io/gh/feast-dev/feast/pull/2841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9lMmUvdGVzdF92YWxpZGF0aW9uLnB5 |
| sdk/python/feast/wait.py | https://codecov.io/gh/feast-dev/feast/pull/2841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC93YWl0LnB5 |
| 77 more | https://codecov.io/gh/feast-dev/feast/pull/2841/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Continue to review full report at Codecov | https://codecov.io/gh/feast-dev/feast/pull/2841?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Codecov | https://codecov.io/gh/feast-dev/feast/pull/2841?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| a88cd30...ae70387 | https://codecov.io/gh/feast-dev/feast/pull/2841?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| comment docs | https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Please reload this page | https://github.com/feast-dev/feast/pull/2841 |
| https://github.com/achals |
| achals | https://github.com/achals |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#issuecomment-1163870056 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2841 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2841 |
| https://github.com/achals |
| achals | https://github.com/achals |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#event-6862643614 |
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#event-6863203829 |
|
| https://github.com/kevjumba |
| Renable tests | https://github.com/feast-dev/feast/pull/2841/commits/e104b8ab7e204351a35f90892d0a68275bd5bc67 |
| e104b8a | https://github.com/feast-dev/feast/pull/2841/commits/e104b8ab7e204351a35f90892d0a68275bd5bc67 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
size/XS
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXS |
|
size/S
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FS |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#event-6867781400 |
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
| Jun 23, 2022 | https://github.com/feast-dev/feast/pull/2841#event-6867794363 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2841 |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
|
size/XS
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXS |
| Please reload this page | https://github.com/feast-dev/feast/pull/2841 |
|
| https://github.com/kevjumba |
|
| https://github.com/feast-ci-bot |
|
| https://github.com/codecov-commenter |
|
| https://github.com/achals |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |