René's URL Explorer Experiment


Title: fix: Prefer installing gopy from feast's fork as opposed to upstream by achals · Pull Request #2839 · feast-dev/feast · GitHub

Open Graph Title: fix: Prefer installing gopy from feast's fork as opposed to upstream by achals · Pull Request #2839 · feast-dev/feast

X Title: fix: Prefer installing gopy from feast's fork as opposed to upstream by achals · Pull Request #2839 · feast-dev/feast

Description: Signed-off-by: Achal Shah achals@gmail.com What this PR does / why we need it: In go.mod, we're replacing go-python/gopy with feast-dev/gopy, but for whatever reason we don't do the same thing in setup.py or Makefile. This results in us using a different version of gopy from the one that will actually work (i.e. our fork). This was made worse by the face the the upstream repo landed a bunch of commits and the new version of that project totally borked our build process. I think this should fix the release pipeline (https://github.com/feast-dev/feast/runs/6993658741?check_suite_focus=true) as well as the flaky test (#2830) Which issue(s) this PR fixes: Fixes #

Open Graph Description: Signed-off-by: Achal Shah achals@gmail.com What this PR does / why we need it: In go.mod, we're replacing go-python/gopy with feast-dev/gopy, but for whatever reason we don't do the same t...

X Description: Signed-off-by: Achal Shah achals@gmail.com What this PR does / why we need it: In go.mod, we're replacing go-python/gopy with feast-dev/gopy, but for whatever reason we don't do th...

Opengraph URL: https://github.com/feast-dev/feast/pull/2839

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dc69b8fd-196f-554a-09eb-2c759d254358
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCDE4:21ACC7:986ED:D6572:697890AC
html-safe-nonce1e91625d1569d0cbc257a8960df7fcc6e27d735a06547d7da79ab2fffe20f35e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREU0OjIxQUNDNzo5ODZFRDpENjU3Mjo2OTc4OTBBQyIsInZpc2l0b3JfaWQiOiI0NjczNjI5NTMzMTg4NDI3OTQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdf36d93b0c2cd341ce3a39f6fb5361724721fae3820e57e33ac1c5014ec46e8a
hovercard-subject-tagpull_request:975763708
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/2839/files
twitter:imagehttps://avatars.githubusercontent.com/u/1452787?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1452787?s=400&v=4
og:image:altSigned-off-by: Achal Shah achals@gmail.com What this PR does / why we need it: In go.mod, we're replacing go-python/gopy with feast-dev/gopy, but for whatever reason we don't do the same t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea49c4df0dedcf1a70c07cccb99337400ec284247
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/2839/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2839%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2839%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/2839/files
Reloadhttps://github.com/feast-dev/feast/pull/2839/files
Reloadhttps://github.com/feast-dev/feast/pull/2839/files
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 182 https://github.com/feast-dev/feast/issues
Pull requests 66 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
achals:achal/prefer-feast-gopyhttps://github.com/achals/feast/tree/achal/prefer-feast-gopy
Conversation 16 https://github.com/feast-dev/feast/pull/2839
Commits 7 https://github.com/feast-dev/feast/pull/2839/commits
Checks 0 https://github.com/feast-dev/feast/pull/2839/checks
Files changed https://github.com/feast-dev/feast/pull/2839/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2839/files
fix: Prefer installing gopy from feast's fork as opposed to upstream https://github.com/feast-dev/feast/pull/2839/files#top
Show all changes 7 commits https://github.com/feast-dev/feast/pull/2839/files
3f56535 fix: Prefer installing gopy from feast's fork as opposed to upstream achals Jun 22, 2022 https://github.com/feast-dev/feast/pull/2839/commits/3f565357db58a22d38e2c5a00f8f49f7210b0128
c37c576 use go mod tidy achals Jun 22, 2022 https://github.com/feast-dev/feast/pull/2839/commits/c37c57658f90f79fe17dbeb107720b032f4cfeb7
a5445aa pin and pray achals Jun 22, 2022 https://github.com/feast-dev/feast/pull/2839/commits/a5445aa849ac9a22b22607d5f96e0be2fc0e2eae
929891d fix import path achals Jun 22, 2022 https://github.com/feast-dev/feast/pull/2839/commits/929891ddd5710ae4ad3e8e80fabbe58acc78ba74
13aa9ba nix go install achals Jun 22, 2022 https://github.com/feast-dev/feast/pull/2839/commits/13aa9ba480e18faf47cd60c58f42d93d2fe45fd0
5b107d6 pin go get and add back unpinned go install, and fix other tests achals Jun 22, 2022 https://github.com/feast-dev/feast/pull/2839/commits/5b107d6a9bc217c4743bb0606e35ec005ba44e01
e70cf69 cr achals Jun 22, 2022 https://github.com/feast-dev/feast/pull/2839/commits/e70cf6988741fae787ef5754e046cd5ae1b5b3c3
Clear filters https://github.com/feast-dev/feast/pull/2839/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2839/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2839/files
Makefile https://github.com/feast-dev/feast/pull/2839/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
go.mod https://github.com/feast-dev/feast/pull/2839/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
go.sum https://github.com/feast-dev/feast/pull/2839/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
test_e2e_local.py https://github.com/feast-dev/feast/pull/2839/files#diff-10140c7690c78fe488bfea4779fb9b492e9e432fa91839e0c01ba1e7a3d09e5c
cli_utils.py https://github.com/feast-dev/feast/pull/2839/files#diff-38541f46c31704937a90a4822488d0e80fe1c8b1e3250f588ec4bc635154d2c4
setup.py https://github.com/feast-dev/feast/pull/2839/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
Makefilehttps://github.com/feast-dev/feast/pull/2839/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
View file https://github.com/achals/feast/blob/e70cf6988741fae787ef5754e046cd5ae1b5b3c3/Makefile
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2839/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2839/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
https://github.com/feast-dev/feast/pull/2839/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
go.modhttps://github.com/feast-dev/feast/pull/2839/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
View file https://github.com/achals/feast/blob/e70cf6988741fae787ef5754e046cd5ae1b5b3c3/go.mod
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2839/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2839/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
adchiahttps://github.com/adchia
Jun 22, 2022https://github.com/feast-dev/feast/pull/2839/files#r904394291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2839/files
pyalexhttps://github.com/pyalex
Jun 22, 2022https://github.com/feast-dev/feast/pull/2839/files#r904401208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2839/files
achalshttps://github.com/achals
Jun 22, 2022https://github.com/feast-dev/feast/pull/2839/files#r904406256
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@pyalexhttps://github.com/pyalex
Please reload this pagehttps://github.com/feast-dev/feast/pull/2839/files
achalshttps://github.com/achals
Jun 23, 2022https://github.com/feast-dev/feast/pull/2839/files#r904406904
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2839/files
https://github.com/feast-dev/feast/pull/2839/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
https://github.com/feast-dev/feast/pull/2839/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
go.sumhttps://github.com/feast-dev/feast/pull/2839/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
View file https://github.com/achals/feast/blob/e70cf6988741fae787ef5754e046cd5ae1b5b3c3/go.sum
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2839/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2839/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
https://github.com/feast-dev/feast/pull/2839/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
https://github.com/feast-dev/feast/pull/2839/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
https://github.com/feast-dev/feast/pull/2839/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/integration/online_store/test_e2e_local.pyhttps://github.com/feast-dev/feast/pull/2839/files#diff-10140c7690c78fe488bfea4779fb9b492e9e432fa91839e0c01ba1e7a3d09e5c
View file https://github.com/achals/feast/blob/e70cf6988741fae787ef5754e046cd5ae1b5b3c3/sdk/python/tests/integration/online_store/test_e2e_local.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2839/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2839/files#diff-10140c7690c78fe488bfea4779fb9b492e9e432fa91839e0c01ba1e7a3d09e5c
https://github.com/feast-dev/feast/pull/2839/files#diff-10140c7690c78fe488bfea4779fb9b492e9e432fa91839e0c01ba1e7a3d09e5c
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/utils/cli_utils.pyhttps://github.com/feast-dev/feast/pull/2839/files#diff-38541f46c31704937a90a4822488d0e80fe1c8b1e3250f588ec4bc635154d2c4
View file https://github.com/achals/feast/blob/e70cf6988741fae787ef5754e046cd5ae1b5b3c3/sdk/python/tests/utils/cli_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2839/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2839/files#diff-38541f46c31704937a90a4822488d0e80fe1c8b1e3250f588ec4bc635154d2c4
setup.pyhttps://github.com/feast-dev/feast/pull/2839/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
View file https://github.com/achals/feast/blob/e70cf6988741fae787ef5754e046cd5ae1b5b3c3/setup.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2839/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2839/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://github.com/feast-dev/feast/pull/2839/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://github.com/feast-dev/feast/pull/2839/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://github.com/feast-dev/feast/pull/2839/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://github.com/feast-dev/feast/pull/2839/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.