René's URL Explorer Experiment


Title: feat: Support retrieval from multiple feature views with different join keys by yongheng · Pull Request #2835 · feast-dev/feast · GitHub

Open Graph Title: feat: Support retrieval from multiple feature views with different join keys by yongheng · Pull Request #2835 · feast-dev/feast

X Title: feat: Support retrieval from multiple feature views with different join keys by yongheng · Pull Request #2835 · feast-dev/feast

Description: What this PR does / why we need it: Currently Java Feature Server doesn't support retrieval from multiple feature views with different join keys. For each gPRC request, OnlineServingServiceV2 calls OnlineRetriever once and only once. In this call the former sends all join keys in the original request to the latter, and the latter simply sorts and concatenates all join keys to make a Redis key. This PR supports retrieval from multiple feature views with different join keys. For each gPRC request, it groups feature references by join keys and for each group it makes a call to OnlineRetriever. Which issue(s) this PR fixes: Fixes #

Open Graph Description: What this PR does / why we need it: Currently Java Feature Server doesn't support retrieval from multiple feature views with different join keys. For each gPRC request, OnlineServingServiceV2 c...

X Description: What this PR does / why we need it: Currently Java Feature Server doesn't support retrieval from multiple feature views with different join keys. For each gPRC request, OnlineServingService...

Opengraph URL: https://github.com/feast-dev/feast/pull/2835

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d5d02ce3-f7ad-b84a-3ed5-c32a4a6c3016
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC0DE:261BF9:12FD6D2:1ACF679:6979DE02
html-safe-nonce0ba4603dd17f13d6d067c126c83ed12543faa873015d9ce211e30a84d4027f87
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMERFOjI2MUJGOToxMkZENkQyOjFBQ0Y2Nzk6Njk3OURFMDIiLCJ2aXNpdG9yX2lkIjoiMTIwOTkyMTkwMjg1MjMwMDI5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9e1c4a6181feec93db1bc2438d25c5c6ae5b1e622fc0608177961139a5b2d042
hovercard-subject-tagpull_request:974899233
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/2835/files
twitter:imagehttps://avatars.githubusercontent.com/u/1619567?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1619567?s=400&v=4
og:image:altWhat this PR does / why we need it: Currently Java Feature Server doesn't support retrieval from multiple feature views with different join keys. For each gPRC request, OnlineServingServiceV2 c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2b107eb9d90c9cac30a73eb8cbff9f061e7aa8abfc974388da184e33e9167b4a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef6fa9e90ef424d47fefcf2b081f57fd855fc2959
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/2835/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2835%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2835%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/2835/changes
Reloadhttps://github.com/feast-dev/feast/pull/2835/changes
Reloadhttps://github.com/feast-dev/feast/pull/2835/changes
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 181 https://github.com/feast-dev/feast/issues
Pull requests 69 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
yongheng:retrieve-multiple-fvshttps://github.com/yongheng/feast/tree/retrieve-multiple-fvs
Conversation 16 https://github.com/feast-dev/feast/pull/2835
Commits 5 https://github.com/feast-dev/feast/pull/2835/commits
Checks 0 https://github.com/feast-dev/feast/pull/2835/checks
Files changed https://github.com/feast-dev/feast/pull/2835/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2835/changes
feat: Support retrieval from multiple feature views with different join keys https://github.com/feast-dev/feast/pull/2835/changes#top
Show all changes 5 commits https://github.com/feast-dev/feast/pull/2835/files
8faefa2 feat: Support retrieving from multiple feature views yongheng Jun 22, 2022 https://github.com/feast-dev/feast/pull/2835/commits/8faefa203f2a1f9198d2f9f4e16cfa03ad7417ec
b8910ea group by join keys instead of feature view yongheng Jun 22, 2022 https://github.com/feast-dev/feast/pull/2835/commits/b8910eaab0d12886b8af9d40188d6cf94cd01b96
6480640 tolerate insufficient entities yongheng Jun 22, 2022 https://github.com/feast-dev/feast/pull/2835/commits/6480640e18cbbcd97aac9b8f933b5cbd8986d801
f5b12ef mock registry.getEntityJoinKey yongheng Jun 22, 2022 https://github.com/feast-dev/feast/pull/2835/commits/f5b12ef1ee057edcbf8e53f54fc8e1fcc599ca94
0b4fedc add integration test yongheng Jun 24, 2022 https://github.com/feast-dev/feast/pull/2835/commits/0b4fedc9d20ab485d02f7d6f4f6f363454389492
Clear filters https://github.com/feast-dev/feast/pull/2835/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2835/changes
Please reload this pagehttps://github.com/feast-dev/feast/pull/2835/changes
Registry.java https://github.com/feast-dev/feast/pull/2835/changes#diff-d97511acfdcf579fb9ea403506d71deb3c3a31687c219db3161525be7efd91ab
RegistryRepository.java https://github.com/feast-dev/feast/pull/2835/changes#diff-c7d02a3b26883647a41c2a9745c876ce02bbad7f384eb6f1e9608764c700300f
OnlineServingServiceV2.java https://github.com/feast-dev/feast/pull/2835/changes#diff-ff604cedff2831dc1db08b017aab8dce07a91e20be23dd26787e468da8a1e845
ServingBaseTests.java https://github.com/feast-dev/feast/pull/2835/changes#diff-4c8392db76e6cbe1556f50f3e1df09dd66711bd5a33552d67f28958cd85a7096
OnlineServingServiceTest.java https://github.com/feast-dev/feast/pull/2835/changes#diff-1b2a52bc74e1ec31d4db831e91a7758a2e4fcb7fbfdb71d7f2e2dbd836043829
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L8
java/serving/src/main/java/feast/serving/registry/Registry.javahttps://github.com/feast-dev/feast/pull/2835/changes#diff-d97511acfdcf579fb9ea403506d71deb3c3a31687c219db3161525be7efd91ab
View file https://github.com/yongheng/feast/blob/0b4fedc9d20ab485d02f7d6f4f6f363454389492/java/serving/src/main/java/feast/serving/registry/Registry.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2835/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2835/changes#diff-d97511acfdcf579fb9ea403506d71deb3c3a31687c219db3161525be7efd91ab
https://github.com/feast-dev/feast/pull/2835/changes#diff-d97511acfdcf579fb9ea403506d71deb3c3a31687c219db3161525be7efd91ab
https://github.com/feast-dev/feast/pull/2835/changes#diff-d97511acfdcf579fb9ea403506d71deb3c3a31687c219db3161525be7efd91ab
https://github.com/feast-dev/feast/pull/2835/changes#diff-d97511acfdcf579fb9ea403506d71deb3c3a31687c219db3161525be7efd91ab
https://github.com/feast-dev/feast/pull/2835/changes#diff-d97511acfdcf579fb9ea403506d71deb3c3a31687c219db3161525be7efd91ab
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L8
java/serving/src/main/java/feast/serving/registry/RegistryRepository.javahttps://github.com/feast-dev/feast/pull/2835/changes#diff-c7d02a3b26883647a41c2a9745c876ce02bbad7f384eb6f1e9608764c700300f
View file https://github.com/yongheng/feast/blob/0b4fedc9d20ab485d02f7d6f4f6f363454389492/java/serving/src/main/java/feast/serving/registry/RegistryRepository.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2835/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2835/changes#diff-c7d02a3b26883647a41c2a9745c876ce02bbad7f384eb6f1e9608764c700300f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L8
java/serving/src/main/java/feast/serving/service/OnlineServingServiceV2.javahttps://github.com/feast-dev/feast/pull/2835/changes#diff-ff604cedff2831dc1db08b017aab8dce07a91e20be23dd26787e468da8a1e845
View file https://github.com/yongheng/feast/blob/0b4fedc9d20ab485d02f7d6f4f6f363454389492/java/serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2835/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2835/changes#diff-ff604cedff2831dc1db08b017aab8dce07a91e20be23dd26787e468da8a1e845
https://github.com/feast-dev/feast/pull/2835/changes#diff-ff604cedff2831dc1db08b017aab8dce07a91e20be23dd26787e468da8a1e845
https://github.com/feast-dev/feast/pull/2835/changes#diff-ff604cedff2831dc1db08b017aab8dce07a91e20be23dd26787e468da8a1e845
https://github.com/feast-dev/feast/pull/2835/changes#diff-ff604cedff2831dc1db08b017aab8dce07a91e20be23dd26787e468da8a1e845
https://github.com/feast-dev/feast/pull/2835/changes#diff-ff604cedff2831dc1db08b017aab8dce07a91e20be23dd26787e468da8a1e845
https://github.com/feast-dev/feast/pull/2835/changes#diff-ff604cedff2831dc1db08b017aab8dce07a91e20be23dd26787e468da8a1e845
pyalexhttps://github.com/pyalex
Jun 22, 2022https://github.com/feast-dev/feast/pull/2835/changes#r904356414
Please reload this pagehttps://github.com/feast-dev/feast/pull/2835/changes
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2835/changes
yonghenghttps://github.com/yongheng
Jun 23, 2022https://github.com/feast-dev/feast/pull/2835/changes#r904414946
Please reload this pagehttps://github.com/feast-dev/feast/pull/2835/changes
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
L286https://github.com/feast-dev/feast/pull/2835/files#diff-ff604cedff2831dc1db08b017aab8dce07a91e20be23dd26787e468da8a1e845R286
second commithttps://github.com/feast-dev/feast/pull/2835/commits/2c9f702756a4313218d78ea51007e753dae12170
Please reload this pagehttps://github.com/feast-dev/feast/pull/2835/changes
https://github.com/feast-dev/feast/pull/2835/changes#diff-ff604cedff2831dc1db08b017aab8dce07a91e20be23dd26787e468da8a1e845
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L8
java/serving/src/test/java/feast/serving/it/ServingBaseTests.javahttps://github.com/feast-dev/feast/pull/2835/changes#diff-4c8392db76e6cbe1556f50f3e1df09dd66711bd5a33552d67f28958cd85a7096
View file https://github.com/yongheng/feast/blob/0b4fedc9d20ab485d02f7d6f4f6f363454389492/java/serving/src/test/java/feast/serving/it/ServingBaseTests.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2835/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2835/changes#diff-4c8392db76e6cbe1556f50f3e1df09dd66711bd5a33552d67f28958cd85a7096
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L8
java/serving/src/test/java/feast/serving/service/OnlineServingServiceTest.javahttps://github.com/feast-dev/feast/pull/2835/changes#diff-1b2a52bc74e1ec31d4db831e91a7758a2e4fcb7fbfdb71d7f2e2dbd836043829
View file https://github.com/yongheng/feast/blob/0b4fedc9d20ab485d02f7d6f4f6f363454389492/java/serving/src/test/java/feast/serving/service/OnlineServingServiceTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2835/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2835/changes#diff-1b2a52bc74e1ec31d4db831e91a7758a2e4fcb7fbfdb71d7f2e2dbd836043829
https://github.com/feast-dev/feast/pull/2835/changes#diff-1b2a52bc74e1ec31d4db831e91a7758a2e4fcb7fbfdb71d7f2e2dbd836043829
https://github.com/feast-dev/feast/pull/2835/changes#diff-1b2a52bc74e1ec31d4db831e91a7758a2e4fcb7fbfdb71d7f2e2dbd836043829
https://github.com/feast-dev/feast/pull/2835/changes#diff-1b2a52bc74e1ec31d4db831e91a7758a2e4fcb7fbfdb71d7f2e2dbd836043829
https://github.com/feast-dev/feast/pull/2835/changes#diff-1b2a52bc74e1ec31d4db831e91a7758a2e4fcb7fbfdb71d7f2e2dbd836043829
https://github.com/feast-dev/feast/pull/2835/changes#diff-1b2a52bc74e1ec31d4db831e91a7758a2e4fcb7fbfdb71d7f2e2dbd836043829
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.