René's URL Explorer Experiment


Title: feat: Add file write_to_offline_store functionality by kevjumba · Pull Request #2808 · feast-dev/feast · GitHub

Open Graph Title: feat: Add file write_to_offline_store functionality by kevjumba · Pull Request #2808 · feast-dev/feast

X Title: feat: Add file write_to_offline_store functionality by kevjumba · Pull Request #2808 · feast-dev/feast

Description: What this PR does / why we need it: The interface for write_to_offline_store is changing(i.e the dataframe passed in is an arrow table instead of a pandas dataframe. The reason for this is because is we have to convet the pandas dataframe to pyarrow table for write anyways but some functions such as _run_field_mapping use pyarrow table so it makes more sense to not rewrite code and just convert the pyarrow table earlier. Which issue(s) this PR fixes: Fixes #

Open Graph Description: What this PR does / why we need it: The interface for write_to_offline_store is changing(i.e the dataframe passed in is an arrow table instead of a pandas dataframe. The reason for this is because ...

X Description: What this PR does / why we need it: The interface for write_to_offline_store is changing(i.e the dataframe passed in is an arrow table instead of a pandas dataframe. The reason for this is because ...

Opengraph URL: https://github.com/feast-dev/feast/pull/2808

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1a161851-ed54-7494-3794-3d082a9e58bb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7F8:154BC2:E750E4:14A3D43:6978CDDA
html-safe-nonceb8a76d5b5e7be1cc300f855d649e94bf3f0be6530cbbd6cbc839cdb01b273f10
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0Y4OjE1NEJDMjpFNzUwRTQ6MTRBM0Q0Mzo2OTc4Q0REQSIsInZpc2l0b3JfaWQiOiI4NTc1NzgxODMzNDYxNDY3NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3f2cf20575fcf4e397b3991857652a97257c14077d4d0a35bdbe0aec113ca356
hovercard-subject-tagpull_request:969959624
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/2808/files
twitter:imagehttps://avatars.githubusercontent.com/u/7833572?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7833572?s=400&v=4
og:image:altWhat this PR does / why we need it: The interface for write_to_offline_store is changing(i.e the dataframe passed in is an arrow table instead of a pandas dataframe. The reason for this is because ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None8a71ca1f7ab5436216e1df86f398ef7a51ed3152c90e3f7332fc70cf97fcb9d6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeaed570eead52a9920afef75dc3eb6d826fdc5ef
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/2808/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2808%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2808%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/2808/changes
Reloadhttps://github.com/feast-dev/feast/pull/2808/changes
Reloadhttps://github.com/feast-dev/feast/pull/2808/changes
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 181 https://github.com/feast-dev/feast/issues
Pull requests 67 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
kevjumba:filehttps://github.com/kevjumba/feast/tree/file
Conversation 20 https://github.com/feast-dev/feast/pull/2808
Commits 11 https://github.com/feast-dev/feast/pull/2808/commits
Checks 0 https://github.com/feast-dev/feast/pull/2808/checks
Files changed https://github.com/feast-dev/feast/pull/2808/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2808/changes
feat: Add file write_to_offline_store functionality https://github.com/feast-dev/feast/pull/2808/changes#top
Show all changes 11 commits https://github.com/feast-dev/feast/pull/2808/files
58ce39d Skaffolding for offline store push kevjumba Jun 14, 2022 https://github.com/feast-dev/feast/pull/2808/commits/58ce39d93fa43532203666623a83b40ac3ccde3e
656fb9f LInt kevjumba Jun 14, 2022 https://github.com/feast-dev/feast/pull/2808/commits/656fb9f218218d779c350c2219cb7b470f02d9f5
83f0d2f Fix kevjumba Jun 14, 2022 https://github.com/feast-dev/feast/pull/2808/commits/83f0d2f229a4ad58991dd87ae5d01012136b1277
c21f6c2 File source offline push kevjumba Jun 16, 2022 https://github.com/feast-dev/feast/pull/2808/commits/c21f6c2f3b765d4576785bfe3595107469b74340
d4b678a Fix kevjumba Jun 16, 2022 https://github.com/feast-dev/feast/pull/2808/commits/d4b678ac4b549c5c07eaa730991aec42ed6681bd
3e96ac1 Fix kevjumba Jun 16, 2022 https://github.com/feast-dev/feast/pull/2808/commits/3e96ac14b217a0908d55a4835fb522db1ad6986e
f2d77ef Fix kevjumba Jun 16, 2022 https://github.com/feast-dev/feast/pull/2808/commits/f2d77efe35320908c26f0931e99f7c2a9002b598
8049390 Fix kevjumba Jun 16, 2022 https://github.com/feast-dev/feast/pull/2808/commits/8049390a450fbb6bf65402adbb419aee448c8034
7a4be44 Fix kevjumba Jun 17, 2022 https://github.com/feast-dev/feast/pull/2808/commits/7a4be4453d4f4210dc66b9f889e5cc41b8f525cb
f283f72 Fix kevjumba Jun 17, 2022 https://github.com/feast-dev/feast/pull/2808/commits/f283f720805da9fd3a023b4dd3fe7ccd3b80d502
13fa653 Address review comments kevjumba Jun 17, 2022 https://github.com/feast-dev/feast/pull/2808/commits/13fa653836da74c717f7d7e17a507cfbd7f73f7d
Clear filters https://github.com/feast-dev/feast/pull/2808/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2808/changes
Please reload this pagehttps://github.com/feast-dev/feast/pull/2808/changes
feature_store.py https://github.com/feast-dev/feast/pull/2808/changes#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
file.py https://github.com/feast-dev/feast/pull/2808/changes#diff-88364623e2505581c76f2dcc9afd28eb7090c086631a38f40433715d4db75d63
offline_store.py https://github.com/feast-dev/feast/pull/2808/changes#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
passthrough_provider.py https://github.com/feast-dev/feast/pull/2808/changes#diff-d9f79a3598724f611628ace828bfb01721e6ffe34cc8f16e313ed9fdd48e8ab2
provider.py https://github.com/feast-dev/feast/pull/2808/changes#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
test_offline_write.py https://github.com/feast-dev/feast/pull/2808/changes#diff-9499dcc21d9c5f7140b90098a2983d6f8ac9bb8b8eb59c9cdb82acca20f553ba
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_store.pyhttps://github.com/feast-dev/feast/pull/2808/changes#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
View file https://github.com/kevjumba/feast/blob/13fa653836da74c717f7d7e17a507cfbd7f73f7d/sdk/python/feast/feature_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2808/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2808/changes#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
achalshttps://github.com/achals
Jun 17, 2022https://github.com/feast-dev/feast/pull/2808/changes#r900448389
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2808/changes
kevjumbahttps://github.com/kevjumba
Jun 17, 2022https://github.com/feast-dev/feast/pull/2808/changes#r900452597
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2808/changes
https://github.com/feast-dev/feast/pull/2808/changes#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/2808/changes#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/file.pyhttps://github.com/feast-dev/feast/pull/2808/changes#diff-88364623e2505581c76f2dcc9afd28eb7090c086631a38f40433715d4db75d63
View file https://github.com/kevjumba/feast/blob/13fa653836da74c717f7d7e17a507cfbd7f73f7d/sdk/python/feast/infra/offline_stores/file.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2808/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2808/changes#diff-88364623e2505581c76f2dcc9afd28eb7090c086631a38f40433715d4db75d63
https://github.com/feast-dev/feast/pull/2808/changes#diff-88364623e2505581c76f2dcc9afd28eb7090c086631a38f40433715d4db75d63
https://github.com/feast-dev/feast/pull/2808/changes#diff-88364623e2505581c76f2dcc9afd28eb7090c086631a38f40433715d4db75d63
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L23
sdk/python/feast/infra/offline_stores/offline_store.pyhttps://github.com/feast-dev/feast/pull/2808/changes#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
View file https://github.com/kevjumba/feast/blob/13fa653836da74c717f7d7e17a507cfbd7f73f7d/sdk/python/feast/infra/offline_stores/offline_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2808/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2808/changes#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
https://github.com/feast-dev/feast/pull/2808/changes#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
https://github.com/feast-dev/feast/pull/2808/changes#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/passthrough_provider.pyhttps://github.com/feast-dev/feast/pull/2808/changes#diff-d9f79a3598724f611628ace828bfb01721e6ffe34cc8f16e313ed9fdd48e8ab2
View file https://github.com/kevjumba/feast/blob/13fa653836da74c717f7d7e17a507cfbd7f73f7d/sdk/python/feast/infra/passthrough_provider.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2808/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2808/changes#diff-d9f79a3598724f611628ace828bfb01721e6ffe34cc8f16e313ed9fdd48e8ab2
https://github.com/feast-dev/feast/pull/2808/changes#diff-d9f79a3598724f611628ace828bfb01721e6ffe34cc8f16e313ed9fdd48e8ab2
https://github.com/feast-dev/feast/pull/2808/changes#diff-d9f79a3598724f611628ace828bfb01721e6ffe34cc8f16e313ed9fdd48e8ab2
https://github.com/feast-dev/feast/pull/2808/changes#diff-d9f79a3598724f611628ace828bfb01721e6ffe34cc8f16e313ed9fdd48e8ab2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/provider.pyhttps://github.com/feast-dev/feast/pull/2808/changes#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
View file https://github.com/kevjumba/feast/blob/13fa653836da74c717f7d7e17a507cfbd7f73f7d/sdk/python/feast/infra/provider.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2808/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2808/changes#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
achalshttps://github.com/achals
Jun 17, 2022https://github.com/feast-dev/feast/pull/2808/changes#r900316139
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2808/changes
kevjumbahttps://github.com/kevjumba
Jun 17, 2022https://github.com/feast-dev/feast/pull/2808/changes#r900329394
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2808/changes
https://github.com/feast-dev/feast/pull/2808/changes#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/integration/offline_store/test_offline_write.pyhttps://github.com/feast-dev/feast/pull/2808/changes#diff-9499dcc21d9c5f7140b90098a2983d6f8ac9bb8b8eb59c9cdb82acca20f553ba
View file https://github.com/kevjumba/feast/blob/13fa653836da74c717f7d7e17a507cfbd7f73f7d/sdk/python/tests/integration/offline_store/test_offline_write.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2808/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.