René's URL Explorer Experiment


Title: fix: Dynamodb drops missing entities when batching by aapope · Pull Request #2802 · feast-dev/feast · GitHub

Open Graph Title: fix: Dynamodb drops missing entities when batching by aapope · Pull Request #2802 · feast-dev/feast

X Title: fix: Dynamodb drops missing entities when batching by aapope · Pull Request #2802 · feast-dev/feast

Description: Signed-off-by: Andrew Pope apope@nursefly.com What this PR does / why we need it: This PR fixes an issue with getting online features from DynamoDB. If an entity at the end of request batch 2+ is missing from the DynamoDB table, it will get dropped in the response, which results in the following error: Traceback (most recent call last): File "src/tmp.py", line 26, in feature_df = store.get_online_features( File "/Users/apope/nursefly-analytics/predict/talent_pool/venv/lib/python3.8/site-packages/feast/usage.py", line 280, in wrapper raise exc.with_traceback(traceback) File "/Users/apope/nursefly-analytics/predict/talent_pool/venv/lib/python3.8/site-packages/feast/usage.py", line 269, in wrapper return func(*args, **kwargs) File "/Users/apope/nursefly-analytics/predict/talent_pool/venv/lib/python3.8/site-packages/feast/feature_store.py", line 1322, in get_online_features return self._get_online_features( File "/Users/apope/nursefly-analytics/predict/talent_pool/venv/lib/python3.8/site-packages/feast/feature_store.py", line 1521, in _get_online_features self._populate_response_from_feature_data( File "/Users/apope/nursefly-analytics/predict/talent_pool/venv/lib/python3.8/site-packages/feast/feature_store.py", line 1817, in _populate_response_from_feature_data GetOnlineFeaturesResponse.FeatureVector( TypeError: Parameter to MergeFrom() must be instance of same class: expected feast.types.Value got NoneType. Which issue(s) this PR fixes: Fixes #

Open Graph Description: Signed-off-by: Andrew Pope apope@nursefly.com What this PR does / why we need it: This PR fixes an issue with getting online features from DynamoDB. If an entity at the end of request batch 2+ is ...

X Description: Signed-off-by: Andrew Pope apope@nursefly.com What this PR does / why we need it: This PR fixes an issue with getting online features from DynamoDB. If an entity at the end of request batch 2+ is ...

Opengraph URL: https://github.com/feast-dev/feast/pull/2802

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c5456e04-8e43-df91-71fb-f143990e6717
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCA6:35A2B4:1B0CE5E:26535AC:6978EC58
html-safe-nonce6719e377d3749557a8547ded2ae4be5f103bbd3f7cefaa4673ae2bb72d0b46c8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0E2OjM1QTJCNDoxQjBDRTVFOjI2NTM1QUM6Njk3OEVDNTgiLCJ2aXNpdG9yX2lkIjoiMzA4NTU4MjEwNDM5MDA2OTMzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdfce0f1400774783b3f7043bf751c7bf9bfbd52b559bc2aebb00bcdc90efd442
hovercard-subject-tagpull_request:969730482
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/2802/files
twitter:imagehttps://avatars.githubusercontent.com/u/658359?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/658359?s=400&v=4
og:image:altSigned-off-by: Andrew Pope apope@nursefly.com What this PR does / why we need it: This PR fixes an issue with getting online features from DynamoDB. If an entity at the end of request batch 2+ is ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None8a71ca1f7ab5436216e1df86f398ef7a51ed3152c90e3f7332fc70cf97fcb9d6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release024f9f4ca72571329d73933440b8ceb5414e77a5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/2802/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2802%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2802%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/2802/changes
Reloadhttps://github.com/feast-dev/feast/pull/2802/changes
Reloadhttps://github.com/feast-dev/feast/pull/2802/changes
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 181 https://github.com/feast-dev/feast/issues
Pull requests 67 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
adchiahttps://github.com/adchia
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
aapope:dynamodb-batching-fixhttps://github.com/aapope/feast/tree/dynamodb-batching-fix
Conversation 6 https://github.com/feast-dev/feast/pull/2802
Commits 2 https://github.com/feast-dev/feast/pull/2802/commits
Checks 0 https://github.com/feast-dev/feast/pull/2802/checks
Files changed https://github.com/feast-dev/feast/pull/2802/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2802/changes
fix: Dynamodb drops missing entities when batching https://github.com/feast-dev/feast/pull/2802/changes#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/2802/files
93ec924 fixes dynamodb batch dropping missing entities Jun 16, 2022 https://github.com/feast-dev/feast/pull/2802/commits/93ec9247e66f2700e5bc129502f8eff6fe51da85
4ca9714 add unit tests Jun 16, 2022 https://github.com/feast-dev/feast/pull/2802/commits/4ca97141c014fcd6e53bf62dbc68ffd32c2859e6
Clear filters https://github.com/feast-dev/feast/pull/2802/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2802/changes
Please reload this pagehttps://github.com/feast-dev/feast/pull/2802/changes
dynamodb.py https://github.com/feast-dev/feast/pull/2802/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
test_dynamodb_online_store.py https://github.com/feast-dev/feast/pull/2802/changes#diff-47a1e36609372d7f10ad3cb7c2052999e3940d2f50d6f26b2df5473528cd93cd
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/dynamodb.pyhttps://github.com/feast-dev/feast/pull/2802/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
View file https://github.com/aapope/feast/blob/4ca97141c014fcd6e53bf62dbc68ffd32c2859e6/sdk/python/feast/infra/online_stores/dynamodb.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2802/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2802/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
https://github.com/feast-dev/feast/pull/2802/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
https://github.com/feast-dev/feast/pull/2802/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/online_store/test_dynamodb_online_store.pyhttps://github.com/feast-dev/feast/pull/2802/changes#diff-47a1e36609372d7f10ad3cb7c2052999e3940d2f50d6f26b2df5473528cd93cd
View file https://github.com/aapope/feast/blob/4ca97141c014fcd6e53bf62dbc68ffd32c2859e6/sdk/python/tests/unit/infra/online_store/test_dynamodb_online_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2802/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2802/changes#diff-47a1e36609372d7f10ad3cb7c2052999e3940d2f50d6f26b2df5473528cd93cd
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.