René's URL Explorer Experiment


Title: chore: Deprecate value type by felixwang9817 · Pull Request #2673 · feast-dev/feast · GitHub

Open Graph Title: chore: Deprecate value type by felixwang9817 · Pull Request #2673 · feast-dev/feast

X Title: chore: Deprecate value type by felixwang9817 · Pull Request #2673 · feast-dev/feast

Description: What this PR does / why we need it: #2611 was reverted due to a bug. Specifically, FeatureView.__eq__ was missing a comparison of the entity_columns attribute. In Registry.apply_feature_view, we do...

Open Graph Description: What this PR does / why we need it: #2611 was reverted due to a bug. Specifically, FeatureView.__eq__ was missing a comparison of the entity_columns attribute. In Registry.apply_feature_view, we do...

X Description: What this PR does / why we need it: #2611 was reverted due to a bug. Specifically, FeatureView.__eq__ was missing a comparison of the entity_columns attribute. In Registry.apply_feature_view, we do...

Opengraph URL: https://github.com/feast-dev/feast/pull/2673

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:658647ac-98e6-0f03-59a1-ee10e40bb7a8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA71E:F186A:FDBB22:1503F17:697D10F6
html-safe-nonce48b1acb17d4f38cf7f62ea6cb0c03b670026c71850861dc962245dc21565597d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzFFOkYxODZBOkZEQkIyMjoxNTAzRjE3OjY5N0QxMEY2IiwidmlzaXRvcl9pZCI6IjQ5NTIyMDA1MDY0MTY4OTQxOTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccea5662d1e8f3c1c66e84d66da17254da89e5fd20629e5fc7978a835e0a8a218
hovercard-subject-tagpull_request:934203721
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/2673/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1404dbab7a17bbc477223779a8ac1970a01372b3d79a6a99021e1d26b98eaa4d/feast-dev/feast/pull/2673
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1404dbab7a17bbc477223779a8ac1970a01372b3d79a6a99021e1d26b98eaa4d/feast-dev/feast/pull/2673
og:image:altWhat this PR does / why we need it: #2611 was reverted due to a bug. Specifically, FeatureView.__eq__ was missing a comparison of the entity_columns attribute. In Registry.apply_feature_view, we do...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefelixwang9817
hostnamegithub.com
expected-hostnamegithub.com
Nonef4270289760ed79c539b4df0bf901fb752ee16d6a98c6589b1c6b6d5d4e1a000
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7add7da55b3463f73608a5dd149b156c4e76f2b8
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/2673#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2673
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2673
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/2673
Reloadhttps://github.com/feast-dev/feast/pull/2673
Reloadhttps://github.com/feast-dev/feast/pull/2673
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 182 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/2673#issue-comment-box
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
felixwang9817:deprecate_value_typehttps://github.com/felixwang9817/feast/tree/deprecate_value_type
chore: Deprecate value type https://github.com/feast-dev/feast/pull/2673#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
felixwang9817:deprecate_value_typehttps://github.com/felixwang9817/feast/tree/deprecate_value_type
Conversation 14 https://github.com/feast-dev/feast/pull/2673
Commits 29 https://github.com/feast-dev/feast/pull/2673/commits
Checks 0 https://github.com/feast-dev/feast/pull/2673/checks
Files changed https://github.com/feast-dev/feast/pull/2673/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
May 11, 2022https://github.com/feast-dev/feast/pull/2673#issue-1233248463
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
#2611https://github.com/feast-dev/feast/pull/2611
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
size/XXL https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL
May 11, 2022https://github.com/feast-dev/feast/pull/2673#event-6594018294
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
May 11, 2022https://github.com/feast-dev/feast/pull/2673#event-6594023326
https://github.com/adchia
adchiahttps://github.com/adchia
May 11, 2022https://github.com/feast-dev/feast/pull/2673#issuecomment-1124358233
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
May 11, 2022https://github.com/feast-dev/feast/pull/2673#issuecomment-1124359426
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
Codecovhttps://codecov.io/gh/feast-dev/feast/pull/2673?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
#2673https://codecov.io/gh/feast-dev/feast/pull/2673?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
8eaa65chttps://github.com/feast-dev/feast/commit/8eaa65c66b374dc286b86f2eef3da9b116a206c9
masterhttps://codecov.io/gh/feast-dev/feast/commit/c5539fd9874fed3f69b0aaebc4d1d32e624bd041?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
c5539fdhttps://github.com/feast-dev/feast/commit/c5539fd9874fed3f69b0aaebc4d1d32e624bd041
Click herehttps://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment
Impacted Fileshttps://codecov.io/gh/feast-dev/feast/pull/2673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
sdk/python/feast/infra/provider.pyhttps://codecov.io/gh/feast-dev/feast/pull/2673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZyYS9wcm92aWRlci5weQ==
sdk/python/feast/on_demand_feature_view.pyhttps://codecov.io/gh/feast-dev/feast/pull/2673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9vbl9kZW1hbmRfZmVhdHVyZV92aWV3LnB5
sdk/python/tests/unit/test_feature_view.pyhttps://codecov.io/gh/feast-dev/feast/pull/2673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy91bml0L3Rlc3RfZmVhdHVyZV92aWV3LnB5
sdk/python/feast/entity.pyhttps://codecov.io/gh/feast-dev/feast/pull/2673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9lbnRpdHkucHk=
sdk/python/feast/inference.pyhttps://codecov.io/gh/feast-dev/feast/pull/2673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZlcmVuY2UucHk=
sdk/python/feast/feature_logging.pyhttps://codecov.io/gh/feast-dev/feast/pull/2673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9mZWF0dXJlX2xvZ2dpbmcucHk=
sdk/python/feast/feature_store.pyhttps://codecov.io/gh/feast-dev/feast/pull/2673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9mZWF0dXJlX3N0b3JlLnB5
sdk/python/feast/feature_view.pyhttps://codecov.io/gh/feast-dev/feast/pull/2673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9mZWF0dXJlX3ZpZXcucHk=
sdk/python/feast/infra/offline_stores/file.pyhttps://codecov.io/gh/feast-dev/feast/pull/2673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZyYS9vZmZsaW5lX3N0b3Jlcy9maWxlLnB5
...python/feast/infra/offline_stores/offline_utils.pyhttps://codecov.io/gh/feast-dev/feast/pull/2673/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZyYS9vZmZsaW5lX3N0b3Jlcy9vZmZsaW5lX3V0aWxzLnB5
27 morehttps://codecov.io/gh/feast-dev/feast/pull/2673/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Continue to review full report at Codecovhttps://codecov.io/gh/feast-dev/feast/pull/2673?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecovhttps://codecov.io/gh/feast-dev/feast/pull/2673?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
c5539fd...8eaa65chttps://codecov.io/gh/feast-dev/feast/pull/2673?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
force-pushedhttps://github.com/feast-dev/feast/compare/e648d296e5343fdff387f73712aaedcc66f7d320..9b5ae96846a19df5ec5f4339378ae4be9822fb52
e648d29https://github.com/feast-dev/feast/commit/e648d296e5343fdff387f73712aaedcc66f7d320
9b5ae96https://github.com/feast-dev/feast/commit/9b5ae96846a19df5ec5f4339378ae4be9822fb52
Compare https://github.com/feast-dev/feast/compare/e648d296e5343fdff387f73712aaedcc66f7d320..9b5ae96846a19df5ec5f4339378ae4be9822fb52
May 12, 2022 00:09https://github.com/feast-dev/feast/pull/2673#event-6594290440
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
do-not-merge/work-in-progress https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress
May 12, 2022https://github.com/feast-dev/feast/pull/2673#event-6594291621
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
May 12, 2022https://github.com/feast-dev/feast/pull/2673#event-6594291970
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
do-not-merge/work-in-progress https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress
May 12, 2022https://github.com/feast-dev/feast/pull/2673#event-6594292031
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
May 12, 2022https://github.com/feast-dev/feast/pull/2673#event-6594292732
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
force-pushedhttps://github.com/feast-dev/feast/compare/13ff48059775c9bbc83325d43acdd98fb40fc60b..aa48f4ba379697c65a7cf34184d24a3a1c727bec
13ff480https://github.com/feast-dev/feast/commit/13ff48059775c9bbc83325d43acdd98fb40fc60b
aa48f4bhttps://github.com/feast-dev/feast/commit/aa48f4ba379697c65a7cf34184d24a3a1c727bec
Compare https://github.com/feast-dev/feast/compare/13ff48059775c9bbc83325d43acdd98fb40fc60b..aa48f4ba379697c65a7cf34184d24a3a1c727bec
May 13, 2022 00:46https://github.com/feast-dev/feast/pull/2673#event-6602177814
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
May 13, 2022https://github.com/feast-dev/feast/pull/2673#event-6602386212
https://github.com/adchia
adchiahttps://github.com/adchia
May 13, 2022 https://github.com/feast-dev/feast/pull/2673#pullrequestreview-972312891
View reviewed changes https://github.com/feast-dev/feast/pull/2673/files
sdk/python/feast/feature_view.pyhttps://github.com/feast-dev/feast/pull/2673/files#diff-2ad1fe8c07795c37cab906c0b8a0a5a2721afa54265f4664b31f451cc6cfcbb6
adchiahttps://github.com/adchia
May 13, 2022https://github.com/feast-dev/feast/pull/2673#discussion_r872437308
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
https://github.com/pyalex
pyalexhttps://github.com/pyalex
May 16, 2022 https://github.com/feast-dev/feast/pull/2673#pullrequestreview-974320707
View reviewed changes https://github.com/feast-dev/feast/pull/2673/files
https://github.com/pyalex
pyalexhttps://github.com/pyalex
May 16, 2022https://github.com/feast-dev/feast/pull/2673#issuecomment-1127968555
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
pyalexhttps://github.com/pyalex
May 16, 2022https://github.com/feast-dev/feast/pull/2673#event-6618259775
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
May 16, 2022https://github.com/feast-dev/feast/pull/2673#event-6618259842
https://github.com/achals
achalshttps://github.com/achals
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
May 16, 2022https://github.com/feast-dev/feast/pull/2673#event-6618812571
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
May 16, 2022https://github.com/feast-dev/feast/pull/2673#event-6619660109
felixwang9817https://github.com/felixwang9817
May 17, 2022 15:59https://github.com/feast-dev/feast/pull/2673#commits-pushed-39733b2
https://github.com/felixwang9817
Switch entities from List[str] to List[Entity]https://github.com/feast-dev/feast/pull/2673/commits/39733b2648e7331a52b713e4f8f78303a8041252
39733b2https://github.com/feast-dev/feast/pull/2673/commits/39733b2648e7331a52b713e4f8f78303a8041252
https://github.com/felixwang9817
Remove value_type from SDKhttps://github.com/feast-dev/feast/pull/2673/commits/a6a675b7c58da45c1de432720a5ed2057885742d
a6a675bhttps://github.com/feast-dev/feast/pull/2673/commits/a6a675b7c58da45c1de432720a5ed2057885742d
https://github.com/felixwang9817
Remove value_type from testshttps://github.com/feast-dev/feast/pull/2673/commits/10523c77e2a6384599803bb25699d64c90407bf6
10523c7https://github.com/feast-dev/feast/pull/2673/commits/10523c77e2a6384599803bb25699d64c90407bf6
https://github.com/felixwang9817
Deprecate value_type parameter for Entityhttps://github.com/feast-dev/feast/pull/2673/commits/705e9528fd161ca522876b0cdad536ef0568c36b
705e952https://github.com/feast-dev/feast/pull/2673/commits/705e9528fd161ca522876b0cdad536ef0568c36b
https://github.com/felixwang9817
Add fields for entities to avoid type inference after removing `value…https://github.com/feast-dev/feast/pull/2673/commits/afbb5dd52bd3ff3a0b1b4a131d587049e3717008
afbb5ddhttps://github.com/feast-dev/feast/pull/2673/commits/afbb5dd52bd3ff3a0b1b4a131d587049e3717008
https://github.com/felixwang9817
Fix Gohttps://github.com/feast-dev/feast/pull/2673/commits/c66976c0389af6a36250e8d3910f0b5a830dfb04
c66976chttps://github.com/feast-dev/feast/pull/2673/commits/c66976c0389af6a36250e8d3910f0b5a830dfb04
https://github.com/felixwang9817
Fix type inferencehttps://github.com/feast-dev/feast/pull/2673/commits/00bb4d8af535949ff30c6cdb4a6f9f2e6c0e5050
00bb4d8https://github.com/feast-dev/feast/pull/2673/commits/00bb4d8af535949ff30c6cdb4a6f9f2e6c0e5050
https://github.com/felixwang9817
Another fixhttps://github.com/feast-dev/feast/pull/2673/commits/bc88d5cd0d2fb9681125f785b6e33096bfba9632
bc88d5chttps://github.com/feast-dev/feast/pull/2673/commits/bc88d5cd0d2fb9681125f785b6e33096bfba9632
felixwang9817https://github.com/felixwang9817
May 17, 2022 15:59https://github.com/feast-dev/feast/pull/2673#commits-pushed-3dfa9d6
https://github.com/felixwang9817
Rename Entities to EntityNames in gohttps://github.com/feast-dev/feast/pull/2673/commits/3dfa9d69099393859fb5697dd7bc172d7f291e72
3dfa9d6https://github.com/feast-dev/feast/pull/2673/commits/3dfa9d69099393859fb5697dd7bc172d7f291e72
https://github.com/felixwang9817
Rename lookuphttps://github.com/feast-dev/feast/pull/2673/commits/49b01b47a5a29f9640609197a0fcd15d24e5c351
49b01b4https://github.com/feast-dev/feast/pull/2673/commits/49b01b47a5a29f9640609197a0fcd15d24e5c351
https://github.com/felixwang9817
Rename Feature to Fieldhttps://github.com/feast-dev/feast/pull/2673/commits/ac31bb7b1450abbd379dc828a853ea752b26e4c0
ac31bb7https://github.com/feast-dev/feast/pull/2673/commits/ac31bb7b1450abbd379dc828a853ea752b26e4c0
https://github.com/felixwang9817
Clean up inferencehttps://github.com/feast-dev/feast/pull/2673/commits/a2158e7e8b63fa41d7c68607c136c7c46a93c93e
a2158e7https://github.com/feast-dev/feast/pull/2673/commits/a2158e7e8b63fa41d7c68607c136c7c46a93c93e
https://github.com/felixwang9817
Refactorhttps://github.com/feast-dev/feast/pull/2673/commits/aad0805d711a97364e92d746e04aab4750669a51
aad0805https://github.com/feast-dev/feast/pull/2673/commits/aad0805d711a97364e92d746e04aab4750669a51
https://github.com/felixwang9817
Use old value_type attribute if it still existshttps://github.com/feast-dev/feast/pull/2673/commits/21d7e55c70a99b50e19f7dbc2b24d4370730a229
21d7e55https://github.com/feast-dev/feast/pull/2673/commits/21d7e55c70a99b50e19f7dbc2b24d4370730a229
https://github.com/felixwang9817
Refactorhttps://github.com/feast-dev/feast/pull/2673/commits/dc750e8123fec73e0822d25d90eff7556ac75619
dc750e8https://github.com/feast-dev/feast/pull/2673/commits/dc750e8123fec73e0822d25d90eff7556ac75619
https://github.com/felixwang9817
Add TODOhttps://github.com/feast-dev/feast/pull/2673/commits/6432029281f7330c4230b52433b5ed7c63d71696
6432029https://github.com/feast-dev/feast/pull/2673/commits/6432029281f7330c4230b52433b5ed7c63d71696
https://github.com/felixwang9817
Another fixhttps://github.com/feast-dev/feast/pull/2673/commits/98087899c25479d2b05d81675d9eccb71f99ee77
9808789https://github.com/feast-dev/feast/pull/2673/commits/98087899c25479d2b05d81675d9eccb71f99ee77
https://github.com/felixwang9817
Fix testhttps://github.com/feast-dev/feast/pull/2673/commits/6c92dc2fc4199f7a15534ba05add609e126565a9
6c92dc2https://github.com/feast-dev/feast/pull/2673/commits/6c92dc2fc4199f7a15534ba05add609e126565a9
https://github.com/felixwang9817
Add pytest.ini file to suppress pytest warnings about markershttps://github.com/feast-dev/feast/pull/2673/commits/2be1e40877ee6db4dc60177f5b41a70ed12fd988
2be1e40https://github.com/feast-dev/feast/pull/2673/commits/2be1e40877ee6db4dc60177f5b41a70ed12fd988
https://github.com/felixwang9817
Fix type testhttps://github.com/feast-dev/feast/pull/2673/commits/9b341b71e0ccfee3c343b25fb769cf17bf412d92
9b341b7https://github.com/feast-dev/feast/pull/2673/commits/9b341b71e0ccfee3c343b25fb769cf17bf412d92
https://github.com/felixwang9817
Fix type testhttps://github.com/feast-dev/feast/pull/2673/commits/2ed0384df202a8e679ab59174dc12800879d9bd2
2ed0384https://github.com/feast-dev/feast/pull/2673/commits/2ed0384df202a8e679ab59174dc12800879d9bd2
https://github.com/felixwang9817
Modify entity and feature inference to occur separately and add testshttps://github.com/feast-dev/feast/pull/2673/commits/7c5b80dd0744000dde47e6316b5052b608acac01
7c5b80dhttps://github.com/feast-dev/feast/pull/2673/commits/7c5b80dd0744000dde47e6316b5052b608acac01
https://github.com/felixwang9817
Linthttps://github.com/feast-dev/feast/pull/2673/commits/0f129d3eb53a7af496ed3d333813b0d2270a38eb
0f129d3https://github.com/feast-dev/feast/pull/2673/commits/0f129d3eb53a7af496ed3d333813b0d2270a38eb
https://github.com/felixwang9817
Refactor inference to pass linthttps://github.com/feast-dev/feast/pull/2673/commits/18fbb0d2c30012cd0b4dbbf0f9b477e0287f3b37
18fbb0dhttps://github.com/feast-dev/feast/pull/2673/commits/18fbb0d2c30012cd0b4dbbf0f9b477e0287f3b37
https://github.com/felixwang9817
Fix Javahttps://github.com/feast-dev/feast/pull/2673/commits/7a32b01d1a199e2eb3b713c97fea821de4c3f883
7a32b01https://github.com/feast-dev/feast/pull/2673/commits/7a32b01d1a199e2eb3b713c97fea821de4c3f883
https://github.com/felixwang9817
Another fixhttps://github.com/feast-dev/feast/pull/2673/commits/6c4e9d63221140f15d59ded40b9ddc9a08e0af9b
6c4e9d6https://github.com/feast-dev/feast/pull/2673/commits/6c4e9d63221140f15d59ded40b9ddc9a08e0af9b
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
force-pushedhttps://github.com/feast-dev/feast/compare/0eff01b55ab0dcc9af325910cd82a33998e38e34..6c4e9d63221140f15d59ded40b9ddc9a08e0af9b
0eff01bhttps://github.com/feast-dev/feast/commit/0eff01b55ab0dcc9af325910cd82a33998e38e34
6c4e9d6https://github.com/feast-dev/feast/commit/6c4e9d63221140f15d59ded40b9ddc9a08e0af9b
Compare https://github.com/feast-dev/feast/compare/0eff01b55ab0dcc9af325910cd82a33998e38e34..6c4e9d63221140f15d59ded40b9ddc9a08e0af9b
May 17, 2022 23:00https://github.com/feast-dev/feast/pull/2673#event-6628104348
https://github.com/pyalex
pyalexhttps://github.com/pyalex
May 17, 2022https://github.com/feast-dev/feast/pull/2673#issuecomment-1129407948
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
May 17, 2022https://github.com/feast-dev/feast/pull/2673#event-6628150217
https://github.com/felixwang9817
Fix ODFV repohttps://github.com/feast-dev/feast/pull/2673/commits/d23ee23f58026087b184c386b2ffe3a7dbf381a0
d23ee23https://github.com/feast-dev/feast/pull/2673/commits/d23ee23f58026087b184c386b2ffe3a7dbf381a0
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
May 17, 2022https://github.com/feast-dev/feast/pull/2673#event-6628278432
https://github.com/achals
achalshttps://github.com/achals
May 18, 2022 https://github.com/feast-dev/feast/pull/2673#pullrequestreview-977689102
View reviewed changes https://github.com/feast-dev/feast/pull/2673/files/d23ee23f58026087b184c386b2ffe3a7dbf381a0
achalshttps://github.com/achals
https://github.com/feast-dev/feast/pull/2673#pullrequestreview-977689102
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
sdk/python/feast/entity.pyhttps://github.com/feast-dev/feast/pull/2673/files/d23ee23f58026087b184c386b2ffe3a7dbf381a0#diff-c0f89d7c348e7d395df4f432d417bea219403127ac9e94e0c126bcf707bf39bb
achalshttps://github.com/achals
May 18, 2022https://github.com/feast-dev/feast/pull/2673#discussion_r876410440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
felixwang9817https://github.com/felixwang9817
May 18, 2022https://github.com/feast-dev/feast/pull/2673#discussion_r876418294
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
sdk/python/feast/feature_view.pyhttps://github.com/feast-dev/feast/pull/2673/files/d23ee23f58026087b184c386b2ffe3a7dbf381a0#diff-2ad1fe8c07795c37cab906c0b8a0a5a2721afa54265f4664b31f451cc6cfcbb6
achalshttps://github.com/achals
May 18, 2022https://github.com/feast-dev/feast/pull/2673#discussion_r876411660
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
felixwang9817https://github.com/felixwang9817
May 18, 2022https://github.com/feast-dev/feast/pull/2673#discussion_r876418323
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
sdk/python/feast/feature_view.pyhttps://github.com/feast-dev/feast/pull/2673/files/d23ee23f58026087b184c386b2ffe3a7dbf381a0#diff-2ad1fe8c07795c37cab906c0b8a0a5a2721afa54265f4664b31f451cc6cfcbb6
achalshttps://github.com/achals
May 18, 2022https://github.com/feast-dev/feast/pull/2673#discussion_r876411664
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
https://github.com/felixwang9817
Switch deprecation version from 0.22 to 0.23https://github.com/feast-dev/feast/pull/2673/commits/8eaa65c66b374dc286b86f2eef3da9b116a206c9
8eaa65chttps://github.com/feast-dev/feast/pull/2673/commits/8eaa65c66b374dc286b86f2eef3da9b116a206c9
https://github.com/achals
achalshttps://github.com/achals
May 18, 2022 https://github.com/feast-dev/feast/pull/2673#pullrequestreview-977689103
View reviewed changes https://github.com/feast-dev/feast/pull/2673/files/8eaa65c66b374dc286b86f2eef3da9b116a206c9
achalshttps://github.com/achals
https://github.com/feast-dev/feast/pull/2673#pullrequestreview-977689103
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
sdk/python/feast/entity.pyhttps://github.com/feast-dev/feast/pull/2673/files/d23ee23f58026087b184c386b2ffe3a7dbf381a0#diff-c0f89d7c348e7d395df4f432d417bea219403127ac9e94e0c126bcf707bf39bb
achalshttps://github.com/achals
May 18, 2022https://github.com/feast-dev/feast/pull/2673#discussion_r876410441
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
achalshttps://github.com/achals
May 18, 2022https://github.com/feast-dev/feast/pull/2673#event-6636156131
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
May 18, 2022https://github.com/feast-dev/feast/pull/2673#event-6636156224
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
May 18, 2022https://github.com/feast-dev/feast/pull/2673#issuecomment-1130600275
achalshttps://github.com/feast-dev/feast/pull/2673#pullrequestreview-977689103
felixwang9817https://github.com/feast-dev/feast/pull/2673
pyalexhttps://github.com/feast-dev/feast/pull/2673#pullrequestreview-974320707
herehttps://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/feast-dev/feast/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
9566299https://github.com/feast-dev/feast/commit/9566299484926622247557ad43ad328898af16ad
May 18, 2022https://github.com/feast-dev/feast/pull/2673#event-6636305807
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2673
https://github.com/adchia
adchia https://github.com/adchia
https://github.com/feast-dev/feast/pull/2673/files/0eff01b55ab0dcc9af325910cd82a33998e38e34
https://github.com/pyalex
pyalex https://github.com/pyalex
https://github.com/feast-dev/feast/pull/2673/files/0eff01b55ab0dcc9af325910cd82a33998e38e34
https://github.com/achals
achals https://github.com/achals
https://github.com/feast-dev/feast/pull/2673/files/8eaa65c66b374dc286b86f2eef3da9b116a206c9
https://github.com/pyalex
pyalex https://github.com/pyalex
https://github.com/achals
achals https://github.com/achals
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
size/XXL https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL
Please reload this pagehttps://github.com/feast-dev/feast/pull/2673
https://github.com/felixwang9817
https://github.com/adchia
https://github.com/codecov-commenter
https://github.com/pyalex
https://github.com/feast-ci-bot
https://github.com/achals
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.