Title: fix: Reject undefined features when using `get_historical_features` or `get_online_features` by chhabrakadabra · Pull Request #2665 · feast-dev/feast · GitHub
Open Graph Title: fix: Reject undefined features when using `get_historical_features` or `get_online_features` by chhabrakadabra · Pull Request #2665 · feast-dev/feast
X Title: fix: Reject undefined features when using `get_historical_features` or `get_online_features` by chhabrakadabra · Pull Request #2665 · feast-dev/feast
Description: Signed-off-by: Abhin Chhabra abhin.chhabra@shopify.com What this PR does / why we need it: Increase the scope of validations provided by _group_feature_refs to also check if the features are part of the feature view. It also adds a get_feature method to the FeatureViewProjection class that could be useful in other cases too. In the event of an invalid feature being requested, a KeyError is raised, which is consistent with the existing behaviour when completely non-existent features are requested in get_historical_features. Which issue(s) this PR fixes: Fixes #2576
Open Graph Description: Signed-off-by: Abhin Chhabra abhin.chhabra@shopify.com What this PR does / why we need it: Increase the scope of validations provided by _group_feature_refs to also check if the features are part ...
X Description: Signed-off-by: Abhin Chhabra abhin.chhabra@shopify.com What this PR does / why we need it: Increase the scope of validations provided by _group_feature_refs to also check if the features are part ...
Opengraph URL: https://github.com/feast-dev/feast/pull/2665
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bb9871ff-9195-cad5-946d-8980d6688a15 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B766:3BE04B:6D9FBB0:958F78C:69786ED0 |
| html-safe-nonce | 553c7903bcfe3813c5536a0ab47ce71bca5a301cb1c49cd5459ad7dd60ea9c4d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzY2OjNCRTA0Qjo2RDlGQkIwOjk1OEY3OEM6Njk3ODZFRDAiLCJ2aXNpdG9yX2lkIjoiMjMxNjQ5NDc3ODk4NTM3NzQ4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e31f83c6b5e66f1a497032bef6a53dfbb8c4b71e787eed1525590c9043df524c |
| hovercard-subject-tag | pull_request:933687461 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/2665/files |
| twitter:image | https://avatars.githubusercontent.com/u/773452?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/773452?s=400&v=4 |
| og:image:alt | Signed-off-by: Abhin Chhabra abhin.chhabra@shopify.com What this PR does / why we need it: Increase the scope of validations provided by _group_feature_refs to also check if the features are part ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 520b65a872113b919c1bbdb03834a50af15859fd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width