| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f88a9634-5524-ac11-f94d-73bb3328345e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D5F0:126966:C4E40:107850:697BDD59 |
| html-safe-nonce | 5febd442f9a6a28ceb7eed0f846cd1639a955a31082be74fd5f48dc9f3b8341f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUYwOjEyNjk2NjpDNEU0MDoxMDc4NTA6Njk3QkRENTkiLCJ2aXNpdG9yX2lkIjoiNTk4MDU5NDg4NDU4OTY0MTA0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 96edce2097d76d083eb5fbcb903d1a29fe9c23efaad36f3671ebf8714a886303 |
| hovercard-subject-tag | pull_request:919962312 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/2614/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/03eed63bc7666396a7980a34c119300d14f6a871111b1e159e8df1692ee1e013/feast-dev/feast/pull/2614 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/03eed63bc7666396a7980a34c119300d14f6a871111b1e159e8df1692ee1e013/feast-dev/feast/pull/2614 |
| og:image:alt | Signed-off-by: pyalex moskalenko.alexey@gmail.com
What this PR does / why we need it:
This is mostly refactoring PR. This refactoring is needed before integrating Python API for feature logging in... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pyalex |
| hostname | github.com |
| expected-hostname | github.com |
| None | 90c903d424d2820430e2681fde6506e2fde6c951096a52676303d6013be58916 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 450bbb9bf815634a4d5a0257514b0fb15fa5b213 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/2614#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2614 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2614 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/2614 |
| Reload | https://github.com/feast-dev/feast/pull/2614 |
| Reload | https://github.com/feast-dev/feast/pull/2614 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
182
| https://github.com/feast-dev/feast/issues |
|
Pull requests
66
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/2614#issue-comment-box |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| pyalex:decouple-go-logging | https://github.com/pyalex/feast/tree/decouple-go-logging |
|
chore: Reorganize feature logging in Go for better extensibility
| https://github.com/feast-dev/feast/pull/2614#top |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| pyalex:decouple-go-logging | https://github.com/pyalex/feast/tree/decouple-go-logging |
|
Conversation
29
| https://github.com/feast-dev/feast/pull/2614 |
|
Commits
2
| https://github.com/feast-dev/feast/pull/2614/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/2614/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/2614/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Apr 26, 2022 | https://github.com/feast-dev/feast/pull/2614#issue-1216573189 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
size/XXL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL |
| Apr 26, 2022 | https://github.com/feast-dev/feast/pull/2614#event-6502500467 |
| https://github.com/codecov-commenter |
| codecov-commenter | https://github.com/codecov-commenter |
| Apr 26, 2022 | https://github.com/feast-dev/feast/pull/2614#issuecomment-1110332715 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| Codecov | https://codecov.io/gh/feast-dev/feast/pull/2614?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| #2614 | https://codecov.io/gh/feast-dev/feast/pull/2614?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| dd563fb | https://github.com/feast-dev/feast/commit/dd563fb79f7f124086f2ac307a1de11a9b514fa5 |
| master | https://codecov.io/gh/feast-dev/feast/commit/f3ff812a15d46287ed12918396167b6ad295cdc9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| f3ff812 | https://github.com/feast-dev/feast/commit/f3ff812a15d46287ed12918396167b6ad295cdc9 |
| Click here | https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment |
| Impacted Files | https://codecov.io/gh/feast-dev/feast/pull/2614?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| sdk/python/feast/feature_logging.py | https://codecov.io/gh/feast-dev/feast/pull/2614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9mZWF0dXJlX2xvZ2dpbmcucHk= |
| sdk/python/tests/utils/online_read_write_test.py | https://codecov.io/gh/feast-dev/feast/pull/2614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy91dGlscy9vbmxpbmVfcmVhZF93cml0ZV90ZXN0LnB5 |
| .../integration/online_store/test_online_retrieval.py | https://codecov.io/gh/feast-dev/feast/pull/2614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9vbmxpbmVfc3RvcmUvdGVzdF9vbmxpbmVfcmV0cmlldmFsLnB5 |
| Continue to review full report at Codecov | https://codecov.io/gh/feast-dev/feast/pull/2614?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Codecov | https://codecov.io/gh/feast-dev/feast/pull/2614?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| f3ff812...dd563fb | https://codecov.io/gh/feast-dev/feast/pull/2614?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| comment docs | https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
| Apr 26, 2022 | https://github.com/feast-dev/feast/pull/2614#event-6502634447 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| kevjumba | https://github.com/kevjumba |
| April 26, 2022 23:44 | https://github.com/feast-dev/feast/pull/2614#event-6502634513 |
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
|
Apr 26, 2022
| https://github.com/feast-dev/feast/pull/2614#pullrequestreview-954155326 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/2614/files |
| .gitignore | https://github.com/feast-dev/feast/pull/2614/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
|
Apr 26, 2022
| https://github.com/feast-dev/feast/pull/2614#pullrequestreview-954157393 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/2614/files |
| go/cmd/server/server_test.go | https://github.com/feast-dev/feast/pull/2614/files#diff-b7969ee175ee099af1db3c809307affebcb029169c4d183bf4acc891f8a6b537 |
| kevjumba | https://github.com/kevjumba |
| Apr 26, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r859237794 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 26, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r859238681 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| force-pushed | https://github.com/feast-dev/feast/compare/4ec8ccd2d82e0eebfc0b5122964d1940caf1b45d..f15b62239e08d5de4c4dff65b00b20958f0f3597 |
| 4ec8ccd | https://github.com/feast-dev/feast/commit/4ec8ccd2d82e0eebfc0b5122964d1940caf1b45d |
| f15b622 | https://github.com/feast-dev/feast/commit/f15b62239e08d5de4c4dff65b00b20958f0f3597 |
|
Compare
| https://github.com/feast-dev/feast/compare/4ec8ccd2d82e0eebfc0b5122964d1940caf1b45d..f15b62239e08d5de4c4dff65b00b20958f0f3597 |
| April 27, 2022 00:04 | https://github.com/feast-dev/feast/pull/2614#event-6502689372 |
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
|
Apr 27, 2022
| https://github.com/feast-dev/feast/pull/2614#pullrequestreview-954158264 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/2614/files |
| go/internal/feast/logging/featureserviceschema.go | https://github.com/feast-dev/feast/pull/2614/files#diff-e81bce8f06cea8aac080e4285befa147cb38c46f452b049180e19b9896faf853 |
| kevjumba | https://github.com/kevjumba |
| Apr 26, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r859239301 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860083496 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| go/internal/feast/logging/filelogsink.go | https://github.com/feast-dev/feast/pull/2614/files#diff-458b6d10998d8e6572a5b503dc068dbcb1d22529510ca3d1c0327bd038de66a3 |
| kevjumba | https://github.com/kevjumba |
| Apr 26, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r859240339 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860083738 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| go/internal/feast/logging/filelogsink.go | https://github.com/feast-dev/feast/pull/2614/files#diff-458b6d10998d8e6572a5b503dc068dbcb1d22529510ca3d1c0327bd038de66a3 |
| kevjumba | https://github.com/kevjumba |
| Apr 26, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r859240506 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860083793 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| go/internal/feast/logging/logger_test.go | https://github.com/feast-dev/feast/pull/2614/files#diff-1eb4e4b23ae01ed3f8e954d08b51bd3d8c169d09f6ae5b5e9c5aaa8fab76c876 |
| kevjumba | https://github.com/kevjumba |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r859255441 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860083877 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| go/internal/test/go_integration_test_utils.go | https://github.com/feast-dev/feast/pull/2614/files#diff-4e6be887740877929813894bbd6cc670cc5ee5ea2592843a5408164c95dce6cc |
| kevjumba | https://github.com/kevjumba |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r859261910 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860086052 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| go/internal/feast/logging/filelogsink.go | https://github.com/feast-dev/feast/pull/2614/files#diff-458b6d10998d8e6572a5b503dc068dbcb1d22529510ca3d1c0327bd038de66a3 |
| kevjumba | https://github.com/kevjumba |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r859418285 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860086389 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| go/internal/feast/logging/logger.go | https://github.com/feast-dev/feast/pull/2614/files#diff-e76c64dfedd9ce14b576a434cf6c27e86dd6f0774d4e2fe618064188fb99efdc |
| kevjumba | https://github.com/kevjumba |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r859419869 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860087201 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| go/internal/feast/logging/logger.go | https://github.com/feast-dev/feast/pull/2614/files#diff-e76c64dfedd9ce14b576a434cf6c27e86dd6f0774d4e2fe618064188fb99efdc |
| kevjumba | https://github.com/kevjumba |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r859420348 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860086863 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| https://github.com/achals |
| achals | https://github.com/achals |
|
Apr 27, 2022
| https://github.com/feast-dev/feast/pull/2614#pullrequestreview-955209685 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/2614/files |
| go/internal/feast/logging/service.go | https://github.com/feast-dev/feast/pull/2614/files#diff-e9023950c9ad978524f64524562433c38df8a918b099246a8fb9a3cf965d9c0a |
| achals | https://github.com/achals |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860012647 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860101088 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| go/internal/feast/model/featureservice.go | https://github.com/feast-dev/feast/pull/2614/files#diff-2f52080634a1802ca81d43a655373594bea1f9b12491d9be7502da0239ff1bb4 |
| achals | https://github.com/achals |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860013422 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860100984 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| sdk/python/feast/feature_logging.py | https://github.com/feast-dev/feast/pull/2614/files#diff-27d35444a1392d38a1ec7deb0fbba0b80adc7901632e6aa5eb4851a5443b0d89 |
| achals | https://github.com/achals |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860016999 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| pyalex | https://github.com/pyalex |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#discussion_r860095867 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| go/internal/feast/logging/featureserviceschema.go | https://github.com/feast-dev/feast/pull/2614/files#diff-e81bce8f06cea8aac080e4285befa147cb38c46f452b049180e19b9896faf853 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
|
Apr 27, 2022
| https://github.com/feast-dev/feast/pull/2614#pullrequestreview-955333748 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/2614/files |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#issuecomment-1111316781 |
| kevjumba | https://github.com/feast-dev/feast/pull/2614#pullrequestreview-955333748 |
| pyalex | https://github.com/feast-dev/feast/pull/2614 |
| here | https://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process |
| OWNERS | https://github.com/feast-dev/feast/blob/master/OWNERS |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#event-6509139655 |
|
| https://github.com/pyalex |
| decouple logging service | https://github.com/feast-dev/feast/pull/2614/commits/c7446f526c9eeaf34cba13a9deab9d1aabd225aa |
| c7446f5 | https://github.com/feast-dev/feast/pull/2614/commits/c7446f526c9eeaf34cba13a9deab9d1aabd225aa |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| force-pushed | https://github.com/feast-dev/feast/compare/6f52c8fb6592b20289dea5322259ffd764e60c04..c7446f526c9eeaf34cba13a9deab9d1aabd225aa |
| 6f52c8f | https://github.com/feast-dev/feast/commit/6f52c8fb6592b20289dea5322259ffd764e60c04 |
| c7446f5 | https://github.com/feast-dev/feast/commit/c7446f526c9eeaf34cba13a9deab9d1aabd225aa |
|
Compare
| https://github.com/feast-dev/feast/compare/6f52c8fb6592b20289dea5322259ffd764e60c04..c7446f526c9eeaf34cba13a9deab9d1aabd225aa |
| April 27, 2022 18:34 | https://github.com/feast-dev/feast/pull/2614#event-6509336677 |
|
| https://github.com/pyalex |
| fix repo path in tests | https://github.com/feast-dev/feast/pull/2614/commits/dd563fb79f7f124086f2ac307a1de11a9b514fa5 |
| dd563fb | https://github.com/feast-dev/feast/pull/2614/commits/dd563fb79f7f124086f2ac307a1de11a9b514fa5 |
| https://github.com/kevjumba |
| kevjumba | https://github.com/kevjumba |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#issuecomment-1111409019 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| kevjumba | https://github.com/kevjumba |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#event-6509717509 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#event-6509717559 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| 5200fde | https://github.com/feast-dev/feast/commit/5200fde81914bf4bb458c2b6a23b47b5d9c6fb32 |
| Apr 27, 2022 | https://github.com/feast-dev/feast/pull/2614#event-6509722208 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
May 2, 2022
| https://github.com/feast-dev/feast/pull/2614#ref-pullrequest-1217959601 |
|
feat: Write logged features to Offline Store (Go - Python integration)
#2621
| https://github.com/feast-dev/feast/pull/2621 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2614 |
|
| https://github.com/achals |
|
achals
| https://github.com/achals |
|
| https://github.com/feast-dev/feast/pull/2614/files/f15b62239e08d5de4c4dff65b00b20958f0f3597 |
|
| https://github.com/kevjumba |
|
kevjumba
| https://github.com/kevjumba |
|
| https://github.com/feast-dev/feast/pull/2614/files/6f52c8fb6592b20289dea5322259ffd764e60c04 |
|
| https://github.com/kevjumba |
|
kevjumba
| https://github.com/kevjumba |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
|
size/XXL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL |
| Please reload this page | https://github.com/feast-dev/feast/pull/2614 |
|
| https://github.com/pyalex |
|
| https://github.com/codecov-commenter |
|
| https://github.com/feast-ci-bot |
|
| https://github.com/kevjumba |
|
| https://github.com/achals |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |