| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2d1fecdc-68c0-3541-d697-37fcf2d4d045 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D7F8:369B67:227E861:2E93D11:6979A421 |
| html-safe-nonce | 6e9aef458fd4759db4f7f13733411307a11b6f05d01962fe0ac04c9b4ff6e968 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0Y4OjM2OUI2NzoyMjdFODYxOjJFOTNEMTE6Njk3OUE0MjEiLCJ2aXNpdG9yX2lkIjoiMjU3ODM1MTAzMjI4Mjc1MjAzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3d42ac08b5e49d29b42973b3865cb72b9994ad2ab244348fc738bf93c57b68ca |
| hovercard-subject-tag | pull_request:889904573 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/2455/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fed6f6487f31a0aa71f3999624183538bbece55a94d32ff2d09b2bd5ff83ded3/feast-dev/feast/pull/2455 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fed6f6487f31a0aa71f3999624183538bbece55a94d32ff2d09b2bd5ff83ded3/feast-dev/feast/pull/2455 |
| og:image:alt | Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: #2440 mistakenly changed the order of the FeatureView parameters, which could potentially break users who are de... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | felixwang9817 |
| hostname | github.com |
| expected-hostname | github.com |
| None | c049b65ec7e54cbf2521f5a560b6527714c612b0bd169188e2ea6e16f83bd5f4 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87b137883e35e2766c3d0f6a257c4044f6390b83 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/2455#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2455 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2455 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/2455 |
| Reload | https://github.com/feast-dev/feast/pull/2455 |
| Reload | https://github.com/feast-dev/feast/pull/2455 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
181
| https://github.com/feast-dev/feast/issues |
|
Pull requests
69
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/2455#issue-comment-box |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| felixwang9817:fix_fv_tags | https://github.com/felixwang9817/feast/tree/fix_fv_tags |
|
chore: Reorder feature view parameters
| https://github.com/feast-dev/feast/pull/2455#top |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| felixwang9817:fix_fv_tags | https://github.com/felixwang9817/feast/tree/fix_fv_tags |
|
Conversation
3
| https://github.com/feast-dev/feast/pull/2455 |
|
Commits
1
| https://github.com/feast-dev/feast/pull/2455/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/2455/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/2455/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/2455 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/felixwang9817 |
| felixwang9817 | https://github.com/felixwang9817 |
| Mar 25, 2022 | https://github.com/feast-dev/feast/pull/2455#issue-1181267273 |
| #2440 | https://github.com/feast-dev/feast/pull/2440 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2455 |
|
| https://github.com/felixwang9817 |
| Reorder parameters | https://github.com/feast-dev/feast/pull/2455/commits/d4e937e317dcd894947a5b4bef2fa23aa417a1dc |
| d4e937e | https://github.com/feast-dev/feast/pull/2455/commits/d4e937e317dcd894947a5b4bef2fa23aa417a1dc |
| https://github.com/felixwang9817 |
| felixwang9817 | https://github.com/felixwang9817 |
| code owner | https://github.com/feast-dev/feast/blob/f202f928ff02f4a263f3b4ce450051e526304c51/.github/CODEOWNERS#L4 |
| March 25, 2022 21:04 | https://github.com/feast-dev/feast/pull/2455#event-6310034382 |
| https://github.com/felixwang9817 |
| felixwang9817 | https://github.com/felixwang9817 |
| woop | https://github.com/woop |
| March 25, 2022 21:04 | https://github.com/feast-dev/feast/pull/2455#event-6310034394 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
size/XS
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXS |
| Mar 25, 2022 | https://github.com/feast-dev/feast/pull/2455#event-6310034580 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| woop | https://github.com/woop |
| Mar 25, 2022 | https://github.com/feast-dev/feast/pull/2455#event-6310035860 |
| https://github.com/achals |
| achals | https://github.com/achals |
|
Mar 25, 2022
| https://github.com/feast-dev/feast/pull/2455#pullrequestreview-922139486 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/2455/files/d4e937e317dcd894947a5b4bef2fa23aa417a1dc |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Mar 25, 2022 | https://github.com/feast-dev/feast/pull/2455#issuecomment-1079433232 |
| achals | https://github.com/feast-dev/feast/pull/2455#pullrequestreview-922139486 |
| felixwang9817 | https://github.com/feast-dev/feast/pull/2455 |
| here | https://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process |
| OWNERS | https://github.com/feast-dev/feast/blob/master/OWNERS |
| Please reload this page | https://github.com/feast-dev/feast/pull/2455 |
| https://github.com/achals |
| achals | https://github.com/achals |
| Mar 25, 2022 | https://github.com/feast-dev/feast/pull/2455#issuecomment-1079433285 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2455 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| achals | https://github.com/achals |
| Mar 25, 2022 | https://github.com/feast-dev/feast/pull/2455#event-6310039076 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Mar 25, 2022 | https://github.com/feast-dev/feast/pull/2455#event-6310039131 |
| https://github.com/codecov-commenter |
| codecov-commenter | https://github.com/codecov-commenter |
| Mar 25, 2022 | https://github.com/feast-dev/feast/pull/2455#issuecomment-1079435014 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2455 |
| Codecov | https://codecov.io/gh/feast-dev/feast/pull/2455?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| #2455 | https://codecov.io/gh/feast-dev/feast/pull/2455?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| d4e937e | https://github.com/feast-dev/feast/commit/d4e937e317dcd894947a5b4bef2fa23aa417a1dc |
| master | https://codecov.io/gh/feast-dev/feast/commit/4cbf97bea044f49671865e9936d43b4c37e5eaa0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| 4cbf97b | https://github.com/feast-dev/feast/commit/4cbf97bea044f49671865e9936d43b4c37e5eaa0 |
| Click here | https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment |
| Impacted Files | https://codecov.io/gh/feast-dev/feast/pull/2455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| sdk/python/feast/feature_view.py | https://codecov.io/gh/feast-dev/feast/pull/2455/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9mZWF0dXJlX3ZpZXcucHk= |
| ...ython/feast/embedded_go/online_features_service.py | https://codecov.io/gh/feast-dev/feast/pull/2455/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9lbWJlZGRlZF9nby9vbmxpbmVfZmVhdHVyZXNfc2VydmljZS5weQ== |
| Continue to review full report at Codecov | https://codecov.io/gh/feast-dev/feast/pull/2455?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Codecov | https://codecov.io/gh/feast-dev/feast/pull/2455?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| 4cbf97b...d4e937e | https://codecov.io/gh/feast-dev/feast/pull/2455?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| comment docs | https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Please reload this page | https://github.com/feast-dev/feast/pull/2455 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| ca7d616 | https://github.com/feast-dev/feast/commit/ca7d6160bb32594bd5ae3b8d5e26b860b9e0c638 |
| Mar 25, 2022 | https://github.com/feast-dev/feast/pull/2455#event-6310118585 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2455 |
|
| https://github.com/achals |
|
achals
| https://github.com/achals |
|
| https://github.com/feast-dev/feast/pull/2455/files/d4e937e317dcd894947a5b4bef2fa23aa417a1dc |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
| https://github.com/achals |
|
achals
| https://github.com/achals |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
size/XS
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXS |
| Please reload this page | https://github.com/feast-dev/feast/pull/2455 |
|
| https://github.com/felixwang9817 |
|
| https://github.com/feast-ci-bot |
|
| https://github.com/achals |
|
| https://github.com/codecov-commenter |
|
| https://github.com/woop |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |