| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:da48b15c-deae-ebb7-31df-8b81299aa961 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BBE0:35A2B4:389359C:4F4472C:69793874 |
| html-safe-nonce | 0c1094daddc1879b14dbe078807eda7d8736e561ab7c1574a4640d9730c7974c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkUwOjM1QTJCNDozODkzNTlDOjRGNDQ3MkM6Njk3OTM4NzQiLCJ2aXNpdG9yX2lkIjoiODc3ODU1MjY1MTE2NDY5MzY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 57368fffc4ea284f9f96a8a24d7e32d2e3a188ddd8b15824a773d1affa37015c |
| hovercard-subject-tag | pull_request:872372638 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/2371/files |
| twitter:image | https://avatars.githubusercontent.com/u/49818188?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/49818188?s=400&v=4 |
| og:image:alt | What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2247
Context
Given a list of entity_ids set a batch_size parameter to determine the number of items to send in a batch_get_... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 33d60f7e5c009874ca1d3bae4ff07a11d7994e6b4b54cf6e64121c500cc10bc5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2391a1af9753b168299d1cbf80f8bb67be4430bd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/2371/changes#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2371%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2371%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/2371/changes |
| Reload | https://github.com/feast-dev/feast/pull/2371/changes |
| Reload | https://github.com/feast-dev/feast/pull/2371/changes |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
181
| https://github.com/feast-dev/feast/issues |
|
Pull requests
68
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| TremaMiguel:feat/dynamo_db_online_write_read | https://github.com/TremaMiguel/feast/tree/feat/dynamo_db_online_write_read |
|
Conversation
43
| https://github.com/feast-dev/feast/pull/2371 |
|
Commits
25
| https://github.com/feast-dev/feast/pull/2371/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/2371/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/2371/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/2371/changes |
|
feat: Add support for DynamoDB online_read in batches
| https://github.com/feast-dev/feast/pull/2371/changes#top |
|
Show all changes
25 commits
| https://github.com/feast-dev/feast/pull/2371/files |
|
c34bf3e
feat: dynamodb onlin read in batches
TremaMiguel Mar 6, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/c34bf3e4f1affc1220af73dfdd0d26eeda9c9b55 |
|
56d2d32
run linters and format
TremaMiguel Mar 6, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/56d2d322a61ab7824473287e6426fd9b8f8c996d |
|
7b98faf
feat: batch_size parameter
TremaMiguel Mar 6, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/7b98faf56a8dd64cb047b2a9c7b635e54cdd7bfa |
|
94abfb6
Merge branch 'feast-dev:master' into feat/dynamo_db_online_write_read
TremaMiguel Mar 6, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/94abfb6b1cdbd7026e3069c7e019132cbaad7a65 |
|
b5c1a3d
docs: typo in batch_size description
TremaMiguel Mar 6, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/b5c1a3deaabb26d2cff830e7d815a5236849a068 |
|
5a12856
trailing white space
TremaMiguel Mar 6, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/5a12856d1fadcc48ce0004f65799c0dd55a777d9 |
|
8bd2a84
fix: batch_size is last argument
TremaMiguel Mar 7, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/8bd2a84c54713a3e000314de718b210f3bfbdc4d |
|
fb6eacb
test: dynamodb online store online_read in batches
TremaMiguel Mar 7, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/fb6eacb3a5718f92dfd4c466ad313a6dfed812b7 |
|
1bbd5dc
Merge branch 'master' into feat/dynamo_db_online_write_read
adchia Mar 7, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/1bbd5dca39cbd69d3ffe35ed55b18dcf4432e910 |
|
307bab9
test: mock dynamodb behavior
TremaMiguel Mar 7, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/307bab90bc16b41f731c05f630767e26f5cf1b5a |
|
e52a895
feat: batch_size value must be less than 40
TremaMiguel Mar 8, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/e52a895e043846b59c94093bd5b7455095cd1b64 |
|
29b5cf6
Merge branch 'master' into feat/dynamo_db_online_write_read
adchia Mar 9, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/29b5cf64a0353acd2eec4bcefe33b62bbdbb9dc5 |
|
97fd71f
feat: batch_size defaults to 40
TremaMiguel Mar 10, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/97fd71f6ab2950e342c96b3552147f32d92dc8c0 |
|
ddb3f0a
Merge branch 'feat/dynamo_db_online_write_read' of github.com:TremaMi…
TremaMiguel Mar 10, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/ddb3f0add070e5919f183e2fe2631befb551acc8 |
|
12064e4
feat: sort dynamodb responses
TremaMiguel Mar 11, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/12064e4a4cb665b21dbdfbad9091d6417897fb8e |
|
449f60d
merge branch master into feat/dynamo_db_online_write_read
TremaMiguel Mar 12, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/449f60d6e921c44ee60831a91801cbfd113cfe85 |
|
3f72228
resolve merge conflicts
TremaMiguel Mar 12, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/3f72228b0cd3075c586ba8fea2e492cdd9a372c8 |
|
7a4edbd
test online response proto with redshift:dynamodb
TremaMiguel Mar 12, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/7a4edbd2604e893a9973e9299906d8ff2ea7796e |
|
3843a02
feat: consistency in batch_size process
TremaMiguel Mar 15, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/3843a02f02275a5fc9b31e15e25b25c129d3e5ce |
|
88e183e
fix: return batch_size times None
TremaMiguel Mar 16, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/88e183e6d695805ce21161de87e2b240f0d5f862 |
|
23cb49a
remove debug code
TremaMiguel Mar 16, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/23cb49a7bf428e018e337ac03023b18dfeece113 |
|
44f97e7
Merge branch 'feast-dev:master' into feat/dynamo_db_online_write_read
TremaMiguel Mar 22, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/44f97e719b32035b6cddb6cab9baa99c68f2d4fa |
|
eaf4940
typo in docstring
TremaMiguel Mar 22, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/eaf4940d0d088529c6ebf79ea6356848f1a8d187 |
|
5bc54d3
batch_size in onlineconfigstore
TremaMiguel Mar 23, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/5bc54d3a24f0294dd5edce7b903cde0473af21f4 |
|
c7ab086
Merge branch 'master' into feat/dynamo_db_online_write_read
TremaMiguel Mar 23, 2022
| https://github.com/feast-dev/feast/pull/2371/commits/c7ab086298180ff071dc984c0f0906a29f527c6d |
|
Clear filters
| https://github.com/feast-dev/feast/pull/2371/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/2371/changes |
| Please reload this page | https://github.com/feast-dev/feast/pull/2371/changes |
|
dynamodb.py
| https://github.com/feast-dev/feast/pull/2371/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47 |
|
test_dynamodb_online_store.py
| https://github.com/feast-dev/feast/pull/2371/changes#diff-d9f58e943c3194bc0d751c12be5eb01c9b6d9ab87d3f22b01a1249ef67a67adc |
|
online_store_utils.py
| https://github.com/feast-dev/feast/pull/2371/changes#diff-1278a9acd4653651d2dca380a01a9c8f176502260b2836bb0968a8cf82a02084 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/infra/online_stores/dynamodb.py | https://github.com/feast-dev/feast/pull/2371/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47 |
|
View file
| https://github.com/TremaMiguel/feast/blob/c7ab086298180ff071dc984c0f0906a29f527c6d/sdk/python/feast/infra/online_stores/dynamodb.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/2371/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/2371/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47 |
|
| https://github.com/feast-dev/feast/pull/2371/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47 |
|
| https://github.com/feast-dev/feast/pull/2371/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2371/changes |
|
| https://github.com/feast-dev/feast/pull/2371/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47 |
|
| https://github.com/feast-dev/feast/pull/2371/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2371/changes |
|
| https://github.com/feast-dev/feast/pull/2371/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47 |
|
| https://github.com/feast-dev/feast/pull/2371/changes#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/tests/unit/online_store/test_dynamodb_online_store.py | https://github.com/feast-dev/feast/pull/2371/changes#diff-d9f58e943c3194bc0d751c12be5eb01c9b6d9ab87d3f22b01a1249ef67a67adc |
|
View file
| https://github.com/TremaMiguel/feast/blob/c7ab086298180ff071dc984c0f0906a29f527c6d/sdk/python/tests/unit/online_store/test_dynamodb_online_store.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/2371/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/tests/utils/online_store_utils.py | https://github.com/feast-dev/feast/pull/2371/changes#diff-1278a9acd4653651d2dca380a01a9c8f176502260b2836bb0968a8cf82a02084 |
|
View file
| https://github.com/TremaMiguel/feast/blob/c7ab086298180ff071dc984c0f0906a29f527c6d/sdk/python/tests/utils/online_store_utils.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/2371/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |