| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4e8c2d66-fa9f-ce15-e2c0-1aba41c17a2d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB88:3C7AB6:132B71D:196567B:6AFEABEF |
| html-safe-nonce | 7e29aeb77705be9aa8c128156a85772d7da24188b94f4c27263a6ea0f06c6c97 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjg4OjNDN0FCNjoxMzJCNzFEOjE5NjU2N0I6NkFGRUFCRUYiLCJ2aXNpdG9yX2lkIjoiNDMxODMxMDY3Njk3NzA2OTAzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8612abd0fbfa18000128e8316277da91ef96db4da0634e827814efe87b25d345 |
| hovercard-subject-tag | pull_request:834927572 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/2256/files |
| twitter:image | https://avatars.githubusercontent.com/u/24739949?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/24739949?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: This PR cleans up feast plan. Specifically:
Fco is renamed to FeastObject.
Unchanged objects are no longer logged.
first feast apply:
then feast plan:
Va... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3f25273206cd841171bca0002261ae4c9757d934 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/2256/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2256%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2256%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/2256/files |
| Reload | https://github.com/feast-dev/feast/pull/2256/files |
| Reload | https://github.com/feast-dev/feast/pull/2256/files |
| feast-dev | https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
| Code | https://github.com/feast-dev/feast |
| Issues223 (223) | https://github.com/feast-dev/feast/issues |
| Pull requests143 (143) | https://github.com/feast-dev/feast/pulls |
| Discussions | https://github.com/feast-dev/feast/discussions |
| Actions | https://github.com/feast-dev/feast/actions |
| Security and quality1 (1) | https://github.com/feast-dev/feast/security |
| Insights | https://github.com/feast-dev/feast/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| felixwang9817:feast_plan | https://github.com/felixwang9817/feast/tree/feast_plan |
|
Conversation
4
| https://github.com/feast-dev/feast/pull/2256 |
|
Commits
8
| https://github.com/feast-dev/feast/pull/2256/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/2256/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/2256/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/2256/files |
|
Feast plan clean up
| https://github.com/feast-dev/feast/pull/2256/files#top |
|
Show all changes
8 commits
| https://github.com/feast-dev/feast/pull/2256/files |
|
817a8da
Run validation and inference on views and entities during plan
felixwang9817 Jan 29, 2022
| https://github.com/feast-dev/feast/pull/2256/commits/817a8da8766d6a94a56e0f545803b1c235ca2b60 |
|
22e3eec
Do not log objects that are unchanged
felixwang9817 Jan 29, 2022
| https://github.com/feast-dev/feast/pull/2256/commits/22e3eec7e100332c457d1049ea9ccc75473dfa07 |
|
6afdeba
Rename Fco to FeastObject
felixwang9817 Jan 29, 2022
| https://github.com/feast-dev/feast/pull/2256/commits/6afdebad6fdb9f8eb6c4cb73d79528b4f6dbef83 |
|
8f5d9ef
Remove useless method
felixwang9817 Jan 29, 2022
| https://github.com/feast-dev/feast/pull/2256/commits/8f5d9ef6b385c2e283de70e4f44fc05b50a9a235 |
|
4d5eb6b
Lint
felixwang9817 Jan 29, 2022
| https://github.com/feast-dev/feast/pull/2256/commits/4d5eb6bef2a245744346cd3cecdad52db9b4745f |
|
bc720f5
Always initialize registry during feature store initialization
felixwang9817 Jan 29, 2022
| https://github.com/feast-dev/feast/pull/2256/commits/bc720f5d5e6ee263e3e3cafaf6102aedb5fdb2b1 |
|
4e93615
Fix usage test
felixwang9817 Jan 29, 2022
| https://github.com/feast-dev/feast/pull/2256/commits/4e93615b2f781ca22186260cd0791e3f8b504ca8 |
|
335e8db
Remove print statements
felixwang9817 Jan 29, 2022
| https://github.com/feast-dev/feast/pull/2256/commits/335e8db507556fbae44edddf603070478fd47ecb |
|
Clear filters
| https://github.com/feast-dev/feast/pull/2256/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/2256/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/2256/files |
|
infra_diff.py
| https://github.com/feast-dev/feast/pull/2256/files#diff-09191b96544a360965cb26901dd7ac9715b2de6ea8e3ad90dd506211a23f986c |
|
registry_diff.py
| https://github.com/feast-dev/feast/pull/2256/files#diff-a694770645a4bdf4f1323de2128665ee744daa9fb8a1ea458ec081ca61c231a2 |
|
feature_store.py
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
|
inference.py
| https://github.com/feast-dev/feast/pull/2256/files#diff-5900bcbadd0bc85d04e02efc800a1ab128a723240ba4f04b26a884222044e1c8 |
|
repo_operations.py
| https://github.com/feast-dev/feast/pull/2256/files#diff-9922445cc092f7a2f8885c771cb4d15c4c21a84bcbc0513ba76009036ddbccf5 |
|
test_usage_e2e.py
| https://github.com/feast-dev/feast/pull/2256/files#diff-57c0655e379cb46a39fc8dffa937756a01a0863aa1bada8b6f3ca4e38496de33 |
|
test_registry_diff.py
| https://github.com/feast-dev/feast/pull/2256/files#diff-5afb586640a52e6dd89cc237d1b6e66e154b24110a4aa2529c987050b2ccb831 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/diff/infra_diff.py | https://github.com/feast-dev/feast/pull/2256/files#diff-09191b96544a360965cb26901dd7ac9715b2de6ea8e3ad90dd506211a23f986c |
|
View file
| https://github.com/felixwang9817/feast/blob/335e8db507556fbae44edddf603070478fd47ecb/sdk/python/feast/diff/infra_diff.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/2256/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-09191b96544a360965cb26901dd7ac9715b2de6ea8e3ad90dd506211a23f986c |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-09191b96544a360965cb26901dd7ac9715b2de6ea8e3ad90dd506211a23f986c |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/diff/FcoDiff.py → sdk/python/feast/diff/registry_diff.py | https://github.com/feast-dev/feast/pull/2256/files#diff-a694770645a4bdf4f1323de2128665ee744daa9fb8a1ea458ec081ca61c231a2 |
|
View file
| https://github.com/felixwang9817/feast/blob/335e8db507556fbae44edddf603070478fd47ecb/sdk/python/feast/diff/registry_diff.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/2256/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-a694770645a4bdf4f1323de2128665ee744daa9fb8a1ea458ec081ca61c231a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-a694770645a4bdf4f1323de2128665ee744daa9fb8a1ea458ec081ca61c231a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-a694770645a4bdf4f1323de2128665ee744daa9fb8a1ea458ec081ca61c231a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-a694770645a4bdf4f1323de2128665ee744daa9fb8a1ea458ec081ca61c231a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-a694770645a4bdf4f1323de2128665ee744daa9fb8a1ea458ec081ca61c231a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-a694770645a4bdf4f1323de2128665ee744daa9fb8a1ea458ec081ca61c231a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-a694770645a4bdf4f1323de2128665ee744daa9fb8a1ea458ec081ca61c231a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-a694770645a4bdf4f1323de2128665ee744daa9fb8a1ea458ec081ca61c231a2 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/feature_store.py | https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
|
View file
| https://github.com/felixwang9817/feast/blob/335e8db507556fbae44edddf603070478fd47ecb/sdk/python/feast/feature_store.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/2256/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
| adchia | https://github.com/adchia |
| Jan 30, 2022 | https://github.com/feast-dev/feast/pull/2256/files#r795214863 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/2256/files |
|
| https://github.com/feast-dev/feast/pull/2256/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2 |
| Please reload this page | https://github.com/feast-dev/feast/pull/2256/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |