René's URL Explorer Experiment


Title: Delete entity key from Redis only when all attached feature views are gone by pyalex · Pull Request #2240 · feast-dev/feast · GitHub

Open Graph Title: Delete entity key from Redis only when all attached feature views are gone by pyalex · Pull Request #2240 · feast-dev/feast

X Title: Delete entity key from Redis only when all attached feature views are gone by pyalex · Pull Request #2240 · feast-dev/feast

Description: What this PR does / why we need it: This PR adds the test for the use case described in #2150 as well as the fix for it. Which issue(s) this PR fixes: Fixes #2150 Does this PR introduce a user-facing change?: NONE

Open Graph Description: What this PR does / why we need it: This PR adds the test for the use case described in #2150 as well as the fix for it. Which issue(s) this PR fixes: Fixes #2150 Does this PR introduce a user-fac...

X Description: What this PR does / why we need it: This PR adds the test for the use case described in #2150 as well as the fix for it. Which issue(s) this PR fixes: Fixes #2150 Does this PR introduce a user-fac...

Opengraph URL: https://github.com/feast-dev/feast/pull/2240

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1cd5eb56-9058-f456-0db4-4b746b850a4a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE250:EFEB1:12D5C25:18E0E23:6AFEA863
html-safe-nonce79f76a515b4f6a854648def4090cab73cfec4c16869e21e71604f2b39930bf9f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjUwOkVGRUIxOjEyRDVDMjU6MThFMEUyMzo2QUZFQTg2MyIsInZpc2l0b3JfaWQiOiIxOTgwMzg0NzkwMzQzMjMxNTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca3937ff217a94db038d3f6857846f712ca21c8405ee5ca7bd35d7fcb50eeec7b
hovercard-subject-tagpull_request:832239593
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/2240/files
twitter:imagehttps://avatars.githubusercontent.com/u/1303659?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1303659?s=400&v=4
og:image:altWhat this PR does / why we need it: This PR adds the test for the use case described in #2150 as well as the fix for it. Which issue(s) this PR fixes: Fixes #2150 Does this PR introduce a user-fac...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/2240/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2240%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2240%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/2240/files
Reloadhttps://github.com/feast-dev/feast/pull/2240/files
Reloadhttps://github.com/feast-dev/feast/pull/2240/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
pyalex:redis-delete-by-entityhttps://github.com/pyalex/feast/tree/redis-delete-by-entity
Conversation 13 https://github.com/feast-dev/feast/pull/2240
Commits 5 https://github.com/feast-dev/feast/pull/2240/commits
Checks 0 https://github.com/feast-dev/feast/pull/2240/checks
Files changed https://github.com/feast-dev/feast/pull/2240/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240/files
Delete entity key from Redis only when all attached feature views are gone https://github.com/feast-dev/feast/pull/2240/files#top
Show all changes 5 commits https://github.com/feast-dev/feast/pull/2240/files
af0e9b6 Delete entity from redis when the last attached feature view is deleted pyalex Jan 25, 2022 https://github.com/feast-dev/feast/pull/2240/commits/af0e9b66595b16a7d9a898d4c3279ecc48acb519
e444b1e Delete entity key from Redis only when all attached feature views are… pyalex Jan 26, 2022 https://github.com/feast-dev/feast/pull/2240/commits/e444b1e8c4eb0dc9ef67e12a53ea0992fe397ef8
9124605 make lint happy pyalex Jan 26, 2022 https://github.com/feast-dev/feast/pull/2240/commits/912460565c1d31563fe04b4991478945911cac23
cb3f162 make lint happy pyalex Jan 26, 2022 https://github.com/feast-dev/feast/pull/2240/commits/cb3f1622e336070b4064b3620675939e552d827f
5145f5e one more try with mypy pyalex Jan 26, 2022 https://github.com/feast-dev/feast/pull/2240/commits/5145f5e95764c2153d43b73f01b5eaed677cd6d9
Clear filters https://github.com/feast-dev/feast/pull/2240/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240/files
redis.py https://github.com/feast-dev/feast/pull/2240/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
repo_configuration.py https://github.com/feast-dev/feast/pull/2240/files#diff-baba834b1fe50ff577674d4867e0d2439ce00912c8960314793110b368fee169
test_universal_online.py https://github.com/feast-dev/feast/pull/2240/files#diff-4f3e62ecf7f09cabe95c2e4536bab2ac159c0a64967dabe46517f423d6a49923
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/redis.pyhttps://github.com/feast-dev/feast/pull/2240/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
View file https://github.com/pyalex/feast/blob/5145f5e95764c2153d43b73f01b5eaed677cd6d9/sdk/python/feast/infra/online_stores/redis.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2240/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2240/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/2240/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/2240/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240/files
https://github.com/feast-dev/feast/pull/2240/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/2240/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/integration/feature_repos/repo_configuration.pyhttps://github.com/feast-dev/feast/pull/2240/files#diff-baba834b1fe50ff577674d4867e0d2439ce00912c8960314793110b368fee169
View file https://github.com/pyalex/feast/blob/5145f5e95764c2153d43b73f01b5eaed677cd6d9/sdk/python/tests/integration/feature_repos/repo_configuration.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2240/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2240/files#diff-baba834b1fe50ff577674d4867e0d2439ce00912c8960314793110b368fee169
https://github.com/feast-dev/feast/pull/2240/files#diff-baba834b1fe50ff577674d4867e0d2439ce00912c8960314793110b368fee169
https://github.com/feast-dev/feast/pull/2240/files#diff-baba834b1fe50ff577674d4867e0d2439ce00912c8960314793110b368fee169
https://github.com/feast-dev/feast/pull/2240/files#diff-baba834b1fe50ff577674d4867e0d2439ce00912c8960314793110b368fee169
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/integration/online_store/test_universal_online.pyhttps://github.com/feast-dev/feast/pull/2240/files#diff-4f3e62ecf7f09cabe95c2e4536bab2ac159c0a64967dabe46517f423d6a49923
View file https://github.com/pyalex/feast/blob/5145f5e95764c2153d43b73f01b5eaed677cd6d9/sdk/python/tests/integration/online_store/test_universal_online.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/2240/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/2240/files#diff-4f3e62ecf7f09cabe95c2e4536bab2ac159c0a64967dabe46517f423d6a49923
https://github.com/feast-dev/feast/pull/2240/files#diff-4f3e62ecf7f09cabe95c2e4536bab2ac159c0a64967dabe46517f423d6a49923
https://github.com/feast-dev/feast/pull/2240/files#diff-4f3e62ecf7f09cabe95c2e4536bab2ac159c0a64967dabe46517f423d6a49923
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240/files
https://github.com/feast-dev/feast/pull/2240/files#diff-4f3e62ecf7f09cabe95c2e4536bab2ac159c0a64967dabe46517f423d6a49923
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.