René's URL Explorer Experiment


Title: Delete entity key from Redis only when all attached feature views are gone by pyalex · Pull Request #2240 · feast-dev/feast · GitHub

Open Graph Title: Delete entity key from Redis only when all attached feature views are gone by pyalex · Pull Request #2240 · feast-dev/feast

X Title: Delete entity key from Redis only when all attached feature views are gone by pyalex · Pull Request #2240 · feast-dev/feast

Description: The Open Source Feature Store for AI/ML. Contribute to feast-dev/feast development by creating an account on GitHub.

Open Graph Description: What this PR does / why we need it: This PR adds the test for the use case described in #2150 as well as the fix for it. Which issue(s) this PR fixes: Fixes #2150 Does this PR introduce a user-fac...

X Description: What this PR does / why we need it: This PR adds the test for the use case described in #2150 as well as the fix for it. Which issue(s) this PR fixes: Fixes #2150 Does this PR introduce a user-fac...

Opengraph URL: https://github.com/feast-dev/feast/pull/2240

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:74d67f68-e5ac-b38b-2ae2-713bc40e0074
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC38C:A7C31:10CF3F5:1630D7D:6AFEA261
html-safe-nonced922c2331ffe5cdef6e23b7678a12068ddfe6e41c48acdb05bfe739a6301d4ca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzhDOkE3QzMxOjEwQ0YzRjU6MTYzMEQ3RDo2QUZFQTI2MSIsInZpc2l0b3JfaWQiOiI2NTgyNTA4MDg1NTYwOTEwNDMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac492f79f4877edd886d6c319e37f23ce528e9d441f60c0a503dd214b6d697ccf5
hovercard-subject-tagpull_request:832239593
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/2240/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2689a19376b95651abe468bd6a6ca3f7e8e9b526bb1139f033cc8f4874cd9b39/feast-dev/feast/pull/2240
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2689a19376b95651abe468bd6a6ca3f7e8e9b526bb1139f033cc8f4874cd9b39/feast-dev/feast/pull/2240
og:image:altWhat this PR does / why we need it: This PR adds the test for the use case described in #2150 as well as the fix for it. Which issue(s) this PR fixes: Fixes #2150 Does this PR introduce a user-fac...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepyalex
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-cache
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/2240#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2240
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2240
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/2240
Reloadhttps://github.com/feast-dev/feast/pull/2240
Reloadhttps://github.com/feast-dev/feast/pull/2240
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
pyalex:redis-delete-by-entityhttps://github.com/pyalex/feast/tree/redis-delete-by-entity
Conversationhttps://github.com/feast-dev/feast/pull/2240
Commits5 (5)https://github.com/feast-dev/feast/pull/2240/commits
Checkshttps://github.com/feast-dev/feast/pull/2240/checks
Files changedhttps://github.com/feast-dev/feast/pull/2240/files
Delete entity key from Redis only when all attached feature views are gonehttps://github.com/feast-dev/feast/pull/2240#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
pyalex:redis-delete-by-entityhttps://github.com/pyalex/feast/tree/redis-delete-by-entity
https://github.com/pyalex
pyalexhttps://github.com/pyalex
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#issue-1114805608
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
#2150https://github.com/feast-dev/feast/issues/2150
#2150https://github.com/feast-dev/feast/issues/2150
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/pyalex
pyalexhttps://github.com/pyalex
code ownerhttps://github.com/feast-dev/feast/blob/396f7294425169d69445d31863c5d34d6f71389f/.github/CODEOWNERS#L4
January 26, 2022 09:29https://github.com/feast-dev/feast/pull/2240#event-5955384741
https://github.com/pyalex
pyalexhttps://github.com/pyalex
adchiahttps://github.com/adchia
January 26, 2022 09:29https://github.com/feast-dev/feast/pull/2240#event-5955384757
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
do-not-merge/release-note-label-needed https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Frelease-note-label-needed
needs-kind https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#event-5955384875
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
achalshttps://github.com/achals
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#event-5955385861
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/M https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#event-5955385906
https://github.com/pyalex
pyalexhttps://github.com/pyalex
kind/bug https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fbug
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#event-5955388193
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
release-note-none https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Arelease-note-none
do-not-merge/release-note-label-needed https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Frelease-note-label-needed
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#event-5955389200
pyalexhttps://github.com/pyalex
January 26, 2022 16:31https://github.com/feast-dev/feast/pull/2240#commits-pushed-af0e9b6
https://github.com/pyalex
Delete entity from redis when the last attached feature view is deletedhttps://github.com/feast-dev/feast/pull/2240/commits/af0e9b66595b16a7d9a898d4c3279ecc48acb519
af0e9b6https://github.com/feast-dev/feast/pull/2240/commits/af0e9b66595b16a7d9a898d4c3279ecc48acb519
https://github.com/pyalex
Delete entity key from Redis only when all attached feature views are…https://github.com/feast-dev/feast/pull/2240/commits/e444b1e8c4eb0dc9ef67e12a53ea0992fe397ef8
e444b1ehttps://github.com/feast-dev/feast/pull/2240/commits/e444b1e8c4eb0dc9ef67e12a53ea0992fe397ef8
https://github.com/pyalex
make lint happyhttps://github.com/feast-dev/feast/pull/2240/commits/912460565c1d31563fe04b4991478945911cac23
9124605https://github.com/feast-dev/feast/pull/2240/commits/912460565c1d31563fe04b4991478945911cac23
https://github.com/pyalex
pyalexhttps://github.com/pyalex
force-pushedhttps://github.com/feast-dev/feast/compare/c59dd35ea81cd0465b6f16af0ddc181ab88539bc..912460565c1d31563fe04b4991478945911cac23
c59dd35https://github.com/feast-dev/feast/commit/c59dd35ea81cd0465b6f16af0ddc181ab88539bc
9124605https://github.com/feast-dev/feast/commit/912460565c1d31563fe04b4991478945911cac23
Compare https://github.com/feast-dev/feast/compare/c59dd35ea81cd0465b6f16af0ddc181ab88539bc..912460565c1d31563fe04b4991478945911cac23
January 26, 2022 09:36https://github.com/feast-dev/feast/pull/2240#event-5955427754
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
size/M https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#event-5955429053
https://github.com/pyalex
pyalexhttps://github.com/pyalex
judahrandhttps://github.com/judahrand
achalshttps://github.com/achals
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#event-5955433673
pyalexhttps://github.com/pyalex
January 26, 2022 16:48https://github.com/feast-dev/feast/pull/2240#commits-pushed-cb3f162
https://github.com/pyalex
make lint happyhttps://github.com/feast-dev/feast/pull/2240/commits/cb3f1622e336070b4064b3620675939e552d827f
cb3f162https://github.com/feast-dev/feast/pull/2240/commits/cb3f1622e336070b4064b3620675939e552d827f
https://github.com/pyalex
one more try with mypyhttps://github.com/feast-dev/feast/pull/2240/commits/5145f5e95764c2153d43b73f01b5eaed677cd6d9
5145f5ehttps://github.com/feast-dev/feast/pull/2240/commits/5145f5e95764c2153d43b73f01b5eaed677cd6d9
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#issuecomment-1022038297
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
Codecovhttps://codecov.io/gh/feast-dev/feast/pull/2240?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
#2240https://codecov.io/gh/feast-dev/feast/pull/2240?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
5145f5ehttps://github.com/feast-dev/feast/commit/5145f5e95764c2153d43b73f01b5eaed677cd6d9
masterhttps://codecov.io/gh/feast-dev/feast/commit/396f7294425169d69445d31863c5d34d6f71389f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
396f729https://github.com/feast-dev/feast/commit/396f7294425169d69445d31863c5d34d6f71389f
https://codecov.io/gh/feast-dev/feast/pull/2240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Click herehttps://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment
Impacted Fileshttps://codecov.io/gh/feast-dev/feast/pull/2240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
sdk/python/feast/infra/online_stores/redis.pyhttps://codecov.io/gh/feast-dev/feast/pull/2240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZyYS9vbmxpbmVfc3RvcmVzL3JlZGlzLnB5
.../integration/online_store/test_universal_online.pyhttps://codecov.io/gh/feast-dev/feast/pull/2240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9vbmxpbmVfc3RvcmUvdGVzdF91bml2ZXJzYWxfb25saW5lLnB5
...ts/integration/feature_repos/repo_configuration.pyhttps://codecov.io/gh/feast-dev/feast/pull/2240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9mZWF0dXJlX3JlcG9zL3JlcG9fY29uZmlndXJhdGlvbi5weQ==
.../integration/online_store/test_online_retrieval.pyhttps://codecov.io/gh/feast-dev/feast/pull/2240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9vbmxpbmVfc3RvcmUvdGVzdF9vbmxpbmVfcmV0cmlldmFsLnB5
...fline_store/test_universal_historical_retrieval.pyhttps://codecov.io/gh/feast-dev/feast/pull/2240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9vZmZsaW5lX3N0b3JlL3Rlc3RfdW5pdmVyc2FsX2hpc3RvcmljYWxfcmV0cmlldmFsLnB5
sdk/python/tests/utils/online_read_write_test.pyhttps://codecov.io/gh/feast-dev/feast/pull/2240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy91dGlscy9vbmxpbmVfcmVhZF93cml0ZV90ZXN0LnB5
...gration/registration/test_feature_service_apply.pyhttps://codecov.io/gh/feast-dev/feast/pull/2240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9yZWdpc3RyYXRpb24vdGVzdF9mZWF0dXJlX3NlcnZpY2VfYXBwbHkucHk=
sdk/python/tests/data/data_creator.pyhttps://codecov.io/gh/feast-dev/feast/pull/2240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9kYXRhL2RhdGFfY3JlYXRvci5weQ==
sdk/python/tests/integration/e2e/test_usage_e2e.pyhttps://codecov.io/gh/feast-dev/feast/pull/2240/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi90ZXN0cy9pbnRlZ3JhdGlvbi9lMmUvdGVzdF91c2FnZV9lMmUucHk=
53 morehttps://codecov.io/gh/feast-dev/feast/pull/2240/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Continue to review full report at Codecovhttps://codecov.io/gh/feast-dev/feast/pull/2240?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecovhttps://codecov.io/gh/feast-dev/feast/pull/2240?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
396f729...5145f5ehttps://codecov.io/gh/feast-dev/feast/pull/2240?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/pyalex
pyalexhttps://github.com/pyalex
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
needs-kind https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#event-5955533512
https://github.com/judahrand
judahrandhttps://github.com/judahrand
Jan 26, 2022 https://github.com/feast-dev/feast/pull/2240#pullrequestreview-863526766
View reviewed changes https://github.com/feast-dev/feast/pull/2240/files/5145f5e95764c2153d43b73f01b5eaed677cd6d9
judahrandhttps://github.com/judahrand
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/feast-dev/feast/pull/2240#pullrequestreview-863526766
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#2150https://github.com/feast-dev/feast/issues/2150
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/pyalex
pyalexhttps://github.com/pyalex
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#issuecomment-1022249317
@judahrandhttps://github.com/judahrand
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/judahrand
judahrandhttps://github.com/judahrand
Jan 26, 2022https://github.com/feast-dev/feast/pull/2240#issuecomment-1022310040
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
Jan 27, 2022 https://github.com/feast-dev/feast/pull/2240#pullrequestreview-864264504
View reviewed changes https://github.com/feast-dev/feast/pull/2240/files/5145f5e95764c2153d43b73f01b5eaed677cd6d9
sdk/python/tests/integration/online_store/test_universal_online.pyhttps://github.com/feast-dev/feast/pull/2240/files/5145f5e95764c2153d43b73f01b5eaed677cd6d9#diff-4f3e62ecf7f09cabe95c2e4536bab2ac159c0a64967dabe46517f423d6a49923
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
sdk/python/feast/infra/online_stores/redis.pyhttps://github.com/feast-dev/feast/pull/2240/files/5145f5e95764c2153d43b73f01b5eaed677cd6d9#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
Jan 27, 2022https://github.com/feast-dev/feast/pull/2240#event-5960368383
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
Jan 27, 2022https://github.com/feast-dev/feast/pull/2240#issuecomment-1022801713
@pyalexhttps://github.com/pyalex
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/pyalex
pyalexhttps://github.com/pyalex
Jan 27, 2022https://github.com/feast-dev/feast/pull/2240#issuecomment-1023099980
@felixwang9817https://github.com/felixwang9817
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/felixwang9817
felixwang9817https://github.com/felixwang9817
Jan 28, 2022 https://github.com/feast-dev/feast/pull/2240#pullrequestreview-865766904
View reviewed changes https://github.com/feast-dev/feast/pull/2240/files/5145f5e95764c2153d43b73f01b5eaed677cd6d9
felixwang9817https://github.com/felixwang9817
https://github.com/feast-dev/feast/pull/2240#pullrequestreview-865766904
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Jan 28, 2022https://github.com/feast-dev/feast/pull/2240#event-5968753837
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Jan 28, 2022https://github.com/feast-dev/feast/pull/2240#issuecomment-1023952909
felixwang9817https://github.com/feast-dev/feast/pull/2240#pullrequestreview-865766904
pyalexhttps://github.com/feast-dev/feast/pull/2240
herehttps://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/feast-dev/feast/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
Jan 28, 2022https://github.com/feast-dev/feast/pull/2240#event-5968754140
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
5fc0b52https://github.com/feast-dev/feast/commit/5fc0b52f4674df019be3452571f60f9876154b0c
Jan 28, 2022https://github.com/feast-dev/feast/pull/2240#event-5968757068
Awkward Deletion logic for Redis #2254 https://github.com/feast-dev/feast/issues/2254
Merge feast-snowflake plugin into main repo with documentation #2193 https://github.com/feast-dev/feast/pull/2193
feast-ci-bothttps://github.com/feast-ci-bot
Jan 31, 2022 https://github.com/feast-dev/feast/pull/2240#ref-commit-f2bc411
https://github.com/sfc-gh-madkins
https://github.com/dmille
https://github.com/pyalex
https://github.com/michelle-rascati-sp
https://github.com/judahrand
https://github.com/felixwang9817
https://github.com/adchia
https://github.com/NalinGHub
Merge feast-snowflake plugin into main repo with documentation (https://github.com/feast-dev/feast/commit/f2bc4119b44fd35ea6739118273cfa48aa243cbe
#2193https://github.com/feast-dev/feast/pull/2193
)https://github.com/feast-dev/feast/commit/f2bc4119b44fd35ea6739118273cfa48aa243cbe
f2bc411https://github.com/feast-dev/feast/commit/f2bc4119b44fd35ea6739118273cfa48aa243cbe
#2250https://github.com/feast-dev/feast/pull/2250
#2240https://github.com/feast-dev/feast/pull/2240
#2252https://github.com/feast-dev/feast/pull/2252
#2255https://github.com/feast-dev/feast/pull/2255
#2258https://github.com/feast-dev/feast/pull/2258
#2244https://github.com/feast-dev/feast/pull/2244
#2256https://github.com/feast-dev/feast/pull/2256
#2259https://github.com/feast-dev/feast/pull/2259
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F2240
https://github.com/judahrand
judahrand https://github.com/judahrand
https://github.com/feast-dev/feast/pull/2240/files/5145f5e95764c2153d43b73f01b5eaed677cd6d9
https://github.com/felixwang9817
felixwang9817 https://github.com/felixwang9817
https://github.com/feast-dev/feast/pull/2240/files/5145f5e95764c2153d43b73f01b5eaed677cd6d9
https://github.com/adchia
adchia https://github.com/adchia
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/judahrand
judahrand https://github.com/judahrand
https://github.com/felixwang9817
felixwang9817 https://github.com/felixwang9817
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
kind/bug https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fbug
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
release-note-none https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Arelease-note-none
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
Redis can delete incorrect keys https://github.com/feast-dev/feast/issues/2150
Please reload this pagehttps://github.com/feast-dev/feast/pull/2240
https://github.com/pyalex
https://github.com/codecov-commenter
https://github.com/judahrand
https://github.com/felixwang9817
https://github.com/feast-ci-bot
https://github.com/achals
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.