| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:ef86d16b-a78d-16ea-3f02-dc592cea2f92 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E58A:ECEED:72B42F:A0203D:6AFEAFB7 |
| html-safe-nonce | 97b096ebc7059383ba611433e034f5ee466edda6bb317b26dc39fb9b7e5e4f30 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNThBOkVDRUVEOjcyQjQyRjpBMDIwM0Q6NkFGRUFGQjciLCJ2aXNpdG9yX2lkIjoiMzUyNTc3NDA1NDIwMTkyOTY1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ce0915e6d98fba1f5cb81c2731e0a04c61ea2a65708e05c2ef50d519ae071923 |
| hovercard-subject-tag | pull_request:735611701 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/1872/commits |
| twitter:image | https://opengraph.githubassets.com/3b7db831a7b153b6b4473d734110a4d1d79f658fe743e36ea40c932397bb7127/feast-dev/feast/pull/1872 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3b7db831a7b153b6b4473d734110a4d1d79f658fe743e36ea40c932397bb7127/feast-dev/feast/pull/1872 |
| og:image:alt | Signed-off-by: David Y Liu davidyliuliu@gmail.com
What this PR does / why we need it:
#1867
Which issue(s) this PR fixes:
Fixes #1867
Does this PR introduce a user-facing change?:
Added ".w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mavysavydav |
| hostname | github.com |
| expected-hostname | github.com |
| None | 95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e |
| turbo-cache-control | no-cache |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3f25273206cd841171bca0002261ae4c9757d934 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/feast-dev/feast/pull/1872/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F1872%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F1872%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/1872/commits |
| Reload | https://github.com/feast-dev/feast/pull/1872/commits |
| Reload | https://github.com/feast-dev/feast/pull/1872/commits |
| feast-dev | https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
| Code | https://github.com/feast-dev/feast |
| Issues223 (223) | https://github.com/feast-dev/feast/issues |
| Pull requests143 (143) | https://github.com/feast-dev/feast/pulls |
| Discussions | https://github.com/feast-dev/feast/discussions |
| Actions | https://github.com/feast-dev/feast/actions |
| Security and quality1 (1) | https://github.com/feast-dev/feast/security |
| Insights | https://github.com/feast-dev/feast/insights |
| https://github.com/feast-dev/feast |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| mavysavydav:1867 | https://github.com/mavysavydav/feast/tree/1867 |
| Conversation | https://github.com/feast-dev/feast/pull/1872 |
| Commits14 (14) | https://github.com/feast-dev/feast/pull/1872/commits |
| Checks | https://github.com/feast-dev/feast/pull/1872/checks |
| Files changed | https://github.com/feast-dev/feast/pull/1872/files |
| Added .with_name method in FeatureView/OnDemandFeatureView classes for name aliasing. FeatureViewProjection will hold this information | https://github.com/feast-dev/feast/pull/1872/commits#top |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| mavysavydav:1867 | https://github.com/mavysavydav/feast/tree/1867 |
| Added .with_name method in FV with test case | https://github.com/feast-dev/feast/pull/1872/commits/a10052fddec74746dad2c9a33979da21d922d987 |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| a10052f | https://github.com/feast-dev/feast/pull/1872/commits/a10052fddec74746dad2c9a33979da21d922d987 |
| https://github.com/feast-dev/feast/tree/a10052fddec74746dad2c9a33979da21d922d987 |
| Correctly sort imports | https://github.com/feast-dev/feast/pull/1872/commits/ff0d9cf3c8c1b1e59a186e4c08ccc5512b15e579 |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| ff0d9cf | https://github.com/feast-dev/feast/pull/1872/commits/ff0d9cf3c8c1b1e59a186e4c08ccc5512b15e579 |
| https://github.com/feast-dev/feast/tree/ff0d9cf3c8c1b1e59a186e4c08ccc5512b15e579 |
| correct lint errors | https://github.com/feast-dev/feast/pull/1872/commits/f5c760f8482cf49942fdf0c89f147986d5e98e70 |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| f5c760f | https://github.com/feast-dev/feast/pull/1872/commits/f5c760f8482cf49942fdf0c89f147986d5e98e70 |
| https://github.com/feast-dev/feast/tree/f5c760f8482cf49942fdf0c89f147986d5e98e70 |
| Modified FeatureNameCollisionError msg | https://github.com/feast-dev/feast/pull/1872/commits/a309fbb7ebc68d8dd37b392b765a73cd0015adc4 |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| a309fbb | https://github.com/feast-dev/feast/pull/1872/commits/a309fbb7ebc68d8dd37b392b765a73cd0015adc4 |
| https://github.com/feast-dev/feast/tree/a309fbb7ebc68d8dd37b392b765a73cd0015adc4 |
| fixed error msg test | https://github.com/feast-dev/feast/pull/1872/commits/0551a43875f1d6736df9643d14dc73c1ac50b782 |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| 0551a43 | https://github.com/feast-dev/feast/pull/1872/commits/0551a43875f1d6736df9643d14dc73c1ac50b782 |
| https://github.com/feast-dev/feast/tree/0551a43875f1d6736df9643d14dc73c1ac50b782 |
| resolve merge conflicts | https://github.com/feast-dev/feast/pull/1872/commits/8a96dcadf4de821246cb97c5fcd925f9e6c8f605 |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| 8a96dca | https://github.com/feast-dev/feast/pull/1872/commits/8a96dcadf4de821246cb97c5fcd925f9e6c8f605 |
| https://github.com/feast-dev/feast/tree/8a96dcadf4de821246cb97c5fcd925f9e6c8f605 |
| updated code to preserve original FV name in base_name field | https://github.com/feast-dev/feast/pull/1872/commits/c8a72f4d31c4ae6cced1245ebd6a4947edf78036 |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| c8a72f4 | https://github.com/feast-dev/feast/pull/1872/commits/c8a72f4d31c4ae6cced1245ebd6a4947edf78036 |
| https://github.com/feast-dev/feast/tree/c8a72f4d31c4ae6cced1245ebd6a4947edf78036 |
| Updated proto conversion methods and fixed failures | https://github.com/feast-dev/feast/pull/1872/commits/21d224f8d2160d922bd0801b98d52f2384491446 |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| 21d224f | https://github.com/feast-dev/feast/pull/1872/commits/21d224f8d2160d922bd0801b98d52f2384491446 |
| https://github.com/feast-dev/feast/tree/21d224f8d2160d922bd0801b98d52f2384491446 |
| fixed proto numberings | https://github.com/feast-dev/feast/pull/1872/commits/4ca2048e6afd35412e7af0d346bc995f86cbbf3a |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| 4ca2048 | https://github.com/feast-dev/feast/pull/1872/commits/4ca2048e6afd35412e7af0d346bc995f86cbbf3a |
| https://github.com/feast-dev/feast/tree/4ca2048e6afd35412e7af0d346bc995f86cbbf3a |
| Merged with master | https://github.com/feast-dev/feast/pull/1872/commits/0dc06dc572d43d163ed1fa9158a08f9488f6045e |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| 0dc06dc | https://github.com/feast-dev/feast/pull/1872/commits/0dc06dc572d43d163ed1fa9158a08f9488f6045e |
| https://github.com/feast-dev/feast/tree/0dc06dc572d43d163ed1fa9158a08f9488f6045e |
| wip | https://github.com/feast-dev/feast/pull/1872/commits/5a091cf575663e0b4758505a11df7d94ebccdc05 |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| 5a091cf | https://github.com/feast-dev/feast/pull/1872/commits/5a091cf575663e0b4758505a11df7d94ebccdc05 |
| https://github.com/feast-dev/feast/tree/5a091cf575663e0b4758505a11df7d94ebccdc05 |
| Cleaned code up | https://github.com/feast-dev/feast/pull/1872/commits/476cbf3422a77bd99e2fd8f8f3d50331f4da2a2a |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| 476cbf3 | https://github.com/feast-dev/feast/pull/1872/commits/476cbf3422a77bd99e2fd8f8f3d50331f4da2a2a |
| https://github.com/feast-dev/feast/tree/476cbf3422a77bd99e2fd8f8f3d50331f4da2a2a |
| added copy method in FVProjections | https://github.com/feast-dev/feast/pull/1872/commits/d5cf2c579ec464caf781a14f082dc1912ea320f2 |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| d5cf2c5 | https://github.com/feast-dev/feast/pull/1872/commits/d5cf2c579ec464caf781a14f082dc1912ea320f2 |
| https://github.com/feast-dev/feast/tree/d5cf2c579ec464caf781a14f082dc1912ea320f2 |
| use python's copy lib rather than creating new copy method. | https://github.com/feast-dev/feast/pull/1872/commits/91595cf96320f4d3ada9b7a07f81ece19c7cebe3 |
| https://github.com/mavysavydav |
| mavysavydav | https://github.com/feast-dev/feast/commits?author=mavysavydav |
| 91595cf | https://github.com/feast-dev/feast/pull/1872/commits/91595cf96320f4d3ada9b7a07f81ece19c7cebe3 |
| https://github.com/feast-dev/feast/tree/91595cf96320f4d3ada9b7a07f81ece19c7cebe3 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |