Title: Most Unit Tests are not Running on feast.core package. · Issue #882 · feast-dev/feast · GitHub
Open Graph Title: Most Unit Tests are not Running on feast.core package. · Issue #882 · feast-dev/feast
X Title: Most Unit Tests are not Running on feast.core package. · Issue #882 · feast-dev/feast
Description: Expected Behavior When running mvn test to run tests, only one test class was running under the feast.core package: [INFO] [INFO] --- spotless-maven-plugin:1.26.1:check (spotless-check) @ feast-core --- [INFO] [INFO] --- maven-surefire-p...
Open Graph Description: Expected Behavior When running mvn test to run tests, only one test class was running under the feast.core package: [INFO] [INFO] --- spotless-maven-plugin:1.26.1:check (spotless-check) @ feast-cor...
X Description: Expected Behavior When running mvn test to run tests, only one test class was running under the feast.core package: [INFO] [INFO] --- spotless-maven-plugin:1.26.1:check (spotless-check) @ feast-cor...
Opengraph URL: https://github.com/feast-dev/feast/issues/882
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Most Unit Tests are not Running on feast.core package.","articleBody":"## Expected Behavior \r\nWhen running `mvn test` to run tests, only one test class was running under the `feast.core` package:\r\n```\r\n[INFO] \r\n[INFO] --- spotless-maven-plugin:1.26.1:check (spotless-check) @ feast-core --- \r\n[INFO] \r\n[INFO] --- maven-surefire-plugin:3.0.0-M4:test (default-test) @ feast-core --- \r\n[INFO] \r\n[INFO] ------------------------------------------------------- \r\n[INFO] T E S T S \r\n[INFO] ------------------------------------------------------- \r\n[INFO] Running feast.core.grpc.CoreServiceAuthTest \r\n[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.255 s - in feast.core.grpc.CoreServiceAuthTest \r\n[INFO] \r\n[INFO] Results: \r\n[INFO] \r\n[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 \r\n[INFO] \r\n````\r\nThis is unexpected as there a ton more tests under [core/src/test/java/feast/core/](https://github.com/feast-dev/feast/tree/master/core/src/test/java/feast/core). The rest of the unit tests should be running.\r\n\r\n## Cause\r\nInvestigation points to the new JUnit 5 (`org.junit.jupiter`) test harness added to Core's `pom.xml` in #793 \r\n- `CoreServiceAuthTest` is annotated with `@Test` from `org.junpiter.api.Test`\r\n- All other tests are using the old `@Test`: `org.junit.Test` \r\n\r\n## Proposed Solution\r\nRevert addition `JUnit` 5 on Feast Core and update `CoreServiceAuthTest` to use old `@Test`.\r\n\r\n","author":{"url":"https://github.com/mrzzy","@type":"Person","name":"mrzzy"},"datePublished":"2020-07-15T08:08:14.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/882/feast/issues/882"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:768ce78c-d6fb-7810-6052-e14ab03941d4 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9984:8B62A:3B8D981:4FE0BFF:697B0CD6 |
| html-safe-nonce | a542580e4c4ad5e75c6ef9b7209d2089749073f9a1511d9afe70bb5e0b452ce0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTg0OjhCNjJBOjNCOEQ5ODE6NEZFMEJGRjo2OTdCMENENiIsInZpc2l0b3JfaWQiOiI3OTgxMDY4NzEyNjQ5ODg2OTM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 74d850e0bfbfb3231e57d46df48c6f588a351a42023a218a130f58158ca5ba59 |
| hovercard-subject-tag | issue:657151946 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/882/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f37b02e0c462048352c7b15521b197c2f0bb80ec323f871bd95dd3c64e9e3862/feast-dev/feast/issues/882 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f37b02e0c462048352c7b15521b197c2f0bb80ec323f871bd95dd3c64e9e3862/feast-dev/feast/issues/882 |
| og:image:alt | Expected Behavior When running mvn test to run tests, only one test class was running under the feast.core package: [INFO] [INFO] --- spotless-maven-plugin:1.26.1:check (spotless-check) @ feast-cor... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mrzzy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7ce8ed0a54c4730aeca4e6abacfc6490365fc42e25480b86883054df3f9181c8 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d7bfc78137af9a4828305e52ab993fce981d7085 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width