Title: Add Labels to Source Object · Issue #835 · feast-dev/feast · GitHub
Open Graph Title: Add Labels to Source Object · Issue #835 · feast-dev/feast
X Title: Add Labels to Source Object · Issue #835 · feast-dev/feast
Description: Is your feature request related to a problem? Please describe. Currently, source in Feast is defined as the following in the FeatureSet spec spec: name: transaction maxAge: 86400s entities: - name: transaction_id features: - name: amount...
Open Graph Description: Is your feature request related to a problem? Please describe. Currently, source in Feast is defined as the following in the FeatureSet spec spec: name: transaction maxAge: 86400s entities: - name:...
X Description: Is your feature request related to a problem? Please describe. Currently, source in Feast is defined as the following in the FeatureSet spec spec: name: transaction maxAge: 86400s entities: - name:...
Opengraph URL: https://github.com/feast-dev/feast/issues/835
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add Labels to Source Object","articleBody":"**Is your feature request related to a problem? Please describe.**\r\nCurrently, `source` in Feast is defined as the following in the FeatureSet spec\r\n\r\n```yaml\r\nspec:\r\n name: transaction\r\n maxAge: 86400s\r\n entities:\r\n - name: transaction_id\r\n features:\r\n - name: amount\r\n valueType: FLOAT\r\n ...\r\n # Source definition\r\n source:\r\n kafkaSourceConfig:\r\n bootstrapServers: mybroker:9092\r\n topic: transaction\r\n type: KAFKA\r\n```\r\n\r\nFrom management perspective, when we list all the sources we use in Feast, we sometimes want to be able to filter or group these sources according to the organisational structure, for instance, team managing the source, the country where the source data comes from.\r\n\r\nCurrent source proto, however, does not allow us to provide such additional information.\r\n\r\n**Describe the solution you'd like**\r\nAdd `labels` field to the Source proto. This is similar to the labels field we currently have in FeatureSet\r\nhttps://github.com/feast-dev/feast/blob/master/protos/feast/core/FeatureSet.proto#L63\r\n\r\n```protobuf\r\nmessage Source {\r\n\r\n // The kind of data source Feast should connect to in order to retrieve FeatureRow value\r\n SourceType type = 1;\r\n\r\n // Source specific configuration\r\n oneof source_config {\r\n KafkaSourceConfig kafka_source_config = 2;\r\n }\r\n\r\n // Labels are key-value pairs attached to a Source object. They are intended to help users\r\n // organize Source objects in Feast. They do not directly imply semantics to the core system.\r\n //\r\n // Requirements for label keys and values:\r\n // - Keys have a min length of 1 character and max length of 63 characters. Values can\r\n // be empty and have a max length of 63 characters.\r\n // - Can only contain lowercase letters, numeric characters, underscores and dashes. All\r\n // characters must use UTF-8 encoding.\r\n // - Keys can only start with a lowercase letter.\r\n map\u003cstring, string\u003e labels = 3;\r\n}\r\n```\r\n\r\n**Describe alternatives you've considered**\r\nN/A\r\n\r\n**Additional context**\r\nThese labels information in the Source object can potentially be used to label ingestion jobs that are using the respective sources as well. In order to help organize ingestion jobs objects.\r\n","author":{"url":"https://github.com/davidheryanto","@type":"Person","name":"davidheryanto"},"datePublished":"2020-06-29T07:04:34.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":10},"url":"https://github.com/835/feast/issues/835"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4d0d7b34-6611-05d9-bbe0-b2cea279b060 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B10A:2071C0:25EB49F:3362BF3:6979ADCD |
| html-safe-nonce | 7e12dfad752296ed29c41df99fdd8fce20e15b25db87b6863e8eaf4bedfd6f15 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTBBOjIwNzFDMDoyNUVCNDlGOjMzNjJCRjM6Njk3OUFEQ0QiLCJ2aXNpdG9yX2lkIjoiMTg3Njg5MzUzNzUyNjE5NzcwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5736eaab748c27915b730ca9e0e4c2a7acf59196e7c120b08b65aa90f658951a |
| hovercard-subject-tag | issue:647170882 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/835/issue_layout |
| twitter:image | https://opengraph.githubassets.com/97eda335d6cad388e11e618ceddf978d61d2e244fb3b754167df8755140b76d3/feast-dev/feast/issues/835 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/97eda335d6cad388e11e618ceddf978d61d2e244fb3b754167df8755140b76d3/feast-dev/feast/issues/835 |
| og:image:alt | Is your feature request related to a problem? Please describe. Currently, source in Feast is defined as the following in the FeatureSet spec spec: name: transaction maxAge: 86400s entities: - name:... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | davidheryanto |
| hostname | github.com |
| expected-hostname | github.com |
| None | c049b65ec7e54cbf2521f5a560b6527714c612b0bd169188e2ea6e16f83bd5f4 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87b137883e35e2766c3d0f6a257c4044f6390b83 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width