René's URL Explorer Experiment


Title: File offline store returns wrong or future feature values when the entity dataframe has a column named like the source timestamp field · Issue #7176 · feast-dev/feast · GitHub

Open Graph Title: File offline store returns wrong or future feature values when the entity dataframe has a column named like the source timestamp field · Issue #7176 · feast-dev/feast

X Title: File offline store returns wrong or future feature values when the entity dataframe has a column named like the source timestamp field · Issue #7176 · feast-dev/feast

Description: Expected Behavior get_historical_features returns, for each entity row, the latest feature value at or before the row's event timestamp, and returns the entity dataframe's own columns unchanged, whatever they are called. The DuckDB offli...

Open Graph Description: Expected Behavior get_historical_features returns, for each entity row, the latest feature value at or before the row's event timestamp, and returns the entity dataframe's own columns unchanged, wh...

X Description: Expected Behavior get_historical_features returns, for each entity row, the latest feature value at or before the row's event timestamp, and returns the entity dataframe's own columns uncha...

Opengraph URL: https://github.com/feast-dev/feast/issues/7176

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"File offline store returns wrong or future feature values when the entity dataframe has a column named like the source timestamp field","articleBody":"## Expected Behavior\n\n`get_historical_features` returns, for each entity row, the latest feature value at or before the row's event timestamp, and returns the entity dataframe's own columns unchanged, whatever they are called. The DuckDB offline store does this.\n\n## Current Behavior\n\nWith the file (Dask) offline store, if the entity dataframe has a column with the same name as a feature view's source `timestamp_field` (other than the event timestamp column itself), the point-in-time join reads the entity dataframe's column instead of the source's:\n\n- The TTL filter and the latest-row selection use the request's value, so the result can be a value from after the event timestamp, or missing. In the example below, the expected value is 20 for every row; the file store returns `NA`, `NA` and `30` (a value from the day after the request).\n- The request's own column is dropped from the result, and the source column comes back under an internal name, `ts__`.\n- If the request's column is not a timestamp (a string, integer or float), the call fails with `AttributeError: 'str' object has no attribute 'tzinfo'`.\n- If the entity dataframe has both `ts` and `ts__`, the call fails with `ValueError: Duplicate column names found: ['driver_id', 'event_timestamp', 'ts__', 'ts__', ...]`. With two feature views whose timestamp field is `ts`, memory use keeps growing instead (past 2.4 GB within about 20 seconds for a one-row entity dataframe, when I stopped it).\n\n#7071 fixed the same problem for the source's `created_timestamp_column`. The event `timestamp_field` is still affected. The existing rename in `_field_mapping` only covers a `timestamp_field` equal to the entity dataframe's event timestamp column, and its `__` alias can itself collide with request data: with a source whose `timestamp_field` is `event_timestamp`, a request column named `__event_timestamp` makes the feature come back missing.\n\n## Steps to reproduce\n\n```python\nimport tempfile\nfrom datetime import timedelta\nfrom pathlib import Path\n\nimport pandas as pd\n\nfrom feast import Entity, FeatureStore, FeatureView, Field, FileSource, RepoConfig\nfrom feast.types import Int64\nfrom feast.value_type import ValueType\n\nrepo = Path(tempfile.mkdtemp())\npd.DataFrame(\n    {\n        \"driver_id\": [1, 1, 1, 2, 2, 2, 3, 3, 3],\n        \"ts\": pd.to_datetime([\"2024-01-01\", \"2024-01-02\", \"2024-01-03\"] * 3, utc=True),\n        \"trips\": [10, 20, 30] * 3,\n    }\n).to_parquet(repo / \"trips.parquet\")\n\ndriver = Entity(name=\"driver\", join_keys=[\"driver_id\"], value_type=ValueType.INT64)\ntrips = FeatureView(\n    name=\"driver_trips\",\n    entities=[driver],\n    schema=[Field(name=\"trips\", dtype=Int64)],\n    source=FileSource(path=str(repo / \"trips.parquet\"), timestamp_field=\"ts\"),\n    ttl=timedelta(days=7),\n)\n# Every driver has trips 10, 20 and 30 on 2024-01-01, -02 and -03. The requests are\n# at 2024-01-02 12:00, so the expected value is 20. The entity dataframe also has\n# its own column called \"ts\" (any request data that happens to use that name).\nentity_df = pd.DataFrame(\n    {\n        \"driver_id\": [1, 2, 3],\n        \"event_timestamp\": pd.to_datetime([\"2024-01-02 12:00\"] * 3, utc=True),\n        \"ts\": [\n            pd.Timestamp(\"2023-12-25\", tz=\"UTC\"),\n            pd.Timestamp(\"2024-01-10\", tz=\"UTC\"),\n            pd.Timestamp(\"2024-01-02 01:00\", tz=\"UTC\"),\n        ],\n    }\n)\n\nfor offline_store in [\"file\", \"duckdb\"]:\n    store = FeatureStore(\n        config=RepoConfig(\n            project=\"repro\",\n            provider=\"local\",\n            registry=str(repo / f\"registry_{offline_store}.db\"),\n            offline_store={\"type\": offline_store},\n            online_store={\"type\": \"sqlite\", \"path\": str(repo / \"online.db\")},\n            entity_key_serialization_version=3,\n            repo_path=str(repo),\n        )\n    )\n    store.apply([driver, trips])\n    df = store.get_historical_features(\n        entity_df=entity_df, features=[\"driver_trips:trips\"]\n    ).to_df()\n    print(f\"# {offline_store}\")\n    print(df.sort_values(\"driver_id\").to_string(index=False))\n```\n\nOutput on master (69ac7b0) and on 0.68.0 from PyPI:\n\n```\n# file\n driver_id           event_timestamp                      ts__  trips\n         1 2024-01-02 12:00:00+00:00                       NaT   \u003cNA>\n         2 2024-01-02 12:00:00+00:00                       NaT   \u003cNA>\n         3 2024-01-02 12:00:00+00:00 2024-01-03 00:00:00+00:00     30\n# duckdb\n driver_id           event_timestamp                        ts  trips\n         1 2024-01-02 12:00:00+00:00 2023-12-25 00:00:00+00:00     20\n         2 2024-01-02 12:00:00+00:00 2024-01-10 00:00:00+00:00     20\n         3 2024-01-02 12:00:00+00:00 2024-01-02 01:00:00+00:00     20\n```\n\n### Specifications\n\n- Version: master (69ac7b0) and 0.68.0\n- Platform: macOS, Python 3.12\n- Subsystem: file (Dask) offline store, `get_historical_features`\n\n## Possible Solution\n\nIn `DaskOfflineStore.get_historical_features`, `_merge` joins the source data to the entity dataframe with `suffixes=(\"\", \"__\")`. When both have a column called `timestamp_field`, the entity dataframe's column keeps the name and the source's becomes `ts__`, but `_normalize_timestamp`, `_filter_ttl`, `_drop_duplicates` and `_drop_columns` all still use `timestamp_field`.\n\nThe fix: rename the source's timestamp column to an unused temporary name before the merge whenever the entity dataframe already has that name, as #7071 does for the created timestamp column. I have a PR ready with regression tests.\n","author":{"url":"https://github.com/iammanoj807","@type":"Person","name":"iammanoj807"},"datePublished":"2026-11-18T07:31:35Z","url":"https://github.com/feast-dev/feast/issues/7176"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6ce4b2d6-593e-8aa1-c1cf-e74df37559db
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id94F6:1085C1:D21D96:1145D6A:6AFE8F6C
html-safe-nonce27352223c60d40947fe3eb7e84b41629ea6b8c703a5e9efd95f5504625e02a98
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEY2OjEwODVDMTpEMjFEOTY6MTE0NUQ2QTo2QUZFOEY2QyIsInZpc2l0b3JfaWQiOiIzMzMyMTY2OTAwMzg4MDQzMzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac692c22184464516ccec1eb3fdc2a471522ff4f916c7f10ec531b6759cba6448b
hovercard-subject-tagissue:6462261971
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/7176/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7ccfa0d121d28d33ec1403d3669d3e6a4f0bfaf5da5652653f183b5ffb2bd38d/feast-dev/feast/issues/7176
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7ccfa0d121d28d33ec1403d3669d3e6a4f0bfaf5da5652653f183b5ffb2bd38d/feast-dev/feast/issues/7176
og:image:altExpected Behavior get_historical_features returns, for each entity row, the latest feature value at or before the row's event timestamp, and returns the entity dataframe's own columns unchanged, wh...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameiammanoj807
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/7176#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F7176
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F7176
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/7176
Reloadhttps://github.com/feast-dev/feast/issues/7176
Reloadhttps://github.com/feast-dev/feast/issues/7176
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/7176
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/7176
#7177https://github.com/feast-dev/feast/pull/7177
File offline store returns wrong or future feature values when the entity dataframe has a column named like the source timestamp fieldhttps://github.com/feast-dev/feast/issues/7176#top
#7177https://github.com/feast-dev/feast/pull/7177
https://github.com/iammanoj807
iammanoj807https://github.com/iammanoj807
on Nov 18, 2026https://github.com/feast-dev/feast/issues/7176#issue-6462261971
#7071https://github.com/feast-dev/feast/pull/7071
69ac7b0https://github.com/feast-dev/feast/commit/69ac7b077ebb0eadee35ff7b928cda6d8303fb0f
69ac7b0https://github.com/feast-dev/feast/commit/69ac7b077ebb0eadee35ff7b928cda6d8303fb0f
#7071https://github.com/feast-dev/feast/pull/7071
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/7176
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/7176
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.