Title: Dask historical retrieval drops entity requests with only expired or future features · Issue #6999 · feast-dev/feast · GitHub
Open Graph Title: Dask historical retrieval drops entity requests with only expired or future features · Issue #6999 · feast-dev/feast
X Title: Dask historical retrieval drops entity requests with only expired or future features · Issue #6999 · feast-dev/feast
Description: The Dask/File historical retrieval path drops an input entity row when matching source records exist but all are outside the point-in-time window. An entity with no source records is retained, so the output cardinality depends on whether...
Open Graph Description: The Dask/File historical retrieval path drops an input entity row when matching source records exist but all are outside the point-in-time window. An entity with no source records is retained, so t...
X Description: The Dask/File historical retrieval path drops an input entity row when matching source records exist but all are outside the point-in-time window. An entity with no source records is retained, so t...
Opengraph URL: https://github.com/feast-dev/feast/issues/6999
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Dask historical retrieval drops entity requests with only expired or future features","articleBody":"The Dask/File historical retrieval path drops an input entity row when matching source records exist but all are outside the point-in-time window. An entity with no source records is retained, so the output cardinality depends on whether an unusable record happens to exist.\n\nThis silently removes caller-supplied columns such as training labels, and can also discard valid features already joined from another feature view.\n\nMinimal reproduction on current master (d6cc1dc), using a real Parquet source and local FeatureStore:\n\n```python\nfrom datetime import timedelta\nfrom pathlib import Path\nfrom tempfile import TemporaryDirectory\n\nimport pandas as pd\nfrom feast import Entity, FeatureStore, FeatureView, Field, FileSource, RepoConfig\nfrom feast.types import Float64, ValueType\n\nwith TemporaryDirectory() as directory:\n root = Path(directory)\n source_path = root / \"stats.parquet\"\n pd.DataFrame({\n \"driver_id\": [1],\n \"event_timestamp\": pd.to_datetime([\"2025-01-01T00:00:00Z\"]),\n \"value\": [10.0],\n }).to_parquet(source_path)\n driver = Entity(name=\"driver\", join_keys=[\"driver_id\"],\n value_type=ValueType.INT64)\n view = FeatureView(\n name=\"stats\", entities=[driver],\n schema=[Field(name=\"value\", dtype=Float64)],\n source=FileSource(path=str(source_path), timestamp_field=\"event_timestamp\"),\n ttl=timedelta(days=1),\n )\n store = FeatureStore(config=RepoConfig(\n project=\"ttl_rows\", registry=str(root / \"registry.db\"),\n provider=\"local\", offline_store={\"type\": \"file\"},\n online_store={\"type\": \"sqlite\", \"path\": str(root / \"online.db\")},\n ))\n store.apply([driver, view])\n entities = pd.DataFrame({\n \"driver_id\": [1, 2],\n \"event_timestamp\": pd.to_datetime([\"2025-01-03T00:00:00Z\"] * 2),\n \"label\": [\"expired\", \"missing\"],\n })\n print(store.get_historical_features(\n entity_df=entities, features=[\"stats:value\"]\n ).to_df())\n```\n\nExpected: both input rows and labels survive, with null `value` for both.\n\nActual: only driver 2 survives. Driver 1 and the `expired` label disappear. The same problem occurs with future-only source records, including when TTL is zero or unset.\n\n`_merge` creates a left join, then `_filter_ttl` removes every candidate for that request. Null source timestamps are retained, but existing out-of-window records do not become null left-join results.\n\nThis is distinct from #6787: the reproduction has unique (join key, entity timestamp) pairs and no duplicate input requests.\n\nI have a fix that nulls only the current source's ineligible columns for entity-dataframe retrieval, retaining entity columns and previously joined features. Retrieval without an entity dataframe keeps its existing snapshot filtering. On the original code, 13 of 14 new real-FeatureStore regressions fail; with the fix, 38 related tests pass (5 unrelated optional-backend tests are skipped), and Ruff plus scoped mypy pass.\n","author":{"url":"https://github.com/NUAAwqy","@type":"Person","name":"NUAAwqy"},"datePublished":"2026-10-13T04:13:23Z","url":"https://github.com/feast-dev/feast/issues/6999"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:20c9d234-09ca-d24e-5b4f-ed6779743093 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9D4E:2826BD:E3BB55:12B746D:6AFE9246 |
| html-safe-nonce | 03e832822bf4ebe812337b0dd3294c9c802d313d70e3be33195512eea0408735 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDRFOjI4MjZCRDpFM0JCNTU6MTJCNzQ2RDo2QUZFOTI0NiIsInZpc2l0b3JfaWQiOiI3NjkwNTYxMjA5Mjg3NzQyMDIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7bcc842f64f0920c56a475ade2e557768873d21e79f6ce58062a96137031d419 |
| hovercard-subject-tag | issue:5824394653 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/6999/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b400e4a0f9dd4e9fe167b38331f1081ea6c37587ee5f5c94aefcf6a77fc6a908/feast-dev/feast/issues/6999 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b400e4a0f9dd4e9fe167b38331f1081ea6c37587ee5f5c94aefcf6a77fc6a908/feast-dev/feast/issues/6999 |
| og:image:alt | The Dask/File historical retrieval path drops an input entity row when matching source records exist but all are outside the point-in-time window. An entity with no source records is retained, so t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | NUAAwqy |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width