René's URL Explorer Experiment


Title: disable_event_timestamp is plumbed into MaterializationTask but no materialization engine reads it · Issue #6936 · feast-dev/feast · GitHub

Open Graph Title: disable_event_timestamp is plumbed into MaterializationTask but no materialization engine reads it · Issue #6936 · feast-dev/feast

X Title: disable_event_timestamp is plumbed into MaterializationTask but no materialization engine reads it · Issue #6936 · feast-dev/feast

Description: Expected Behavior FeatureStore.materialize(..., disable_event_timestamp=True) — and the feast materialize --disable-event-timestamp CLI flag and the feature server's disable_event_timestamp request field that call it — are documented as ...

Open Graph Description: Expected Behavior FeatureStore.materialize(..., disable_event_timestamp=True) — and the feast materialize --disable-event-timestamp CLI flag and the feature server's disable_event_timestamp request...

X Description: Expected Behavior FeatureStore.materialize(..., disable_event_timestamp=True) — and the feast materialize --disable-event-timestamp CLI flag and the feature server's disable_event_timestamp req...

Opengraph URL: https://github.com/feast-dev/feast/issues/6936

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"disable_event_timestamp is plumbed into MaterializationTask but no materialization engine reads it","articleBody":"## Expected Behavior\n\n`FeatureStore.materialize(..., disable_event_timestamp=True)` — and the `feast materialize --disable-event-timestamp` CLI flag and the feature server's `disable_event_timestamp` request field that call it — are documented as \"materializes all available data using current datetime as event timestamp\" (`feature_store.py` ~L2858, `infra/provider.py` ~L246). Rows written to the online store under this flag should carry the materialization time as their event timestamp.\n\n## Current Behavior\n\nThe flag is threaded all the way down (`feature_store.py` → provider → `MaterializationTask.disable_event_timestamp` in `infra/common/materialization_job.py` ~L25) and then nothing reads it: `grep -rn disable_event_timestamp sdk/python/feast/infra/materialization sdk/python/feast/infra/compute_engines` returns no hits. The source's own event timestamp is written unchanged.\n\nRepro (local provider, sqlite online store, a FileSource whose row is stamped 2020-01-01):\n\n```\nfeast apply\nfeast materialize --disable-event-timestamp\n# then get_online_features(...).to_dict(include_event_timestamps=True)\n```\n\nreturns `event_timestamp = 1577836800` (2020-01-01) for the materialized row — the source value, not the current time.\n\nThe flag's other effect — widening the materialization window to \"everything\" — does happen (and has a separate timezone bug in how it computes the end bound, which I'm sending as a small PR). This issue is only about the documented \"use current datetime as event timestamp\" behaviour never having been implemented since the flag landed in eb51f005d.\n\n## Steps to reproduce\n\n1. `feast init` a local repo; point a `FeatureView` at a parquet `FileSource` with one row whose `event_timestamp` is 2020-01-01.\n2. `feast apply && feast materialize --disable-event-timestamp`\n3. Read the row back with `get_online_features(...).to_dict(include_event_timestamps=True)`.\n4. Observe the 2020 timestamp.\n\n### Specifications\n\n- Version: 0.66.1.dev72+g97296c19f (master @ 97296c19f)\n- Platform: macOS, Python 3.13\n- Subsystem: materialization (local engine; the flag is unread by every engine under `infra/materialization/` and `infra/compute_engines/`)\n\n## Possible Solution\n\nEither implement it — have the materialization engines overwrite the event timestamp column with `_utc_now()` when `task.disable_event_timestamp` is set, before the online write — or drop the \"current datetime\" promise from the three docstrings and let the flag mean only \"full window\". The first is the documented contract; happy to take it on if a maintainer confirms which engines should honour it (local only, or all).","author":{"url":"https://github.com/joaquinhuigomez","@type":"Person","name":"joaquinhuigomez"},"datePublished":"2026-10-04T22:46:12Z","url":"https://github.com/feast-dev/feast/issues/6936"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a77f033d-f1f6-4fac-763a-cecc73967de8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC2E8:8FE13:175034:1F2211:6AFE9521
html-safe-nonce0cd7991ad40f7c6826f6b9cd58596a6c24c7b5d7c3fccd26ab4a8823dfd2253a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkU4OjhGRTEzOjE3NTAzNDoxRjIyMTE6NkFGRTk1MjEiLCJ2aXNpdG9yX2lkIjoiNzA2MzQ3MDgyODQ0ODI5MDA4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdf11d2c5b96693c632a05041c65276d70d1e358e614dc08c07fe604f8029f89d
hovercard-subject-tagissue:5704016810
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/6936/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e80c464ac2166a0d14c939de2cd0fa86efb60c766fb71f73a66d4965021023ad/feast-dev/feast/issues/6936
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e80c464ac2166a0d14c939de2cd0fa86efb60c766fb71f73a66d4965021023ad/feast-dev/feast/issues/6936
og:image:altExpected Behavior FeatureStore.materialize(..., disable_event_timestamp=True) — and the feast materialize --disable-event-timestamp CLI flag and the feature server's disable_event_timestamp request...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoaquinhuigomez
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/6936#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6936
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6936
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/6936
Reloadhttps://github.com/feast-dev/feast/issues/6936
Reloadhttps://github.com/feast-dev/feast/issues/6936
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6936
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6936
#6956https://github.com/feast-dev/feast/pull/6956
disable_event_timestamp is plumbed into MaterializationTask but no materialization engine reads ithttps://github.com/feast-dev/feast/issues/6936#top
#6956https://github.com/feast-dev/feast/pull/6956
https://github.com/joaquinhuigomez
joaquinhuigomezhttps://github.com/joaquinhuigomez
on Oct 4, 2026https://github.com/feast-dev/feast/issues/6936#issue-5704016810
eb51f00https://github.com/feast-dev/feast/commit/eb51f005dddba8aedd528032d62d966166c028eb
97296c1https://github.com/feast-dev/feast/commit/97296c19f17a05417a439d4bbc31130727a6232f
https://github.com/patelchaitany
patelchaitanyhttps://github.com/patelchaitany
on Oct 6, 2026https://github.com/feast-dev/feast/issues/6936#issuecomment-6011762966
https://github.com/Toyenzo
Toyenzohttps://github.com/Toyenzo
on Oct 6, 2026https://github.com/feast-dev/feast/issues/6936#issuecomment-6016383044
patelchaitanyhttps://github.com/patelchaitany
on Oct 7, 2026https://github.com/feast-dev/feast/issues/6936#event-32661651299
fix: Use UTC end bound and correct docs for disable_event_timestamphttps://github.com/patelchaitany/feast/commit/cc13f9d96434c3a4f2db03e80e6a2fcf715689a6
https://docs.github.com/articles/closing-issues-via-commit-messages
cc13f9dhttps://github.com/patelchaitany/feast/commit/cc13f9d96434c3a4f2db03e80e6a2fcf715689a6
fix: Use UTC end bound and correct docs for disable_event_timestamphttps://github.com/patelchaitany/feast/commit/4b57b7aab89dd29c058cf03bcaa9b097f465a246
https://docs.github.com/articles/closing-issues-via-commit-messages
4b57b7ahttps://github.com/patelchaitany/feast/commit/4b57b7aab89dd29c058cf03bcaa9b097f465a246
ntkatholehttps://github.com/ntkathole
on Oct 7, 2026https://github.com/feast-dev/feast/issues/6936#event-32684121930
fix: Use UTC end bound and correct docs for disable_event_timestamphttps://github.com/patelchaitany/feast/commit/f330e873f8bd539dc40c274e7acbdecb9d58cc13
https://docs.github.com/articles/closing-issues-via-commit-messages
f330e87https://github.com/patelchaitany/feast/commit/f330e873f8bd539dc40c274e7acbdecb9d58cc13
patelchaitanyhttps://github.com/patelchaitany
on Oct 7, 2026https://github.com/feast-dev/feast/issues/6936#event-32689242213
fix: Use UTC end bound and correct docs for disable_event_timestamphttps://github.com/patelchaitany/feast/commit/73998ae03f4ce8d7783c9175a6c0fb7e49dd29cb
https://docs.github.com/articles/closing-issues-via-commit-messages
73998aehttps://github.com/patelchaitany/feast/commit/73998ae03f4ce8d7783c9175a6c0fb7e49dd29cb
fix: Use UTC end bound and correct docs for disable_event_timestamphttps://github.com/patelchaitany/feast/commit/6251e9f3d1b03b4a87b4f6892143d2fe6bd960b5
https://docs.github.com/articles/closing-issues-via-commit-messages
6251e9fhttps://github.com/patelchaitany/feast/commit/6251e9f3d1b03b4a87b4f6892143d2fe6bd960b5
ntkatholehttps://github.com/ntkathole
on Oct 9, 2026https://github.com/feast-dev/feast/issues/6936#event-32856309399
fix: Use UTC end bound and correct docs for disable_event_timestamphttps://github.com/patelchaitany/feast/commit/9617d6e649385ef680b2d0ede2b37edcc037a8b5
https://docs.github.com/articles/closing-issues-via-commit-messages
9617d6ehttps://github.com/patelchaitany/feast/commit/9617d6e649385ef680b2d0ede2b37edcc037a8b5
ntkatholehttps://github.com/ntkathole
completedhttps://github.com/feast-dev/feast/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#6956https://github.com/feast-dev/feast/pull/6956
on Oct 9, 2026https://github.com/feast-dev/feast/issues/6936#event-32856334178
ntkatholehttps://github.com/ntkathole
on Oct 9, 2026https://github.com/feast-dev/feast/issues/6936#event-32856550339
fix: Use UTC end bound and correct docs for disable_event_timestamp (f…https://github.com/dbbvitor/feast/commit/cc07c825759185ac8a4d2709e26989a766638381
f…https://github.com/feast-dev/feast/pull/6956
https://docs.github.com/articles/closing-issues-via-commit-messages
cc07c82https://github.com/dbbvitor/feast/commit/cc07c825759185ac8a4d2709e26989a766638381
chore(release): release 0.67.0https://github.com/feast-dev/feast/commit/2dfb9e6d1a37719fd11028d916094050f1cdd552
https://docs.github.com/articles/closing-issues-via-commit-messages
2dfb9e6https://github.com/feast-dev/feast/commit/2dfb9e6d1a37719fd11028d916094050f1cdd552
fix: Merge upstream feast-dev/feast master - resolve CSV conflict (#247)https://github.com/opendatahub-io/feast/commit/2b0b7d75acd0a1fbee53a0e77a81010905a82fbc
#247https://github.com/opendatahub-io/feast/pull/247
https://docs.github.com/articles/closing-issues-via-commit-messages
2b0b7d7https://github.com/opendatahub-io/feast/commit/2b0b7d75acd0a1fbee53a0e77a81010905a82fbc
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/6936
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6936
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.