Title: disable_event_timestamp is plumbed into MaterializationTask but no materialization engine reads it · Issue #6936 · feast-dev/feast · GitHub
Open Graph Title: disable_event_timestamp is plumbed into MaterializationTask but no materialization engine reads it · Issue #6936 · feast-dev/feast
X Title: disable_event_timestamp is plumbed into MaterializationTask but no materialization engine reads it · Issue #6936 · feast-dev/feast
Description: Expected Behavior FeatureStore.materialize(..., disable_event_timestamp=True) — and the feast materialize --disable-event-timestamp CLI flag and the feature server's disable_event_timestamp request field that call it — are documented as ...
Open Graph Description: Expected Behavior FeatureStore.materialize(..., disable_event_timestamp=True) — and the feast materialize --disable-event-timestamp CLI flag and the feature server's disable_event_timestamp request...
X Description: Expected Behavior FeatureStore.materialize(..., disable_event_timestamp=True) — and the feast materialize --disable-event-timestamp CLI flag and the feature server's disable_event_timestamp req...
Opengraph URL: https://github.com/feast-dev/feast/issues/6936
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"disable_event_timestamp is plumbed into MaterializationTask but no materialization engine reads it","articleBody":"## Expected Behavior\n\n`FeatureStore.materialize(..., disable_event_timestamp=True)` — and the `feast materialize --disable-event-timestamp` CLI flag and the feature server's `disable_event_timestamp` request field that call it — are documented as \"materializes all available data using current datetime as event timestamp\" (`feature_store.py` ~L2858, `infra/provider.py` ~L246). Rows written to the online store under this flag should carry the materialization time as their event timestamp.\n\n## Current Behavior\n\nThe flag is threaded all the way down (`feature_store.py` → provider → `MaterializationTask.disable_event_timestamp` in `infra/common/materialization_job.py` ~L25) and then nothing reads it: `grep -rn disable_event_timestamp sdk/python/feast/infra/materialization sdk/python/feast/infra/compute_engines` returns no hits. The source's own event timestamp is written unchanged.\n\nRepro (local provider, sqlite online store, a FileSource whose row is stamped 2020-01-01):\n\n```\nfeast apply\nfeast materialize --disable-event-timestamp\n# then get_online_features(...).to_dict(include_event_timestamps=True)\n```\n\nreturns `event_timestamp = 1577836800` (2020-01-01) for the materialized row — the source value, not the current time.\n\nThe flag's other effect — widening the materialization window to \"everything\" — does happen (and has a separate timezone bug in how it computes the end bound, which I'm sending as a small PR). This issue is only about the documented \"use current datetime as event timestamp\" behaviour never having been implemented since the flag landed in eb51f005d.\n\n## Steps to reproduce\n\n1. `feast init` a local repo; point a `FeatureView` at a parquet `FileSource` with one row whose `event_timestamp` is 2020-01-01.\n2. `feast apply && feast materialize --disable-event-timestamp`\n3. Read the row back with `get_online_features(...).to_dict(include_event_timestamps=True)`.\n4. Observe the 2020 timestamp.\n\n### Specifications\n\n- Version: 0.66.1.dev72+g97296c19f (master @ 97296c19f)\n- Platform: macOS, Python 3.13\n- Subsystem: materialization (local engine; the flag is unread by every engine under `infra/materialization/` and `infra/compute_engines/`)\n\n## Possible Solution\n\nEither implement it — have the materialization engines overwrite the event timestamp column with `_utc_now()` when `task.disable_event_timestamp` is set, before the online write — or drop the \"current datetime\" promise from the three docstrings and let the flag mean only \"full window\". The first is the documented contract; happy to take it on if a maintainer confirms which engines should honour it (local only, or all).","author":{"url":"https://github.com/joaquinhuigomez","@type":"Person","name":"joaquinhuigomez"},"datePublished":"2026-10-04T22:46:12Z","url":"https://github.com/feast-dev/feast/issues/6936"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a77f033d-f1f6-4fac-763a-cecc73967de8 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C2E8:8FE13:175034:1F2211:6AFE9521 |
| html-safe-nonce | 0cd7991ad40f7c6826f6b9cd58596a6c24c7b5d7c3fccd26ab4a8823dfd2253a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkU4OjhGRTEzOjE3NTAzNDoxRjIyMTE6NkFGRTk1MjEiLCJ2aXNpdG9yX2lkIjoiNzA2MzQ3MDgyODQ0ODI5MDA4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | df11d2c5b96693c632a05041c65276d70d1e358e614dc08c07fe604f8029f89d |
| hovercard-subject-tag | issue:5704016810 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/6936/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e80c464ac2166a0d14c939de2cd0fa86efb60c766fb71f73a66d4965021023ad/feast-dev/feast/issues/6936 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e80c464ac2166a0d14c939de2cd0fa86efb60c766fb71f73a66d4965021023ad/feast-dev/feast/issues/6936 |
| og:image:alt | Expected Behavior FeatureStore.materialize(..., disable_event_timestamp=True) — and the feast materialize --disable-event-timestamp CLI flag and the feature server's disable_event_timestamp request... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joaquinhuigomez |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width