René's URL Explorer Experiment


Title: Redis online store: HGETALL for wide reads, and an opt-in GIL-free client (valkey-glide) for get_online_features · Issue #6856 · feast-dev/feast · GitHub

Open Graph Title: Redis online store: HGETALL for wide reads, and an opt-in GIL-free client (valkey-glide) for get_online_features · Issue #6856 · feast-dev/feast

X Title: Redis online store: HGETALL for wide reads, and an opt-in GIL-free client (valkey-glide) for get_online_features · Issue #6856 · feast-dev/feast

Description: Is your feature request related to a problem? Please describe. The Python get_online_features path against the Redis online store is slow for wide reads, and the cost is on the client, not the server. Our shape is 4 FeatureViews, ~90 fie...

Open Graph Description: Is your feature request related to a problem? Please describe. The Python get_online_features path against the Redis online store is slow for wide reads, and the cost is on the client, not the serv...

X Description: Is your feature request related to a problem? Please describe. The Python get_online_features path against the Redis online store is slow for wide reads, and the cost is on the client, not the serv...

Opengraph URL: https://github.com/feast-dev/feast/issues/6856

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Redis online store: HGETALL for wide reads, and an opt-in GIL-free client (valkey-glide) for get_online_features","articleBody":"**Is your feature request related to a problem? Please describe.**\n\nThe Python `get_online_features` path against the Redis online store is slow for wide reads, and the cost is on the client, not the server. Our shape is 4 FeatureViews, ~90 fields, 350 to 500 entities per call, served from a FastAPI process that does other work at the same time.\n\nTwo separate problems show up:\n\n1. **HMGET on listpack-encoded hashes scans once per requested field.** Redis and Valkey keep a hash as a listpack up to `hash-max-listpack-entries` (default 128 on Redis 7 and Valkey 8). Our hashes have ~120 fields, so every HMGET of ~90 fields does ~90 linear scans. Measured on Valkey 8 with `INFO commandstats`, same 500 keys:\n\n   | command | server time per command | server time per 500-entity read |\n   |---|---|---|\n   | HMGET, 94 named fields | 25.8 us | 12.9 ms |\n   | HGETALL (123 fields) | 5.6 us | 2.8 ms |\n\n   HGETALL returns about a third more bytes and is still 4.6x cheaper for the server. This is the optimization #3337 asked for in 2022 (the Java server switches to HGETALL above 50 features); that issue was closed by the stale bot without a change.\n\n2. **The Python client work holds the GIL in thousands of short bursts per read.** redis-py packs every command, hiredis parses every reply, and each socket receive releases and reacquires the GIL. Then the SDK turns every `ValueProto` blob into a Python object. In a process with other threads running Python, every one of those reacquires waits out the switch interval, so the read time depends on how busy the rest of the process is.\n\n   Same machine, same data, Feast 0.66 (which already has the single-pipeline read from #6337), 500 entities, ~90 fields across 4 views, p50 of 40 runs:\n\n   | read path | alone | while another thread runs pure-Python work |\n   |---|---|---|\n   | `get_online_features` (redis-py + hiredis) | 140 ms | 946 ms |\n   | same field plan, one HGETALL per entity through valkey-glide (Rust core), decode in Python | 43 ms | 160 ms |\n\n   The 6x gap under contention is the part that matters in production. It does not show up in a single-threaded benchmark.\n\n**Describe the solution you'd like**\n\nTwo changes to `RedisOnlineStore`, independent of each other:\n\n1. In `_read_features_per_fv` / the batched `get_online_features`, issue HGETALL instead of HMGET when the number of requested hash fields crosses a threshold (the Java server uses 50), and pick the requested fields out of the reply. Everything else stays the same: same `_redis_key`, same `_mmh3` field names, same `_ts:\u003cview>` presence check.\n\n2. An opt-in client for the Redis online store that runs the pipeline off the GIL. [valkey-glide](https://github.com/valkey-io/valkey-glide) (`valkey-glide-sync` on PyPI) is an official Valkey client with a Rust core; a non-atomic `Batch` is one FFI call, so the whole fetch runs with the GIL released and returns once. It speaks RESP to Redis and Valkey and supports TLS and cluster mode. A `connection_string`-compatible `client: glide` option on `RedisOnlineStoreConfig` would keep `feature_store.yaml` as the single place the store is configured.\n\n**Describe alternatives you've considered**\n\n- The Go feature server. It needs the file registry (we use the SQL registry) and a separate Python transformation service for on-demand views, and the Python wheel does not ship the Go library.\n- `get_online_features_async`. Same Python parsing on the same GIL; measured within a few percent of the sync path.\n- Lowering `hash-max-listpack-entries` on the server so hashes become hashtables. That does remove most of the HMGET cost (7.4 ms to 1.1 ms server time in our test) but costs ~40% more memory and is an operator-side change; HGETALL gets most of the same win from the client.\n- Reading `OnlineResponse.proto` directly instead of `to_dict()`. Worth about 20%, but the redis-py fetch is still the part that stalls under contention.\n\nWe have both changes running in a fork of the read path and are happy to contribute either as a PR if there is interest in the direction.\n\n**Additional context**\n\nRelated: #3337 (HGETALL request, closed stale), #4711 and #6337 (single pipeline across feature views, merged; the numbers above are with that in place), #3649 (registry `from_proto` overhead, a separate cost).\n","author":{"url":"https://github.com/chandlerok","@type":"Person","name":"chandlerok"},"datePublished":"2026-09-22T16:01:40Z","url":"https://github.com/feast-dev/feast/issues/6856"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5846f07b-19ba-5409-ff3d-43213920bbc9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD6DC:3DB40C:2E0B43:3F5003:6AFE9816
html-safe-nonce2935583ea588c21c96dd4c23eb17fc41310b85bf6ae8dbb048cf8f644357d81b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkRDOjNEQjQwQzoyRTBCNDM6M0Y1MDAzOjZBRkU5ODE2IiwidmlzaXRvcl9pZCI6IjI2Mzc2MDAxNzkxNzEwMDY0ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1e35d9b264e7134b56537c4e1a9a559ba1fb997ff111a45655565c7fc8a63426
hovercard-subject-tagissue:5542055888
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/6856/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c1ce8aadb8933fe85100b02621da0abb0920775be45c9dc5a5313e2caad2a718/feast-dev/feast/issues/6856
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c1ce8aadb8933fe85100b02621da0abb0920775be45c9dc5a5313e2caad2a718/feast-dev/feast/issues/6856
og:image:altIs your feature request related to a problem? Please describe. The Python get_online_features path against the Redis online store is slow for wide reads, and the cost is on the client, not the serv...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechandlerok
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/6856#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6856
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6856
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/6856
Reloadhttps://github.com/feast-dev/feast/issues/6856
Reloadhttps://github.com/feast-dev/feast/issues/6856
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6856
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6856
Redis online store: HGETALL for wide reads, and an opt-in GIL-free client (valkey-glide) for get_online_featureshttps://github.com/feast-dev/feast/issues/6856#top
https://github.com/chandlerok
chandlerokhttps://github.com/chandlerok
on Sep 22, 2026https://github.com/feast-dev/feast/issues/6856#issue-5542055888
HGETALL optimization for Redis retrieval in Python #3337https://github.com/feast-dev/feast/issues/3337
feat: Addresses performance issues in the Redis online store #6337https://github.com/feast-dev/feast/pull/6337
valkey-glidehttps://github.com/valkey-io/valkey-glide
#3337https://github.com/feast-dev/feast/issues/3337
#4711https://github.com/feast-dev/feast/issues/4711
#6337https://github.com/feast-dev/feast/pull/6337
#3649https://github.com/feast-dev/feast/issues/3649
https://github.com/patelchaitany
patelchaitanyhttps://github.com/patelchaitany
on Sep 23, 2026https://github.com/feast-dev/feast/issues/6856#issuecomment-5798470538
@chandlerokhttps://github.com/chandlerok
https://github.com/chandlerok
chandlerokhttps://github.com/chandlerok
on Sep 25, 2026https://github.com/feast-dev/feast/issues/6856#issuecomment-5833601799
@patelchaitanyhttps://github.com/patelchaitany
https://github.com/chandlerok
chandlerokhttps://github.com/chandlerok
on Sep 25, 2026https://github.com/feast-dev/feast/issues/6856#issuecomment-5836122502
ntkatholehttps://github.com/ntkathole
on Oct 1, 2026https://github.com/feast-dev/feast/issues/6856#event-32253984307
feat: Add optional GLIDE client for Redis online readshttps://github.com/chandlerok/feast/commit/51d2200c7277180e530716bdac144029cee2ffc7
51d2200https://github.com/chandlerok/feast/commit/51d2200c7277180e530716bdac144029cee2ffc7
feat: Add optional GLIDE client for Redis online readshttps://github.com/chandlerok/feast/commit/8182dc47a077200a2bdc6bed9d1859988c5353cf
8182dc4https://github.com/chandlerok/feast/commit/8182dc47a077200a2bdc6bed9d1859988c5353cf
feat: Add optional GLIDE client for Redis online reads (#6870)https://github.com/feast-dev/feast/commit/6e9a532c9938f1258263422d7e3832720eb82453
#6870https://github.com/feast-dev/feast/pull/6870
6e9a532https://github.com/feast-dev/feast/commit/6e9a532c9938f1258263422d7e3832720eb82453
https://github.com/jakes44
jakes44https://github.com/jakes44
on Oct 26, 2026https://github.com/feast-dev/feast/issues/6856#issuecomment-6428279356
@patelchaitanyhttps://github.com/patelchaitany
https://github.com/chandlerok
chandlerokhttps://github.com/chandlerok
on Oct 26, 2026https://github.com/feast-dev/feast/issues/6856#issuecomment-6428744790
@jakes44https://github.com/jakes44
@patelchaitanyhttps://github.com/patelchaitany
#7072https://github.com/feast-dev/feast/issues/7072
#6870https://github.com/feast-dev/feast/pull/6870
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/6856
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6856
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.