René's URL Explorer Experiment


Title: get_historical_features (Dask/File) silently drops entity_df rows sharing a join key and timestamp · Issue #6787 · feast-dev/feast · GitHub

Open Graph Title: get_historical_features (Dask/File) silently drops entity_df rows sharing a join key and timestamp · Issue #6787 · feast-dev/feast

X Title: get_historical_features (Dask/File) silently drops entity_df rows sharing a join key and timestamp · Issue #6787 · feast-dev/feast

Description: Expected Behavior get_historical_features() should return exactly one output row per row in the input entity_df, regardless of whether some rows share a join key and event timestamp with other rows. Two entity_df rows with the same (join...

Open Graph Description: Expected Behavior get_historical_features() should return exactly one output row per row in the input entity_df, regardless of whether some rows share a join key and event timestamp with other rows...

X Description: Expected Behavior get_historical_features() should return exactly one output row per row in the input entity_df, regardless of whether some rows share a join key and event timestamp with other rows...

Opengraph URL: https://github.com/feast-dev/feast/issues/6787

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"get_historical_features (Dask/File) silently drops entity_df rows sharing a join key and timestamp","articleBody":"## Expected Behavior\n\nget_historical_features() should return exactly one output row per row in the input entity_df, regardless of whether some rows share a join key and event timestamp with other rows. Two entity_df rows with the same (join key, timestamp) but different other columns are distinct requests, not duplicates - e.g. two orders placed by the same customer in the same logged second.\n\n## Current Behavior\n\nOn the Dask/File offline store, entity_df rows that share a join key and event timestamp are silently collapsed into one, discarding every other column of the dropped rows (labels, order ids, anything the caller attached to the request).\n\nThe DuckDB offline store, and every SQL-based offline store (BigQuery, Snowflake, Redshift, Postgres, Spark, ClickHouse, Trino, Couchbase, Athena), already avoid this by carrying a per-row \"entity_row_unique_id\" through their generated queries. Dask/File has no equivalent, so it is the only backend where this data loss happens.\n\n## Steps to reproduce\n\nBuild an entity_df with 3 rows for get_historical_features: two rows share the same join key and event_timestamp but have different values in another column (e.g. an order_id and a label), and a third row is a different entity. Call get_historical_features() against a Dask/File-backed FeatureStore. The result has only 2 rows - one of the two same-timestamp rows is missing along with its order_id and label. Running the identical entity_df against a DuckDB-backed offline store returns all 3 rows correctly.\n\n### Specifications\n\n- Version: master\n- Platform: any (Dask/File offline store specifically; DuckDB and SQL-based stores are unaffected)\n- Subsystem: offline store / historical retrieval\n\n## Possible Solution\n\nTag each entity_df row with a synthetic unique id before the per-feature-view join in dask.py, and deduplicate on that id instead of (join keys, event timestamp) - mirroring the entity_row_unique_id technique already used by the SQL-based offline stores. Submitted as a PR alongside this issue.\n\n\nFIX:- #6786 ","author":{"url":"https://github.com/piyush182004","@type":"Person","name":"piyush182004"},"datePublished":"2026-08-26T05:15:30Z","url":"https://github.com/feast-dev/feast/issues/6787"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6b732ba4-e342-ebf8-d3de-7a727b4a7382
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id80B4:C7386:E54482:1381FBD:6AFE922E
html-safe-nonce8421f0347a41fc9e9b21b75931da012d39fbb2e45601acc077f0ae17a48fd443
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEI0OkM3Mzg2OkU1NDQ4MjoxMzgxRkJEOjZBRkU5MjJFIiwidmlzaXRvcl9pZCI6IjI5NjUxMDczMDUzOTUxNjM2OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac83f3c1c0bd0bf5712473ce234b0d318017f1b359690c27ea3f3088cee0cc8aeb
hovercard-subject-tagissue:5253591736
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/6787/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ade0a03e534fb34a3b997ad69cecec70422bc8b4a26637b6adb864b9d32c7c22/feast-dev/feast/issues/6787
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ade0a03e534fb34a3b997ad69cecec70422bc8b4a26637b6adb864b9d32c7c22/feast-dev/feast/issues/6787
og:image:altExpected Behavior get_historical_features() should return exactly one output row per row in the input entity_df, regardless of whether some rows share a join key and event timestamp with other rows...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepiyush182004
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/6787#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6787
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6787
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/6787
Reloadhttps://github.com/feast-dev/feast/issues/6787
Reloadhttps://github.com/feast-dev/feast/issues/6787
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6787
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6787
get_historical_features (Dask/File) silently drops entity_df rows sharing a join key and timestamphttps://github.com/feast-dev/feast/issues/6787#top
kind/bughttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Fbug%22
priority/p2https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22priority%2Fp2%22
https://github.com/piyush182004
piyush182004https://github.com/piyush182004
on Aug 26, 2026https://github.com/feast-dev/feast/issues/6787#issue-5253591736
#6786https://github.com/feast-dev/feast/pull/6786
piyush182004https://github.com/piyush182004
kind/bughttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Fbug%22
priority/p2https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22priority%2Fp2%22
on Aug 26, 2026https://github.com/feast-dev/feast/issues/6787#event-30022520024
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/6787
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6787
kind/bughttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Fbug%22
priority/p2https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22priority%2Fp2%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.