Title: get_historical_features (Dask/File) silently drops entity_df rows sharing a join key and timestamp · Issue #6787 · feast-dev/feast · GitHub
Open Graph Title: get_historical_features (Dask/File) silently drops entity_df rows sharing a join key and timestamp · Issue #6787 · feast-dev/feast
X Title: get_historical_features (Dask/File) silently drops entity_df rows sharing a join key and timestamp · Issue #6787 · feast-dev/feast
Description: Expected Behavior get_historical_features() should return exactly one output row per row in the input entity_df, regardless of whether some rows share a join key and event timestamp with other rows. Two entity_df rows with the same (join...
Open Graph Description: Expected Behavior get_historical_features() should return exactly one output row per row in the input entity_df, regardless of whether some rows share a join key and event timestamp with other rows...
X Description: Expected Behavior get_historical_features() should return exactly one output row per row in the input entity_df, regardless of whether some rows share a join key and event timestamp with other rows...
Opengraph URL: https://github.com/feast-dev/feast/issues/6787
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"get_historical_features (Dask/File) silently drops entity_df rows sharing a join key and timestamp","articleBody":"## Expected Behavior\n\nget_historical_features() should return exactly one output row per row in the input entity_df, regardless of whether some rows share a join key and event timestamp with other rows. Two entity_df rows with the same (join key, timestamp) but different other columns are distinct requests, not duplicates - e.g. two orders placed by the same customer in the same logged second.\n\n## Current Behavior\n\nOn the Dask/File offline store, entity_df rows that share a join key and event timestamp are silently collapsed into one, discarding every other column of the dropped rows (labels, order ids, anything the caller attached to the request).\n\nThe DuckDB offline store, and every SQL-based offline store (BigQuery, Snowflake, Redshift, Postgres, Spark, ClickHouse, Trino, Couchbase, Athena), already avoid this by carrying a per-row \"entity_row_unique_id\" through their generated queries. Dask/File has no equivalent, so it is the only backend where this data loss happens.\n\n## Steps to reproduce\n\nBuild an entity_df with 3 rows for get_historical_features: two rows share the same join key and event_timestamp but have different values in another column (e.g. an order_id and a label), and a third row is a different entity. Call get_historical_features() against a Dask/File-backed FeatureStore. The result has only 2 rows - one of the two same-timestamp rows is missing along with its order_id and label. Running the identical entity_df against a DuckDB-backed offline store returns all 3 rows correctly.\n\n### Specifications\n\n- Version: master\n- Platform: any (Dask/File offline store specifically; DuckDB and SQL-based stores are unaffected)\n- Subsystem: offline store / historical retrieval\n\n## Possible Solution\n\nTag each entity_df row with a synthetic unique id before the per-feature-view join in dask.py, and deduplicate on that id instead of (join keys, event timestamp) - mirroring the entity_row_unique_id technique already used by the SQL-based offline stores. Submitted as a PR alongside this issue.\n\n\nFIX:- #6786 ","author":{"url":"https://github.com/piyush182004","@type":"Person","name":"piyush182004"},"datePublished":"2026-08-26T05:15:30Z","url":"https://github.com/feast-dev/feast/issues/6787"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6b732ba4-e342-ebf8-d3de-7a727b4a7382 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 80B4:C7386:E54482:1381FBD:6AFE922E |
| html-safe-nonce | 8421f0347a41fc9e9b21b75931da012d39fbb2e45601acc077f0ae17a48fd443 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEI0OkM3Mzg2OkU1NDQ4MjoxMzgxRkJEOjZBRkU5MjJFIiwidmlzaXRvcl9pZCI6IjI5NjUxMDczMDUzOTUxNjM2OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 83f3c1c0bd0bf5712473ce234b0d318017f1b359690c27ea3f3088cee0cc8aeb |
| hovercard-subject-tag | issue:5253591736 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/6787/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ade0a03e534fb34a3b997ad69cecec70422bc8b4a26637b6adb864b9d32c7c22/feast-dev/feast/issues/6787 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ade0a03e534fb34a3b997ad69cecec70422bc8b4a26637b6adb864b9d32c7c22/feast-dev/feast/issues/6787 |
| og:image:alt | Expected Behavior get_historical_features() should return exactly one output row per row in the input entity_df, regardless of whether some rows share a join key and event timestamp with other rows... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | piyush182004 |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width