René's URL Explorer Experiment


Title: What is _validate_token meant to verify in the OIDC token parser? · Issue #6688 · feast-dev/feast · GitHub

Open Graph Title: What is _validate_token meant to verify in the OIDC token parser? · Issue #6688 · feast-dev/feast

X Title: What is _validate_token meant to verify in the OIDC token parser? · Issue #6688 · feast-dev/feast

Description: Question What is OidcTokenParser._validate_token intended to verify? As written it cannot reject any token, but it reads like a security gate and logs as though one passed, so I would rather ask than assume it is dead code. What it does ...

Open Graph Description: Question What is OidcTokenParser._validate_token intended to verify? As written it cannot reject any token, but it reads like a security gate and logs as though one passed, so I would rather ask th...

X Description: Question What is OidcTokenParser._validate_token intended to verify? As written it cannot reject any token, but it reads like a security gate and logs as though one passed, so I would rather ask th...

Opengraph URL: https://github.com/feast-dev/feast/issues/6688

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"What is _validate_token meant to verify in the OIDC token parser?","articleBody":"## Question\n\nWhat is `OidcTokenParser._validate_token` intended to verify? As written it cannot reject any token, but it reads like a security gate and logs as though one passed, so I would rather ask than assume it is dead code.\n\n## What it does today\n\n[`_validate_token`](https://github.com/feast-dev/feast/blob/3a6a1031ac501c715b6d7aaf6d6aa3cee25c5367/sdk/python/feast/permissions/auth/oidc_token_parser.py#L45-L60) builds a mock request, sets `Authorization: Bearer \u003ctoken>` on it from the token it was handed, and awaits `OAuth2AuthorizationCodeBearer`. That scheme only parses the header and returns the token; it never inspects the value. Since the method supplies the header itself, the check always succeeds.\n\nVerified against the installed fastapi (0.139.2) — every one of these is accepted, including the empty string:\n\n```\n''            -> ACCEPTED ''\n'   '         -> ACCEPTED ''\n'garbage'     -> ACCEPTED 'garbage'\n'a.b.c'       -> ACCEPTED 'a.b.c'\n```\n\nThe caller then logs success:\n\n```python\nawait self._validate_token(access_token)\nlogger.debug(\"Token successfully validated.\")\n```\n\nReal verification happens afterwards in `_decode_token`, which fetches the JWKS signing key and calls `jwt.decode`. So the token is genuinely validated, just not here. My concern is that the method name, the docstring (\"Validate the token ... against the OAuth2 server\"), and that log line together suggest a verification step that does not exist, which is the kind of thing that misleads a future reader auditing the auth path.\n\n## The one thing it does affect\n\nConstructing the scheme reads `token_endpoint` and `authorization_endpoint` from the discovery document, so a discovery document **missing** `token_endpoint` raises a `ValidationError` and the request fails (an empty string passes). That is the only input that can make this method fail.\n\nWorth noting the server-side validation path itself never needs a token endpoint — it only needs `jwks_uri`. So this effectively requires a discovery field that Feast's own token validation does not use. It also does not trigger anything that would otherwise be skipped: `_decode_token` reaches the same lazily-fetched discovery data via `get_jwks_url()`.\n\n## Why I am asking rather than sending a patch\n\nRemoving the call would be a behavior change for anyone whose provider omits `token_endpoint` (they would go from failing to working), and it is the only `await` on this branch of the OIDC path, which matters if the blocking JWKS work is ever moved to a thread. Both seem like your call rather than mine.\n\nRoughly the options I see:\n\n1. It is vestigial, and the call plus the misleading log line can go.\n2. The discovery-document shape check is wanted, in which case it would be clearer done once at parser construction rather than per request, and against the fields actually required.\n3. It was meant to do something else entirely (introspection against the provider?) and never did, in which case that is the real issue.\n\nHappy to send a PR for whichever you prefer. Not urgent, and the per-request cost is small; this is about the auth path saying it does something it does not.\n","author":{"url":"https://github.com/larrysingleton007","@type":"Person","name":"larrysingleton007"},"datePublished":"2026-07-31T19:10:28Z","url":"https://github.com/feast-dev/feast/issues/6688"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:95d5ce3d-bab9-1daf-0154-0ab8e840a9f4
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9C44:2D9CF4:115F789:16F65BC:6AFEA265
html-safe-nonce42d4746f3f13e4cfb01d1c8edac79eaa0ad34535f0735a5cce96edfd7e880cef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzQ0OjJEOUNGNDoxMTVGNzg5OjE2RjY1QkM6NkFGRUEyNjUiLCJ2aXNpdG9yX2lkIjoiNDc5MjcxMDYwMjQ2MTk3OTIzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc213f98f8624693a1737c8cb33ea303e040e82aefa1f7cef54d7a217b6d841c3
hovercard-subject-tagissue:5032620729
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/6688/issue_layout
twitter:imagehttps://opengraph.githubassets.com/76f3216e8d6a4f60e95a18f7cd371681b0e0f0cbf52ec2f3499cd0f4ce755948/feast-dev/feast/issues/6688
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/76f3216e8d6a4f60e95a18f7cd371681b0e0f0cbf52ec2f3499cd0f4ce755948/feast-dev/feast/issues/6688
og:image:altQuestion What is OidcTokenParser._validate_token intended to verify? As written it cannot reject any token, but it reads like a security gate and logs as though one passed, so I would rather ask th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelarrysingleton007
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/6688#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6688
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6688
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/6688
Reloadhttps://github.com/feast-dev/feast/issues/6688
Reloadhttps://github.com/feast-dev/feast/issues/6688
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6688
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6688
What is _validate_token meant to verify in the OIDC token parser?https://github.com/feast-dev/feast/issues/6688#top
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
on Jul 31, 2026https://github.com/feast-dev/feast/issues/6688#issue-5032620729
_validate_tokenhttps://github.com/feast-dev/feast/blob/3a6a1031ac501c715b6d7aaf6d6aa3cee25c5367/sdk/python/feast/permissions/auth/oidc_token_parser.py#L45-L60
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
on Jul 31, 2026https://github.com/feast-dev/feast/issues/6688#issuecomment-5146772652
#6689https://github.com/feast-dev/feast/pull/6689
ntkatholehttps://github.com/ntkathole
on Aug 14, 2026https://github.com/feast-dev/feast/issues/6688#event-29439464539
docs: Correct what _validate_token claims to dohttps://github.com/larrysingleton007/feast/commit/c64bb4a5ec50910da829f6ce65d7ee41a456cd0c
c64bb4ahttps://github.com/larrysingleton007/feast/commit/c64bb4a5ec50910da829f6ce65d7ee41a456cd0c
docs: Correct what _validate_token claims to do (#6689)https://github.com/feast-dev/feast/commit/7278dcf6c61ed62da7fe7a239712af5946dc2102
#6689https://github.com/feast-dev/feast/pull/6689
7278dcfhttps://github.com/feast-dev/feast/commit/7278dcf6c61ed62da7fe7a239712af5946dc2102
HSarwathttps://github.com/HSarwat
on Aug 22, 2026https://github.com/feast-dev/feast/issues/6688#event-29844848870
docs: Correct what _validate_token claims to do (feast-dev#6689)https://github.com/HSarwat/feast/commit/3062505cf3463421d607a733eb4d69ee77fdde11
feast-dev#6689https://github.com/feast-dev/feast/pull/6689
3062505https://github.com/HSarwat/feast/commit/3062505cf3463421d607a733eb4d69ee77fdde11
Michie-hubhttps://github.com/Michie-hub
on Aug 31, 2026https://github.com/feast-dev/feast/issues/6688#event-30282803869
docs: Correct what _validate_token claims to do (feast-dev#6689)https://github.com/Michie-hub/feast/commit/c8f3561f3e2d661c7a5c5aeb8e7c96a4b58c91d3
feast-dev#6689https://github.com/feast-dev/feast/pull/6689
c8f3561https://github.com/Michie-hub/feast/commit/c8f3561f3e2d661c7a5c5aeb8e7c96a4b58c91d3
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/6688
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6688
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.