Title: Move TFDV stats fields on FeatureSpec proto to higher-numbered fields · Issue #667 · feast-dev/feast · GitHub
Open Graph Title: Move TFDV stats fields on FeatureSpec proto to higher-numbered fields · Issue #667 · feast-dev/feast
X Title: Move TFDV stats fields on FeatureSpec proto to higher-numbered fields · Issue #667 · feast-dev/feast
Description: As discussed at #655 (comment) and according to protobuf spec guidance: …field numbers in the range 1 through 15 take one byte to encode, including the field number and the field's type (you can find out more about this in Protocol Buffe...
Open Graph Description: As discussed at #655 (comment) and according to protobuf spec guidance: …field numbers in the range 1 through 15 take one byte to encode, including the field number and the field's type (you can fi...
X Description: As discussed at #655 (comment) and according to protobuf spec guidance: …field numbers in the range 1 through 15 take one byte to encode, including the field number and the field's type (you ca...
Opengraph URL: https://github.com/feast-dev/feast/issues/667
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Move TFDV stats fields on FeatureSpec proto to higher-numbered fields","articleBody":"As discussed at https://github.com/gojek/feast/pull/655#issuecomment-622266317 and according to [protobuf spec guidance][1]:\r\n\r\n\u003e …field numbers in the range 1 through 15 take one byte to encode, including the field number and the field's type (you can find out more about this in Protocol Buffer Encoding). Field numbers in the range 16 through 2047 take two bytes. So you should reserve the numbers 1 through 15 for very frequently occurring message elements. Remember to leave some room for frequently occurring elements that might be added in the future.\r\n\r\nAlthough `FeatureSpec` is registry (meta)data that is not used in high-throughput RPCs or Kafka messages currently, it doesn't seem like a bad idea to move the TFDV stats and reserve low-number fields while we can. The cost is low.\r\n\r\n[1]: https://developers.google.com/protocol-buffers/docs/proto3#assigning-field-numbers","author":{"url":"https://github.com/ches","@type":"Person","name":"ches"},"datePublished":"2020-05-01T06:49:37.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/667/feast/issues/667"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a0fae2db-facc-374b-5c21-62e31116b3d0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8784:332E83:208A2FD:2B4AB1B:697C3ECE |
| html-safe-nonce | 0096a2b82530df8816fff374eec79ef20a574a5426d8768d02f72c9ceecc5fb3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Nzg0OjMzMkU4MzoyMDhBMkZEOjJCNEFCMUI6Njk3QzNFQ0UiLCJ2aXNpdG9yX2lkIjoiMjUzNTg0MjM3MDg1OTg0MzI3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 09e89405f179026889f472e742dc15e940f0106246a0a9a9b93d9bf29c17bf42 |
| hovercard-subject-tag | issue:610599157 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/667/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ab80a29125ad5df860cc0ffc9bf887cacf3d690d9d87de4796e9a17420d549a8/feast-dev/feast/issues/667 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ab80a29125ad5df860cc0ffc9bf887cacf3d690d9d87de4796e9a17420d549a8/feast-dev/feast/issues/667 |
| og:image:alt | As discussed at #655 (comment) and according to protobuf spec guidance: …field numbers in the range 1 through 15 take one byte to encode, including the field number and the field's type (you can fi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ches |
| hostname | github.com |
| expected-hostname | github.com |
| None | da4f0ee56809799586f8ee546b27f94fe9b5893edfbf87732e82be45be013b52 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 787d8d274e314f52ce6d846c7581f9476d8dc736 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width