René's URL Explorer Experiment


Title: OIDC token parser never verifies audience or issuer · Issue #6669 · feast-dev/feast · GitHub

Open Graph Title: OIDC token parser never verifies audience or issuer · Issue #6669 · feast-dev/feast

X Title: OIDC token parser never verifies audience or issuer · Issue #6669 · feast-dev/feast

Description: The observation The feature server's OIDC token parser verifies the token signature (JWKS via discovery) and expiry, but audience verification is explicitly off and there is no issuer check (sdk/python/feast/permissions/auth/oidc_token_p...

Open Graph Description: The observation The feature server's OIDC token parser verifies the token signature (JWKS via discovery) and expiry, but audience verification is explicitly off and there is no issuer check (sdk/py...

X Description: The observation The feature server's OIDC token parser verifies the token signature (JWKS via discovery) and expiry, but audience verification is explicitly off and there is no issuer check (sd...

Opengraph URL: https://github.com/feast-dev/feast/issues/6669

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"OIDC token parser never verifies audience or issuer","articleBody":"## The observation\n\nThe feature server's OIDC token parser verifies the token signature (JWKS via discovery) and expiry, but audience verification is explicitly off and there is no issuer check (`sdk/python/feast/permissions/auth/oidc_token_parser.py`, `_decode_token`):\n\n```python\naudience=\"account\",\noptions={\n    \"verify_aud\": False,\n    \"verify_signature\": True,\n    \"verify_exp\": True,\n},\n```\n\nThe consequence is that any validly-signed, unexpired token from the configured IdP authenticates against the feature server, regardless of which resource it was minted for. In a multi-app tenant, a token issued to a completely different application passes authentication, and role matching in `RoleBasedPolicy` is the only remaining gate. Authorization ends up doing all of the work; authentication is only proving the token came from the right IdP, not that it was meant for Feast.\n\n## Why the current default is reasonable\n\nThis looks deliberate, and changing the default would break real deployments. Identity providers commonly put claim values in tokens that differ from their discovery metadata. The clearest case is Microsoft Entra ID, which issues v1.0 tokens (`iss: https://sts.windows.net/\u003ctenant-id>/`, `aud: api://\u003capp-id-uri>`) that are routinely validated against a v2.0 discovery URL. That works today precisely because discovery is only used to source JWKS keys and no `aud`/`iss` comparison runs. #6631 added Entra support on top of that behavior, so this is proposing configurability, not calling the default a bug.\n\n## Proposal\n\nTwo optional `OidcAuthConfig` fields, `audience` and `issuer`, both unset by default:\n\n- When set, the corresponding token claim must match or the token is rejected at authentication.\n- When unset, the decode options are identical to today's, so nobody is affected without opting in.\n- Operators state the expected values explicitly rather than the code inferring them from the discovery document, which is what keeps the v1-token-against-v2-discovery setup working.\n\nThe accompanying PR includes a test that pins the v1/v2 Entra setup so a future refactor cannot silently regress it.\n\nOne scope note: the feast-operator copies a whitelist of OIDC secret keys into the generated `feature_store.yaml` (`OidcOptionalSecretProperties`), so exposing these fields through the operator CRD would be a small follow-up if there is interest. The PR keeps to the Python SDK and docs.\n","author":{"url":"https://github.com/larrysingleton007","@type":"Person","name":"larrysingleton007"},"datePublished":"2026-07-30T13:56:57Z","url":"https://github.com/feast-dev/feast/issues/6669"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ce4cd2c9-c7c4-8df9-78fc-98813ca1b66e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE7B6:19DC88:EE3978:146C831:6AFE981C
html-safe-nonceeaf3bf0c3ff5bb0c3d579ba348e16ca2b4054d45df30de94a4d04077c06d98b1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0I2OjE5REM4ODpFRTM5Nzg6MTQ2QzgzMTo2QUZFOTgxQyIsInZpc2l0b3JfaWQiOiIzNTEyMjUxNjQ2MDIzMjExMDM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6396f8df2ef8223ccf5684e36efc4d9f5a7e09095d479f03e20f932568222fea
hovercard-subject-tagissue:5020484934
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/6669/issue_layout
twitter:imagehttps://opengraph.githubassets.com/02acc20ff6d168de4302604e4bd70873435c4ffe8d2716188a57683ddd381eee/feast-dev/feast/issues/6669
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/02acc20ff6d168de4302604e4bd70873435c4ffe8d2716188a57683ddd381eee/feast-dev/feast/issues/6669
og:image:altThe observation The feature server's OIDC token parser verifies the token signature (JWKS via discovery) and expiry, but audience verification is explicitly off and there is no issuer check (sdk/py...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelarrysingleton007
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/6669#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6669
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6669
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/6669
Reloadhttps://github.com/feast-dev/feast/issues/6669
Reloadhttps://github.com/feast-dev/feast/issues/6669
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6669
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6669
#6670https://github.com/feast-dev/feast/pull/6670
OIDC token parser never verifies audience or issuerhttps://github.com/feast-dev/feast/issues/6669#top
#6670https://github.com/feast-dev/feast/pull/6670
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
on Jul 30, 2026https://github.com/feast-dev/feast/issues/6669#issue-5020484934
#6631https://github.com/feast-dev/feast/pull/6631
ntkatholehttps://github.com/ntkathole
completedhttps://github.com/feast-dev/feast/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#6670https://github.com/feast-dev/feast/pull/6670
on Jul 30, 2026https://github.com/feast-dev/feast/issues/6669#event-28729285589
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/6669
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6669
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.