René's URL Explorer Experiment


Title: sqlite.py's OnlineStore.plan() raises typeguard.TypeCheckError for stream feature views · Issue #6658 · feast-dev/feast · GitHub

Open Graph Title: sqlite.py's OnlineStore.plan() raises typeguard.TypeCheckError for stream feature views · Issue #6658 · feast-dev/feast

X Title: sqlite.py's OnlineStore.plan() raises typeguard.TypeCheckError for stream feature views · Issue #6658 · feast-dev/feast

Description: Expected Behavior feast plan (or any OnlineStore.plan() implementation that follows the same pattern as SqliteOnlineStore.plan()) should work the same way whether the registry contains regular feature views, streaming feature views, or b...

Open Graph Description: Expected Behavior feast plan (or any OnlineStore.plan() implementation that follows the same pattern as SqliteOnlineStore.plan()) should work the same way whether the registry contains regular feat...

X Description: Expected Behavior feast plan (or any OnlineStore.plan() implementation that follows the same pattern as SqliteOnlineStore.plan()) should work the same way whether the registry contains regular feat...

Opengraph URL: https://github.com/feast-dev/feast/issues/6658

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"sqlite.py's OnlineStore.plan() raises typeguard.TypeCheckError for stream feature views","articleBody":"## Expected Behavior\n\n`feast plan` (or any `OnlineStore.plan()` implementation that follows the same pattern as `SqliteOnlineStore.plan()`) should work the same way whether the registry contains regular feature views, streaming feature views, or both.\n\n## Current Behavior\n\nFeast has two kinds of feature views: regular ones (`FeatureView`) and streaming ones (`StreamFeatureView`, for Kafka-style sources). Under the hood, each is a distinct protobuf message type — `FeatureViewProto` vs `StreamFeatureViewProto`. They're similar in shape, but not interchangeable.\n\n`SqliteOnlineStore.plan()` loops over every feature view in the registry — both kinds together — and reconstructs each one with the same call ([sdk/python/feast/infra/online_stores/sqlite.py](https://github.com/feast-dev/feast/blob/v0.65.0/sdk/python/feast/infra/online_stores/sqlite.py#L318-L337)):\n\n```python\ndef plan(\n    self, config: RepoConfig, desired_registry_proto: RegistryProto\n) -> List[InfraObject]:\n    ...\n    infra_objects: List[InfraObject] = [\n        SqliteTable(\n            path=self._get_db_path(config),\n            name=_table_id(project, FeatureView.from_proto(view), versioning),\n        )\n        for view in [\n            *desired_registry_proto.feature_views,\n            *desired_registry_proto.stream_feature_views,\n        ]\n    ]\n```\n\n`FeatureView.from_proto()` is guarded by a runtime type checker (`typeguard`, via `@typechecked` on the class — [sdk/python/feast/feature_view.py#L110-L111](https://github.com/feast-dev/feast/blob/v0.65.0/sdk/python/feast/feature_view.py#L110-L111)) that only accepts a `FeatureViewProto`. It works fine for the `feature_views` list. But when the loop reaches an entry from `stream_feature_views`, it hands over a `StreamFeatureViewProto` — the wrong type for that function — and typeguard raises:\n\n```\ntypeguard.TypeCheckError: argument \"feature_view_proto\" (feast.core.StreamFeatureView_pb2.StreamFeatureView) is not an instance of feast.core.FeatureView_pb2.FeatureView\n```\n\nIn short: `plan()` calls the wrong reconstruction function on the wrong kind of feature view, so it crashes for any repo that has at least one `StreamFeatureView` registered — a fairly common setup, not an edge case.\n\nWe ran into this adding `plan()`/`InfraObject` support to a custom DynamoDB online store (the stock `DynamoDBOnlineStore.plan()` is just the no-op default and never triggers this) and initially copied `sqlite.py`'s pattern as the reference implementation, since it's the only in-tree store that implements `plan()`.\n\n## Steps to reproduce\n\n```python\nfrom feast import FileSource\nfrom feast.data_format import JsonFormat\nfrom feast.data_source import KafkaSource\nfrom feast.stream_feature_view import StreamFeatureView\nfrom feast.infra.online_stores.sqlite import SqliteOnlineStore\nfrom feast.protos.feast.core.Registry_pb2 import Registry as RegistryProto\nfrom feast.repo_config import RepoConfig\n\nconfig = RepoConfig(project=\"p\", registry=\"/tmp/x.db\", provider=\"local\", online_store=\"sqlite\")\n\nstream_fv = StreamFeatureView(\n    name=\"driver_dropoffs_stream\",\n    entities=[],\n    schema=[],\n    source=KafkaSource(\n        name=\"k\",\n        timestamp_field=\"event_timestamp\",\n        message_format=JsonFormat(schema_json=\"\"),\n        kafka_bootstrap_servers=\"localhost:9092\",\n        topic=\"t\",\n        batch_source=FileSource(path=\"dummy.parquet\", timestamp_field=\"event_timestamp\"),\n    ),\n)\n\nregistry_proto = RegistryProto()\nregistry_proto.stream_feature_views.append(stream_fv.to_proto())\n\nSqliteOnlineStore().plan(config, registry_proto)  # raises typeguard.TypeCheckError\n```\n\nFull traceback:\n\n```\nTraceback (most recent call last):\n  File \"repro.py\", line 28, in \u003cmodule>\n    SqliteOnlineStore().plan(config, registry_proto)\n  File \".../feast/infra/online_stores/sqlite.py\", line 321, in plan\n    infra_objects: List[InfraObject] = [\n                                       ^\n  File \".../feast/infra/online_stores/sqlite.py\", line 326, in \u003clistcomp>\n    FeatureView.from_proto(view),\n    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \".../feast/feature_view.py\", line 523, in from_proto\n    def from_proto(cls, feature_view_proto: FeatureViewProto) -> \"FeatureView\":\n  File \".../typeguard/_functions.py\", line 180, in check_argument_types_internal\n    check_type_internal(value, annotation, memo)\n  File \".../typeguard/_checkers.py\", line 994, in check_type_internal\n    raise TypeCheckError(f\"is not an instance of {qualified_name(origin_type)}\")\ntypeguard.TypeCheckError: argument \"feature_view_proto\" (feast.core.StreamFeatureView_pb2.StreamFeatureView) is not an instance of feast.core.FeatureView_pb2.FeatureView\n```\n\n### Specifications\n\n- Version: reproduced on 0.62.0 (installed via `pip install feast==0.62.0`); confirmed the same code pattern is still present on `v0.65.0` (latest tag) as of this report.\n- Platform: macOS, Python 3.11\n- Subsystem: online store / `feast plan` / registry\n\n## Possible Solution\n\nUse the matching class for each list instead of `FeatureView.from_proto()` for both:\n\n```python\nviews = [\n    FeatureView.from_proto(view) for view in desired_registry_proto.feature_views\n] + [\n    StreamFeatureView.from_proto(view) for view in desired_registry_proto.stream_feature_views\n]\n```\n\nOpened a PR with this fix: #6659","author":{"url":"https://github.com/casaar97","@type":"Person","name":"casaar97"},"datePublished":"2026-07-29T12:18:48Z","url":"https://github.com/feast-dev/feast/issues/6658"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:79f154de-4057-a0f2-be6a-829c11a47411
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE7D6:A7C4D:F0DF44:14915E0:6AFE981E
html-safe-noncefcfb8c4b056115a8a2948e074e56b2ccf70a9732d7404898a5d26e0aa8e13212
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0Q2OkE3QzREOkYwREY0NDoxNDkxNUUwOjZBRkU5ODFFIiwidmlzaXRvcl9pZCI6IjE3NTU4ODgxMzM5NzY1Mjg5MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7e648e6de7f25ae730d7e5fd6c8c63936e5e890fe3993cab089d3925d22a76b6
hovercard-subject-tagissue:5009138666
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/6658/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ae3c1ed9d407070d64578dd4795ebca13652513145388fbeedfe0e74cee39ab3/feast-dev/feast/issues/6658
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ae3c1ed9d407070d64578dd4795ebca13652513145388fbeedfe0e74cee39ab3/feast-dev/feast/issues/6658
og:image:altExpected Behavior feast plan (or any OnlineStore.plan() implementation that follows the same pattern as SqliteOnlineStore.plan()) should work the same way whether the registry contains regular feat...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecasaar97
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/6658#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6658
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F6658
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/6658
Reloadhttps://github.com/feast-dev/feast/issues/6658
Reloadhttps://github.com/feast-dev/feast/issues/6658
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6658
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6658
#6659https://github.com/feast-dev/feast/pull/6659
sqlite.py's OnlineStore.plan() raises typeguard.TypeCheckError for stream feature viewshttps://github.com/feast-dev/feast/issues/6658#top
#6659https://github.com/feast-dev/feast/pull/6659
https://github.com/casaar97
casaar97https://github.com/casaar97
on Jul 29, 2026https://github.com/feast-dev/feast/issues/6658#issue-5009138666
sdk/python/feast/infra/online_stores/sqlite.pyhttps://github.com/feast-dev/feast/blob/v0.65.0/sdk/python/feast/infra/online_stores/sqlite.py#L318-L337
sdk/python/feast/feature_view.py#L110-L111https://github.com/feast-dev/feast/blob/v0.65.0/sdk/python/feast/feature_view.py#L110-L111
#6659https://github.com/feast-dev/feast/pull/6659
casaar97https://github.com/casaar97
on Jul 29, 2026https://github.com/feast-dev/feast/issues/6658#event-28659769933
fix: use matching proto class per feature view list in SqliteOnlineSt…https://github.com/casaar97/feast/commit/47550c846514bfe3824299bd4864b9ba70db7548
https://docs.github.com/articles/closing-issues-via-commit-messages
47550c8https://github.com/casaar97/feast/commit/47550c846514bfe3824299bd4864b9ba70db7548
fix: use matching proto class per feature view list in SqliteOnlineSt…https://github.com/casaar97/feast/commit/86cf6769effa3437fb5ae2394458ce9698c3fd23
https://docs.github.com/articles/closing-issues-via-commit-messages
86cf676https://github.com/casaar97/feast/commit/86cf6769effa3437fb5ae2394458ce9698c3fd23
ntkatholehttps://github.com/ntkathole
on Jul 30, 2026https://github.com/feast-dev/feast/issues/6658#event-28700771184
feat: add plan() support to DynamoDBOnlineStorehttps://github.com/feast-dev/feast/commit/51ce982ae6a662e4c492a361fbfc8dc01fffb41b
51ce982https://github.com/feast-dev/feast/commit/51ce982ae6a662e4c492a361fbfc8dc01fffb41b
fix: use matching proto class per feature view list in SqliteOnlineSt…https://github.com/casaar97/feast/commit/d97289166d0a0139bd19459a9dd0f03a5c001b38
d972891https://github.com/casaar97/feast/commit/d97289166d0a0139bd19459a9dd0f03a5c001b38
ntkatholehttps://github.com/ntkathole
completedhttps://github.com/feast-dev/feast/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#6659https://github.com/feast-dev/feast/pull/6659
on Jul 30, 2026https://github.com/feast-dev/feast/issues/6658#event-28701046044
ntkatholehttps://github.com/ntkathole
on Jul 30, 2026https://github.com/feast-dev/feast/issues/6658#event-28701060561
fix: use matching proto class per feature view list in SqliteOnlineSt…https://github.com/adarshsm/feast/commit/adb8c1c960ec37fe1b90bb114a13902adf2f9c44
https://docs.github.com/articles/closing-issues-via-commit-messages
adb8c1chttps://github.com/adarshsm/feast/commit/adb8c1c960ec37fe1b90bb114a13902adf2f9c44
franciscojavierarceohttps://github.com/franciscojavierarceo
on Aug 21, 2026https://github.com/feast-dev/feast/issues/6658#event-29781435042
chore(release): release 0.66.0https://github.com/feast-dev/feast/commit/1d5be950cf718a674cb01eaf0fd0ad6f0a4c6335
1d5be95https://github.com/feast-dev/feast/commit/1d5be950cf718a674cb01eaf0fd0ad6f0a4c6335
Michie-hubhttps://github.com/Michie-hub
on Aug 31, 2026https://github.com/feast-dev/feast/issues/6658#event-30282808256
chore(release): release 0.66.0https://github.com/Michie-hub/feast/commit/a29c9231976fd7c68e51570047f9517f06579041
a29c923https://github.com/Michie-hub/feast/commit/a29c9231976fd7c68e51570047f9517f06579041
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/6658
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/6658
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.