Title: when calling for several ODFVs at once, only fetches one ODFV's column-list per shared source view (last request wins), · Issue #6621 · feast-dev/feast · GitHub
Open Graph Title: when calling for several ODFVs at once, only fetches one ODFV's column-list per shared source view (last request wins), · Issue #6621 · feast-dev/feast
X Title: when calling for several ODFVs at once, only fetches one ODFV's column-list per shared source view (last request wins), · Issue #6621 · feast-dev/feast
Description: Expected Behavior When several on demand feature views share a source feature view but use different input columns, feature resolution should produce one entry for the shared source view whose projection contains the union of the require...
Open Graph Description: Expected Behavior When several on demand feature views share a source feature view but use different input columns, feature resolution should produce one entry for the shared source view whose proj...
X Description: Expected Behavior When several on demand feature views share a source feature view but use different input columns, feature resolution should produce one entry for the shared source view whose proj...
Opengraph URL: https://github.com/feast-dev/feast/issues/6621
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"when calling for several ODFVs at once, only fetches one ODFV's column-list per shared source view (last request wins),","articleBody":"## Expected Behavior \n\nWhen several on demand feature views share a source feature view but use different input columns, feature resolution should produce one entry for the shared source view whose projection contains the union of the required input columns.\n\n## Current Behavior\n\n _get_feature_views_to_use appends the shared source view once per ODFV, each copy carrying only that ODFV's projection. The membership check if source_fv not in fvs_to_use never matches because BaseFeatureView.__eq__ compares projections, and the freshly fetched view (full projection) never equals a stored narrowed copy. Downstream, _group_feature_refs keys its view index by projection.name_to_use(), so the last duplicate wins and the other ODFVs' source projections are silently dropped.\n\nThis corrupts get_historical_features output: with a request containing only ODFV refs, the losing ODFVs' input columns are never fetched, so transforms receive missing inputs (NaN in pandas mode). We hit this in production on 0.46, where a downstream fillna(0) turned the missing inputs into silently wrong feature values on about 10% of rows.\n\nSince 0.62 the retrieval path is masked by the ref injection loop added in #6140, but the resolution helper still returns duplicate entries with conflicting projections to its other callers (_get_online_request_context, retrieve_online_documents, retrieve_online_documents_v2).\n\n\n## Steps to reproduce\n\n```\n src_fv = FeatureView(name=\"src_fv\", entities=[driver], schema=[Field(name=\"a\", dtype=Float64), Field(name=\"b\", dtype=Float64)], source=...)\n\n @on_demand_feature_view(sources=[src_fv[[\"a\"]]], schema=[Field(name=\"a_out\", dtype=Float64)], mode=\"pandas\")\n def odfv_a(inputs):\n @on_demand_feature_view(sources=[src_fv[[\"b\"]]], schema=[Field(name=\"b_out\", dtype=Float64)], mode=\"pandas\")\n def odfv_b(inputs):\n return pd.DataFrame({\"b_out\": inputs[\"b\"] + 100})\n\n fvs, _ = _get_feature_views_to_use(store.registry, store.project, [\"odfv_a:a_out\", \"odfv_b:b_out\"])\n # Actual: two src_fv entries with projections ['a'] and ['b']\n # Expected: one src_fv entry with projection ['a', 'b']\n```\n\n### Specifications\n\n- Version: master (also reproduced on 0.46; wrong retrieval values on 0.61 and earlier)\n- Platform: all\n- Subsystem: historical retrieval\n\n## Possible Solution\n\nIn _get_feature_views_to_use, match existing entries by projection.name_to_use() and merge projections (union of features, deduplicated by name) instead of appending a duplicate. \n\nRelated: #6099, #6140\n","author":{"url":"https://github.com/addenergyx","@type":"Person","name":"addenergyx"},"datePublished":"2026-07-21T21:05:40Z","url":"https://github.com/feast-dev/feast/issues/6621"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1a065590-2afb-cc08-1ce3-3bac9316b173 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9804:2530C8:FF25FE:15AEDB2:6AFE9820 |
| html-safe-nonce | 038bb66d583afb82c795dcb426439fa69832183a73fea62746a86801f51b0e05 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODA0OjI1MzBDODpGRjI1RkU6MTVBRURCMjo2QUZFOTgyMCIsInZpc2l0b3JfaWQiOiI1ODMwNjc5MjMxNTM2NzMyMTkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | af7eb8bfea4dae2f7daef0273103ebca426a5606706e6c5fb5c3af6d939b8b1a |
| hovercard-subject-tag | issue:4943094911 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/6621/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5b9ad8e8fe5e1a953f6db673c7c53ebb63ace505fceed34e8aa7bf7290f9a249/feast-dev/feast/issues/6621 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5b9ad8e8fe5e1a953f6db673c7c53ebb63ace505fceed34e8aa7bf7290f9a249/feast-dev/feast/issues/6621 |
| og:image:alt | Expected Behavior When several on demand feature views share a source feature view but use different input columns, feature resolution should produce one entry for the shared source view whose proj... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addenergyx |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width