René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Docker Compose setup is broken on master","articleBody":"## Expected Behavior\r\n\r\nFollowing https://docs.feast.dev/installation/docker-compose works successfully.\r\n\r\n## Current Behavior\r\n\r\nSpring configurations fail to wire, e.g.\r\n\r\n```\r\nonline-serving_1  | 2020-04-26 09:01:16.607  WARN 665e326fd6d8 --- [           main] ConfigServletWebServerApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'storeConfiguration' defined in URL [jar:file:/opt/feast/feast-serving.jar!/BOOT-INF/classes!/feast/serving/configuration/StoreConfiguration.class]: Bean instantiation via constructor failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [feast.serving.configuration.StoreConfiguration$$EnhancerBySpringCGLIB$$eb7624c6]: Constructor threw exception; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'servingRedisConnection' defined in class path resource [feast/serving/configuration/redis/ServingStoreRedisConfig.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [io.lettuce.core.api.StatefulRedisConnection]: Factory method 'servingRedisConnection' threw exception; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'servingRedisClient' defined in class path resource [feast/serving/configuration/redis/ServingStoreRedisConfig.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [io.lettuce.core.RedisClient]: Factory method 'servingRedisClient' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'servingStoreRedisConf' defined in class path resource [feast/serving/configuration/redis/ServingStoreRedisConfig.class]: Unsatisfied dependency expressed through method 'servingStoreRedisConf' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'specService' defined in class path resource [feast/serving/configuration/SpecServiceConfig.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [feast.serving.specs.CachedSpecService]: Factory method 'specService' threw exception; nested exception is java.lang.RuntimeException: Unable to update store configuration\r\n```\r\n\r\n## Steps to reproduce\r\n\r\nCheck out Feast master, and:\r\n\r\n    $ docker-compose -p feast-fullstack --env-file ./infra/docker-compose/.env.sample -f ./infra/docker-compose/docker-compose.yml up\r\n\r\n### Specifications\r\n\r\n- Version: master\r\n- Platform: macOS\r\n- Subsystem: Docker Compose\r\n\r\n## Possible Solution\r\n\r\nThis has probably stemmed from the recent configuration refactor merge from #611, like `StoreConfiguration` being removed and application YAML configs under `infra/docker-compose` being stale now.\r\n\r\nThose config file fragments would need to be updated. It might be a good idea to set image tags for released Feast versions in the `.env.sample` so that user installation experience following the docs isn't susceptible to mainline development breakages, assuming configs in `infra/docker-compose` would be frozen until next release time. Alternatively/additionally to the image tags, instruct users to check out a Git tag for the Compose installation.\r\n\r\n## Dev Workflow Consideration\r\n\r\nFor development I don't run the full Feast stack Docker Compose, since it isn't set up for that (rebuilding images as you change code, etc.). Rather I run the subset of `infra/docker-compose/docker-compose.yml` that is only the external service dependencies, and have the running Feast apps connect to the forwarded service ports from my host machine. \r\n\r\nI also need the patch below for that to work: there's a transposition typo in the Postgres port, and the Kafka listeners advertise `localhost:9094` instead of 9092. Both of those mean that the default `application.yml` configs using the standard service ports fail to connect out of the box. Perhaps this patch can be included when fixing everything else from the big configuration refactor. I was getting ready to submit this patch when I tested the full stack and found this issue.\r\n\r\n```patch\r\ndiff --git a/infra/docker-compose/docker-compose.yml b/infra/docker-compose/docker-compose.yml\r\nindex 38234cff..775687e6 100644\r\n--- a/infra/docker-compose/docker-compose.yml\r\n+++ b/infra/docker-compose/docker-compose.yml\r\n@@ -89,13 +89,12 @@ services:\r\n     environment:\r\n       KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181\r\n       KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1\r\n-      KAFKA_ADVERTISED_LISTENERS: INSIDE://kafka:9092,OUTSIDE://localhost:9094\r\n-      KAFKA_LISTENERS: INSIDE://:9092,OUTSIDE://:9094\r\n+      KAFKA_ADVERTISED_LISTENERS: INSIDE://kafka:9094,OUTSIDE://localhost:9092\r\n+      KAFKA_LISTENERS: INSIDE://:9094,OUTSIDE://:9092\r\n       KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: INSIDE:PLAINTEXT,OUTSIDE:PLAINTEXT\r\n       KAFKA_INTER_BROKER_LISTENER_NAME: INSIDE\r\n     ports:\r\n       - \"9092:9092\"\r\n-      - \"9094:9094\"\r\n \r\n     depends_on:\r\n       - zookeeper\r\n@@ -110,4 +109,4 @@ services:\r\n     environment:\r\n       POSTGRES_PASSWORD: password\r\n     ports:\r\n-      - \"5432:5342\"\r\n\\ No newline at end of file\r\n+      - \"5432:5432\"\r\n\\ No newline at end of file\r\n```","author":{"url":"https://github.com/ches","@type":"Person","name":"ches"},"datePublished":"2020-04-26T09:28:49.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/652/feast/issues/652"}