René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"BigQuerySource.get_table_query_string() silently ignores query when table is also set","articleBody":"## Summary\n\nWhen both `table` and `query` are provided to `BigQuerySource`, `get_table_query_string()` always returns `table`, silently ignoring `query`. This makes it impossible to use a custom query (e.g., for deduplication) on a `PushSource` batch source, since `PushSource` requires `table` for offline writes via `offline_write_batch()`.\n\n## Expected Behavior\n\nWhen both `table` and `query` are set on a `BigQuerySource`:\n- **Reads** (`get_table_query_string()`) should use `query` — it's more specific and intentionally provided\n- **Writes** (`offline_write_batch()`) should continue using `.table` directly as the write destination\n\n## Current Behavior\n\n`get_table_query_string()` in `bigquery_source.py` always prefers `table`:\n\n```python\ndef get_table_query_string(self) -\u003e str:\n    if self.table:\n        return f\"`{self.table}`\"\n    return f\"({self.query})\"\n```\n\nThis means any custom `query` (e.g., deduplication logic) is silently ignored when `table` is also present.\n\n## Use Case\n\nStreaming (push) sources often produce duplicate rows in BigQuery. The natural solution is:\n\n```python\nbatch_source = BigQuerySource(\n    name=\"my_batch_source\",\n    table=\"project.dataset.my_table\",        # needed for push writes\n    query=\"\"\"\n        SELECT * FROM `project.dataset.my_table`\n        QUALIFY ROW_NUMBER() OVER (PARTITION BY entity_id, event_time) = 1\n    \"\"\",                                      # needed for deduplicated reads\n    timestamp_field=\"event_time\",\n)\npush_source = PushSource(name=\"my_source\", batch_source=batch_source)\n```\n\nBut because `get_table_query_string()` ignores `query` when `table` is set, reads return duplicates. And removing `table` to force `query` usage breaks `offline_write_batch()`, which accesses `.table` directly (`bigquery.py:449`).\n\n## Environment\n\n- Feast version: 0.58.0 (also confirmed unresolved on 0.61.0 / current main)\n- Offline store: BigQuery","author":{"url":"https://github.com/max36067","@type":"Person","name":"max36067"},"datePublished":"2026-03-31T07:50:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/6200/feast/issues/6200"}