René's URL Explorer Experiment


Title: Bug: _materialize_odfv uses entity names instead of join keys · Issue #5965 · feast-dev/feast · GitHub

Open Graph Title: Bug: _materialize_odfv uses entity names instead of join keys · Issue #5965 · feast-dev/feast

X Title: Bug: _materialize_odfv uses entity names instead of join keys · Issue #5965 · feast-dev/feast

Description: Summary FeatureStore._materialize_odfv uses source_fv.entities (entity names) instead of source_fv.join_keys (join key column names) when building BigQuery queries. This causes materialization to fail when an entity's name differs from i...

Open Graph Description: Summary FeatureStore._materialize_odfv uses source_fv.entities (entity names) instead of source_fv.join_keys (join key column names) when building BigQuery queries. This causes materialization to f...

X Description: Summary FeatureStore._materialize_odfv uses source_fv.entities (entity names) instead of source_fv.join_keys (join key column names) when building BigQuery queries. This causes materialization to f...

Opengraph URL: https://github.com/feast-dev/feast/issues/5965

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug: _materialize_odfv uses entity names instead of join keys","articleBody":"## Summary\n\n`FeatureStore._materialize_odfv` uses `source_fv.entities` (entity **names**) instead of `source_fv.join_keys` (join key **column names**) when building BigQuery queries. This causes materialization to fail when an entity's name differs from its join key.\n\n## Steps to Reproduce\n\n1. Define an entity where name ≠ join key:\n```python\ncreator = Entity(\n    name=\"creator\",\n    join_keys=[\"creator_id\"],\n    value_type=ValueType.STRING,\n)\n```\n\n2. Define a FeatureView using that entity, and an OnDemandFeatureView sourcing from it with `write_to_online_store=True`.\n\n3. Run `store.materialize_incremental(...)`.\n\n## Expected Behavior\n\nThe generated BigQuery SQL should reference `creator_id` (the join key column).\n\n## Actual Behavior\n\nThe SQL references `creator` (the entity name), which doesn't exist as a column:\n\n```\ngoogle.api_core.exceptions.BadRequest: 400 Unrecognized name: creator;\nDid you mean creator_id? at [6:24]\n```\n\n## Root Cause\n\nIn [`feature_store.py` `_materialize_odfv`](https://github.com/feast-dev/feast/blob/master/sdk/python/feast/feature_store.py), two lines use `.entities` (names) where they should use `.join_keys` (column names):\n\n- **Line 1354**: `all_join_keys.update(source_fv.entities)` → should be `source_fv.join_keys`\n- **Line 1394**: `join_key_columns=source_fv.entities` → should be `source_fv.join_keys`\n\n`FeatureView.entities` returns `[e.name for e in entities]` (entity names), while `FeatureView.join_keys` returns `[e.name for e in self.entity_columns]` (actual column names). When these differ, the query fails.\n\nNote: regular `materialize_single_feature_view` does not have this bug because it resolves join keys correctly through the provider layer.\n\n## Suggested Fix\n\n```diff\n         for source_fv in source_fvs:\n-            all_join_keys.update(source_fv.entities)\n+            all_join_keys.update(source_fv.join_keys)\n             if source_fv.batch_source:\n                 entity_timestamp_col_names.add(source_fv.batch_source.timestamp_field)\n```\n\n```diff\n             job = provider.offline_store.pull_latest_from_table_or_query(\n                 config=self.config,\n                 data_source=source_fv.batch_source,\n-                join_key_columns=source_fv.entities,\n+                join_key_columns=source_fv.join_keys,\n                 feature_name_columns=[f.name for f in source_fv.features],\n```\n\n## Environment\n\n- Feast version: 0.58.0\n- Offline store: BigQuery","author":{"url":"https://github.com/max36067","@type":"Person","name":"max36067"},"datePublished":"2026-02-13T07:59:15Z","url":"https://github.com/feast-dev/feast/issues/5965"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8d00bed8-f406-9f20-de5f-13ec2b48b364
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD8F8:498F8:2DACF8:3F397A:6AFE9812
html-safe-nonceb1c3fbf01c256469f225bef442e43972fbe3a113fafe35b473abc0ce421275df
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEY4OjQ5OEY4OjJEQUNGODozRjM5N0E6NkFGRTk4MTIiLCJ2aXNpdG9yX2lkIjoiNzYxNTYxMjA0NTY5NzY1Mjc1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7bcf187d12dcc258ff5baf950c481f137ab0f6e95fb5b2d44ec4740a7ee3e8f6
hovercard-subject-tagissue:3935887945
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/5965/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2e698783d72abe51fb8d873b114a0aa036c405251234a1233dd5a7c57f8a2f1c/feast-dev/feast/issues/5965
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2e698783d72abe51fb8d873b114a0aa036c405251234a1233dd5a7c57f8a2f1c/feast-dev/feast/issues/5965
og:image:altSummary FeatureStore._materialize_odfv uses source_fv.entities (entity names) instead of source_fv.join_keys (join key column names) when building BigQuery queries. This causes materialization to f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemax36067
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/5965#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F5965
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F5965
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/5965
Reloadhttps://github.com/feast-dev/feast/issues/5965
Reloadhttps://github.com/feast-dev/feast/issues/5965
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/5965
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/5965
#6645https://github.com/feast-dev/feast/pull/6645
Bug: _materialize_odfv uses entity names instead of join keyshttps://github.com/feast-dev/feast/issues/5965#top
#6645https://github.com/feast-dev/feast/pull/6645
https://github.com/anshishrivastava
https://github.com/max36067
max36067https://github.com/max36067
on Feb 13, 2026https://github.com/feast-dev/feast/issues/5965#issue-3935887945
feature_store.py _materialize_odfvhttps://github.com/feast-dev/feast/blob/master/sdk/python/feast/feature_store.py
https://github.com/anshishrivastava
anshishrivastavahttps://github.com/anshishrivastava
on Feb 25, 2026https://github.com/feast-dev/feast/issues/5965#issuecomment-3955770407
@franciscojavierarceohttps://github.com/franciscojavierarceo
@ntkatholehttps://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
anshishrivastavahttps://github.com/anshishrivastava
on Feb 25, 2026https://github.com/feast-dev/feast/issues/5965#event-23058944900
https://github.com/anshishrivastava
anshishrivastavahttps://github.com/anshishrivastava
on Jul 24, 2026https://github.com/feast-dev/feast/issues/5965#issuecomment-5074187800
#6645https://github.com/feast-dev/feast/pull/6645
ntkatholehttps://github.com/ntkathole
on Jul 30, 2026https://github.com/feast-dev/feast/issues/5965#event-28701478460
fix: Use join keys instead of entity names in ODFV materializationhttps://github.com/anshishrivastava/feast/commit/694ed06e355d79db1394c465af611ac163b7fee4
https://docs.github.com/articles/closing-issues-via-commit-messages
694ed06https://github.com/anshishrivastava/feast/commit/694ed06e355d79db1394c465af611ac163b7fee4
fix: Use join keys instead of entity names in ODFV materializationhttps://github.com/anshishrivastava/feast/commit/a07a064be22575c99361bcc241da56488e9d0554
https://docs.github.com/articles/closing-issues-via-commit-messages
a07a064https://github.com/anshishrivastava/feast/commit/a07a064be22575c99361bcc241da56488e9d0554
ntkatholehttps://github.com/ntkathole
completedhttps://github.com/feast-dev/feast/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#6645https://github.com/feast-dev/feast/pull/6645
on Jul 30, 2026https://github.com/feast-dev/feast/issues/5965#event-28703139403
Vperiodthttps://github.com/Vperiodt
on Jul 30, 2026https://github.com/feast-dev/feast/issues/5965#event-28703210471
fix: Use join keys instead of entity names in ODFV materialization (f…https://github.com/Vperiodt/feast/commit/abffebc37da3449b6dc571fc47dfa1c67ed16f3e
f…https://github.com/feast-dev/feast/pull/6645
https://docs.github.com/articles/closing-issues-via-commit-messages
abffebchttps://github.com/Vperiodt/feast/commit/abffebc37da3449b6dc571fc47dfa1c67ed16f3e
franciscojavierarceohttps://github.com/franciscojavierarceo
on Aug 21, 2026https://github.com/feast-dev/feast/issues/5965#event-29781434977
chore(release): release 0.66.0https://github.com/feast-dev/feast/commit/1d5be950cf718a674cb01eaf0fd0ad6f0a4c6335
1d5be95https://github.com/feast-dev/feast/commit/1d5be950cf718a674cb01eaf0fd0ad6f0a4c6335
Michie-hubhttps://github.com/Michie-hub
on Aug 31, 2026https://github.com/feast-dev/feast/issues/5965#event-30282808141
chore(release): release 0.66.0https://github.com/Michie-hub/feast/commit/a29c9231976fd7c68e51570047f9517f06579041
a29c923https://github.com/Michie-hub/feast/commit/a29c9231976fd7c68e51570047f9517f06579041
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/5965
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/5965
anshishrivastavahttps://github.com/anshishrivastava
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.