Title: Provider `get_historical_features` API cleanup: remove ad-hoc args and formalize ODFV handling · Issue #5890 · feast-dev/feast · GitHub
Open Graph Title: Provider `get_historical_features` API cleanup: remove ad-hoc args and formalize ODFV handling · Issue #5890 · feast-dev/feast
X Title: Provider `get_historical_features` API cleanup: remove ad-hoc args and formalize ODFV handling · Issue #5890 · feast-dev/feast
Description: Context PR #5803 adds a new argument on_demand_feature_views to Provider.get_historical_features. This fixes a gap where FeatureStore.get_historical_features() already resolves which OnDemandFeatureViews are requested (via _group_feature...
Open Graph Description: Context PR #5803 adds a new argument on_demand_feature_views to Provider.get_historical_features. This fixes a gap where FeatureStore.get_historical_features() already resolves which OnDemandFeatur...
X Description: Context PR #5803 adds a new argument on_demand_feature_views to Provider.get_historical_features. This fixes a gap where FeatureStore.get_historical_features() already resolves which OnDemandFeatur...
Opengraph URL: https://github.com/feast-dev/feast/issues/5890
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Provider `get_historical_features` API cleanup: remove ad-hoc args and formalize ODFV handling","articleBody":"### Context\nPR #5803 adds a new argument `on_demand_feature_views` to `Provider.get_historical_features`.\n\nThis fixes a gap where `FeatureStore.get_historical_features()` already resolves which `OnDemandFeatureView`s are requested (via `_group_feature_refs`), but historically that list was not explicitly passed to the Provider. Some provider implementations / compute engines benefit from receiving the requested ODFVs explicitly (planning/optimization/correctness without re-deriving).\n\nA maintainer requested tracking this as an interim change and flagging a proper long-term interface fix.\n\n### Problem\nThe historical retrieval interface currently encourages “API drift”:\n- `FeatureStore` performs grouping/selection of requested feature views vs ODFVs\n- Providers/offline stores may need to re-derive ODFV selection from `feature_refs` and registry state\n- New requirements tend to be implemented via ad-hoc argument additions to `Provider.get_historical_features`\n\nThis makes the contract unclear and can lead to duplicated logic or unnecessary work in providers.\n\n### Goal\nDefine a clearer long-term contract for historical retrieval that:\n- makes the retrieval request structure explicit (including requested ODFVs / transformations)\n- avoids one-off arguments in the Provider API\n- reduces duplicated grouping/selection logic between `FeatureStore` and providers\n- supports compute-engine-style providers planning execution deterministically\n\n### Proposed direction (non-binding)\nOne of:\n1. Introduce a typed request object (e.g. `HistoricalRetrievalRequest`) passed into Provider/offline store, containing:\n - resolved `FeatureView`s\n - resolved `OnDemandFeatureView`s / transformations\n - `feature_refs`\n - entity dataframe/query or time range params\n - `full_feature_names`, project/config, etc.\n2. Alternatively, formalize that `feature_views` includes both FVs and ODFVs in a consistent way, and remove the need for a separate `on_demand_feature_views` parameter (with a documented contract for how they’re represented and used).\n\n### Acceptance criteria\n- API: A documented, stable Provider/offline-store historical retrieval interface (request object or equivalent).\n- Refactor: Avoid future ad-hoc args like `on_demand_feature_views` being added to `Provider.get_historical_features`.\n- Compat: Clear backward compatibility / deprecation plan for existing providers.\n- Tests: Unit/integration coverage proving:\n - requested ODFVs are correctly resolved and passed through\n - providers can plan execution without re-deriving ODFV selection\n\n### Related\n- PR: #5803","author":{"url":"https://github.com/Shizoqua","@type":"Person","name":"Shizoqua"},"datePublished":"2026-01-22T12:00:11Z","url":"https://github.com/feast-dev/feast/issues/5890"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7f95de2d-fb4c-83bf-a7b9-78ee2435284f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B0EA:34D994:1140763:179D3A5:6AFEA264 |
| html-safe-nonce | f916efd250311e54a5464af14675e0413062827e2e249ef4a2f82b6ed3bef5ab |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEVBOjM0RDk5NDoxMTQwNzYzOjE3OUQzQTU6NkFGRUEyNjQiLCJ2aXNpdG9yX2lkIjoiODMyODg4MDM5OTg3MDUwMTQ3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 00a751104ecd71e13bfad9a6219c9acc4880d09ec518831a14887f871cb229b3 |
| hovercard-subject-tag | issue:3842613071 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/5890/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3202313285c5381e10765fd0def21827a042006b7815ee84b2ed7283552c1a96/feast-dev/feast/issues/5890 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3202313285c5381e10765fd0def21827a042006b7815ee84b2ed7283552c1a96/feast-dev/feast/issues/5890 |
| og:image:alt | Context PR #5803 adds a new argument on_demand_feature_views to Provider.get_historical_features. This fixes a gap where FeatureStore.get_historical_features() already resolves which OnDemandFeatur... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Shizoqua |
| hostname | github.com |
| expected-hostname | github.com |
| None | 95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3f25273206cd841171bca0002261ae4c9757d934 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width