René's URL Explorer Experiment


Title: Provider `get_historical_features` API cleanup: remove ad-hoc args and formalize ODFV handling · Issue #5890 · feast-dev/feast · GitHub

Open Graph Title: Provider `get_historical_features` API cleanup: remove ad-hoc args and formalize ODFV handling · Issue #5890 · feast-dev/feast

X Title: Provider `get_historical_features` API cleanup: remove ad-hoc args and formalize ODFV handling · Issue #5890 · feast-dev/feast

Description: Context PR #5803 adds a new argument on_demand_feature_views to Provider.get_historical_features. This fixes a gap where FeatureStore.get_historical_features() already resolves which OnDemandFeatureViews are requested (via _group_feature...

Open Graph Description: Context PR #5803 adds a new argument on_demand_feature_views to Provider.get_historical_features. This fixes a gap where FeatureStore.get_historical_features() already resolves which OnDemandFeatur...

X Description: Context PR #5803 adds a new argument on_demand_feature_views to Provider.get_historical_features. This fixes a gap where FeatureStore.get_historical_features() already resolves which OnDemandFeatur...

Opengraph URL: https://github.com/feast-dev/feast/issues/5890

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Provider `get_historical_features` API cleanup: remove ad-hoc args and formalize ODFV handling","articleBody":"### Context\nPR #5803 adds a new argument `on_demand_feature_views` to `Provider.get_historical_features`.\n\nThis fixes a gap where `FeatureStore.get_historical_features()` already resolves which `OnDemandFeatureView`s are requested (via `_group_feature_refs`), but historically that list was not explicitly passed to the Provider. Some provider implementations / compute engines benefit from receiving the requested ODFVs explicitly (planning/optimization/correctness without re-deriving).\n\nA maintainer requested tracking this as an interim change and flagging a proper long-term interface fix.\n\n### Problem\nThe historical retrieval interface currently encourages “API drift”:\n- `FeatureStore` performs grouping/selection of requested feature views vs ODFVs\n- Providers/offline stores may need to re-derive ODFV selection from `feature_refs` and registry state\n- New requirements tend to be implemented via ad-hoc argument additions to `Provider.get_historical_features`\n\nThis makes the contract unclear and can lead to duplicated logic or unnecessary work in providers.\n\n### Goal\nDefine a clearer long-term contract for historical retrieval that:\n- makes the retrieval request structure explicit (including requested ODFVs / transformations)\n- avoids one-off arguments in the Provider API\n- reduces duplicated grouping/selection logic between `FeatureStore` and providers\n- supports compute-engine-style providers planning execution deterministically\n\n### Proposed direction (non-binding)\nOne of:\n1. Introduce a typed request object (e.g. `HistoricalRetrievalRequest`) passed into Provider/offline store, containing:\n   - resolved `FeatureView`s\n   - resolved `OnDemandFeatureView`s / transformations\n   - `feature_refs`\n   - entity dataframe/query or time range params\n   - `full_feature_names`, project/config, etc.\n2. Alternatively, formalize that `feature_views` includes both FVs and ODFVs in a consistent way, and remove the need for a separate `on_demand_feature_views` parameter (with a documented contract for how they’re represented and used).\n\n### Acceptance criteria\n- API: A documented, stable Provider/offline-store historical retrieval interface (request object or equivalent).\n- Refactor: Avoid future ad-hoc args like `on_demand_feature_views` being added to `Provider.get_historical_features`.\n- Compat: Clear backward compatibility / deprecation plan for existing providers.\n- Tests: Unit/integration coverage proving:\n  - requested ODFVs are correctly resolved and passed through\n  - providers can plan execution without re-deriving ODFV selection\n\n### Related\n- PR: #5803","author":{"url":"https://github.com/Shizoqua","@type":"Person","name":"Shizoqua"},"datePublished":"2026-01-22T12:00:11Z","url":"https://github.com/feast-dev/feast/issues/5890"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7f95de2d-fb4c-83bf-a7b9-78ee2435284f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB0EA:34D994:1140763:179D3A5:6AFEA264
html-safe-noncef916efd250311e54a5464af14675e0413062827e2e249ef4a2f82b6ed3bef5ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEVBOjM0RDk5NDoxMTQwNzYzOjE3OUQzQTU6NkFGRUEyNjQiLCJ2aXNpdG9yX2lkIjoiODMyODg4MDM5OTg3MDUwMTQ3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac00a751104ecd71e13bfad9a6219c9acc4880d09ec518831a14887f871cb229b3
hovercard-subject-tagissue:3842613071
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/5890/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3202313285c5381e10765fd0def21827a042006b7815ee84b2ed7283552c1a96/feast-dev/feast/issues/5890
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3202313285c5381e10765fd0def21827a042006b7815ee84b2ed7283552c1a96/feast-dev/feast/issues/5890
og:image:altContext PR #5803 adds a new argument on_demand_feature_views to Provider.get_historical_features. This fixes a gap where FeatureStore.get_historical_features() already resolves which OnDemandFeatur...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameShizoqua
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/5890#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F5890
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F5890
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/5890
Reloadhttps://github.com/feast-dev/feast/issues/5890
Reloadhttps://github.com/feast-dev/feast/issues/5890
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/5890
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/5890
Provider get_historical_features API cleanup: remove ad-hoc args and formalize ODFV handlinghttps://github.com/feast-dev/feast/issues/5890#top
kind/featureNew feature or requesthttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Ffeature%22
https://github.com/Shizoqua
Shizoquahttps://github.com/Shizoqua
on Jan 22, 2026https://github.com/feast-dev/feast/issues/5890#issue-3842613071
#5803https://github.com/feast-dev/feast/pull/5803
feat: Pass requested On-Demand Feature Views to Provider get_historical_features #5803https://github.com/feast-dev/feast/pull/5803
Shizoquahttps://github.com/Shizoqua
kind/featureNew feature or requesthttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Ffeature%22
on Jan 22, 2026https://github.com/feast-dev/feast/issues/5890#event-22214245211
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/5890
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/5890
kind/featureNew feature or requesthttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Ffeature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.