Title: dbt integration: Add validation for timestamp field data type · Issue #5871 · feast-dev/feast · GitHub
Open Graph Title: dbt integration: Add validation for timestamp field data type · Issue #5871 · feast-dev/feast
X Title: dbt integration: Add validation for timestamp field data type · Issue #5871 · feast-dev/feast
Description: Context PR #5827 added dbt integration that requires a timestamp field for point-in-time correctness. Problem The code validates that the timestamp field exists in the model columns but doesn't validate that it's actually a timestamp typ...
Open Graph Description: Context PR #5827 added dbt integration that requires a timestamp field for point-in-time correctness. Problem The code validates that the timestamp field exists in the model columns but doesn't val...
X Description: Context PR #5827 added dbt integration that requires a timestamp field for point-in-time correctness. Problem The code validates that the timestamp field exists in the model columns but doesn't...
Opengraph URL: https://github.com/feast-dev/feast/issues/5871
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"dbt integration: Add validation for timestamp field data type","articleBody":"## Context\nPR #5827 added dbt integration that requires a timestamp field for point-in-time correctness.\n\n## Problem\nThe code validates that the timestamp field exists in the model columns but doesn't validate that it's actually a timestamp type. This could lead to runtime errors or incorrect behavior.\n\n## Current Behavior\n```python\n# In dbt_import.py:183-189\nif timestamp_field not in column_names:\n click.echo(\n f\"{Fore.YELLOW}Warning: Model '{model.name}' missing timestamp \"\n f\"field '{timestamp_field}'. Skipping.{Style.RESET_ALL}\"\n )\n continue\n```\n\nNo type checking is performed.\n\n## Proposed Solution\nAdd validation that the timestamp field is one of the timestamp types:\n- TIMESTAMP\n- TIMESTAMP_NTZ / TIMESTAMP_LTZ / TIMESTAMP_TZ\n- DATETIME\n- DATE\n\nWarn users if the field exists but has an incompatible type.\n\n## Example\n```python\ntimestamp_col = next((c for c in model.columns if c.name == timestamp_field), None)\nif timestamp_col:\n normalized_type = timestamp_col.data_type.upper()\n valid_ts_types = ['TIMESTAMP', 'TIMESTAMP_NTZ', 'TIMESTAMP_LTZ', 'TIMESTAMP_TZ', 'DATETIME', 'DATE']\n if not any(t in normalized_type for t in valid_ts_types):\n click.echo(f\"{Fore.YELLOW}Warning: Timestamp field '{timestamp_field}' has type '{timestamp_col.data_type}' which may not be suitable{Style.RESET_ALL}\")\n```\n\n## Related\n- PR #5827","author":{"url":"https://github.com/YassinNouh21","@type":"Person","name":"YassinNouh21"},"datePublished":"2026-01-16T20:12:05.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/5871/feast/issues/5871"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bc8bfd59-3d46-865f-9579-b6a52ddbf579 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B174:335652:356EAC7:497F314:696E19AD |
| html-safe-nonce | c1f48857bc4927e610ef108380e07effb994adbebfec1db84bfb3f5166274439 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTc0OjMzNTY1MjozNTZFQUM3OjQ5N0YzMTQ6Njk2RTE5QUQiLCJ2aXNpdG9yX2lkIjoiNjgyMzg0Nzg2NDE3NDUxNjY1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3b8e44013e78dbf7890167982c7fca92c54787fb98d136bbb2ff077292fc1295 |
| hovercard-subject-tag | issue:3823511267 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/5871/issue_layout |
| twitter:image | https://opengraph.githubassets.com/7b391856cb34594e152989c2fcb374f104ee1edf18d203980b3744d1546a70cc/feast-dev/feast/issues/5871 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7b391856cb34594e152989c2fcb374f104ee1edf18d203980b3744d1546a70cc/feast-dev/feast/issues/5871 |
| og:image:alt | Context PR #5827 added dbt integration that requires a timestamp field for point-in-time correctness. Problem The code validates that the timestamp field exists in the model columns but doesn't val... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | YassinNouh21 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 113cc336e7105fbb9f2ee8beb67c6cc584d65fa66a8a1a5dd236ba66db174af7 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d23f8b0bc31294c6a73ba2f3adfdd8c7052ca1e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width