Title: Converting Runner to String for assigning to Job.Runner is inconsistent. · Issue #574 · feast-dev/feast · GitHub
Open Graph Title: Converting Runner to String for assigning to Job.Runner is inconsistent. · Issue #574 · feast-dev/feast
X Title: Converting Runner to String for assigning to Job.Runner is inconsistent. · Issue #574 · feast-dev/feast
Description: Expected Behavior One true way to convert Runner to string when assigning to Job.Runner. Current Behavior There are multiple ways in which Runner is converted to string in feast core to be stored in Job.runner : toString()method which is...
Open Graph Description: Expected Behavior One true way to convert Runner to string when assigning to Job.Runner. Current Behavior There are multiple ways in which Runner is converted to string in feast core to be stored i...
X Description: Expected Behavior One true way to convert Runner to string when assigning to Job.Runner. Current Behavior There are multiple ways in which Runner is converted to string in feast core to be stored i...
Opengraph URL: https://github.com/feast-dev/feast/issues/574
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Converting Runner to String for assigning to Job.Runner is inconsistent.","articleBody":"## Expected Behavior \r\nOne true way to convert `Runner` to string when assigning to `Job.Runner`.\r\n\r\n## Current Behavior\r\nThere are multiple ways in which `Runner` is converted to string in feast core to be stored in `Job.runner` :\r\n- `toString()`method which is used by [`JobUpdateTask`](https://github.com/gojek/feast/blob/9facd2e5f00c0616da2bb616664e619ee0100de6/core/src/main/java/feast/core/job/JobUpdateTask.java#L147) and `DirectJob` runner.\r\n- `getName()` method which is used by [`Dataflow`](https://github.com/gojek/feast/blob/9facd2e5f00c0616da2bb616664e619ee0100de6/core/src/main/java/feast/core/job/dataflow/DataflowJobManager.java#L204) runner\r\n\r\n## Steps to reproduce\r\nN.A.\r\n\r\n## Possible Solution\r\n\r\nStandardise on one true way to convert `Runner` to string when assigning to `Job.Runner`.","author":{"url":"https://github.com/mrzzy","@type":"Person","name":"mrzzy"},"datePublished":"2020-03-27T02:49:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/574/feast/issues/574"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bbe4c55a-c07b-c24b-d31b-3a61bf41b281 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C4C4:3B1757:135CABF:1BB4D4E:697A3993 |
| html-safe-nonce | ea4f3205e302f2f2c231f76d1bc83ba634dbc75e2750dabdec7472d5615d233b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEM0OjNCMTc1NzoxMzVDQUJGOjFCQjRENEU6Njk3QTM5OTMiLCJ2aXNpdG9yX2lkIjoiNTk2NzI0Mjk5MDkwNzQzOTUwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a98b31d3532521b8613482e9b8dee12006c0477142a0f464d1ce6e1bbff48483 |
| hovercard-subject-tag | issue:588849420 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/574/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d361775cf8f39fd4502ccd2402e21cc7e8e61b65ff6730c2cb5298aa709576c9/feast-dev/feast/issues/574 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d361775cf8f39fd4502ccd2402e21cc7e8e61b65ff6730c2cb5298aa709576c9/feast-dev/feast/issues/574 |
| og:image:alt | Expected Behavior One true way to convert Runner to string when assigning to Job.Runner. Current Behavior There are multiple ways in which Runner is converted to string in feast core to be stored i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mrzzy |
| hostname | github.com |
| expected-hostname | github.com |
| None | af6de804ceb83ad30bb9b348cdeaccaa30cdcb566762d5e74e21e2bad88885d0 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2d980605f0959039ddebcbcf522b072508302977 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width