Title: Remove GCP dependency in test_get_batch_features · Issue #562 · feast-dev/feast · GitHub
Open Graph Title: Remove GCP dependency in test_get_batch_features · Issue #562 · feast-dev/feast
X Title: Remove GCP dependency in test_get_batch_features · Issue #562 · feast-dev/feast
Description: Expected Behavior Python unit tests should not depend on GCP service accounts being available Current Behavior Currently the test test_get_batch_features in the Python SDK leads to a failure when it is run from an environment where GOOGL...
Open Graph Description: Expected Behavior Python unit tests should not depend on GCP service accounts being available Current Behavior Currently the test test_get_batch_features in the Python SDK leads to a failure when i...
X Description: Expected Behavior Python unit tests should not depend on GCP service accounts being available Current Behavior Currently the test test_get_batch_features in the Python SDK leads to a failure when i...
Opengraph URL: https://github.com/feast-dev/feast/issues/562
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove GCP dependency in test_get_batch_features","articleBody":"## Expected Behavior \r\n\r\nPython unit tests should not depend on GCP service accounts being available\r\n\r\n## Current Behavior\r\n\r\nCurrently the test `test_get_batch_features` in the Python SDK leads to a failure when it is run from an environment where GOOGLE_APPLICATION_CREDENTIALS are not available, or it cannot infer a local Gcloud configuration. This is triggered because the `Job` object initializes itself with a storage client that requires GCP credentials.\r\n\r\nFor the time being this test has been commented out, please see this PR https://github.com/gojek/feast/pull/560/files#r396175767\r\n\r\n## Steps to reproduce\r\n\r\n1. Uncomment above test\r\n2. Execute from a clean environment (kf-feast/feast-ci:latest docker image)\r\n\r\n## Possible Solution\r\n\r\n- Stub out the storage client in the unit test.\r\n- Alternatively we should make the Job object not initialize a Storage Client.","author":{"url":"https://github.com/woop","@type":"Person","name":"woop"},"datePublished":"2020-03-23T01:33:41.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/562/feast/issues/562"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bcbf061b-c6d3-a3c5-fe31-bcf6b53c28db |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D5B6:3F7733:F25F8E:1522B0B:697B5F53 |
| html-safe-nonce | 843c37f8fc8dce9a626646c44402064a13ac7032e07f86b59f7a7cb9411733d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUI2OjNGNzczMzpGMjVGOEU6MTUyMkIwQjo2OTdCNUY1MyIsInZpc2l0b3JfaWQiOiIxMTcxNzc4MjMzODcyMTEzNDkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4097441bac2316128bcea9c5eafa2e97546f929a9983b139284a2f66a3c69f94 |
| hovercard-subject-tag | issue:585868293 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/562/issue_layout |
| twitter:image | https://opengraph.githubassets.com/aab525eae0aafe9b6d8ec77b9e75d4ffa3be856c4f353046e6adc793c63c8c85/feast-dev/feast/issues/562 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/aab525eae0aafe9b6d8ec77b9e75d4ffa3be856c4f353046e6adc793c63c8c85/feast-dev/feast/issues/562 |
| og:image:alt | Expected Behavior Python unit tests should not depend on GCP service accounts being available Current Behavior Currently the test test_get_batch_features in the Python SDK leads to a failure when i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | woop |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7eed3e20c41f6c464df945b1f353a52c450ca1653f4697d4ebcc58c2adc5868a |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d72d3188f34dc5c9b58eb1a406c45898c7a25009 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width