René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Consolidate document retrieval methods: Remove v1 and standardize on v2","articleBody":"## Problem Statement\n\nCurrently, Feast has both v1 and v2 document retrieval methods (`retrieve_online_documents_v1` and `retrieve_online_documents_v2`) across different online stores. This creates inconsistency and maintenance overhead.\n\n**Issues identified:**\n- Different online stores may have different logic between v1 and v2 implementations\n- As noted in [PR #5487](https://github.com/feast-dev/feast/pull/5487#discussion_r2219134015), PostgreSQL online store shows v1 and v2 \"retrieving different dataframes as the logic is completely different for both versions\"\n- v2 was intended to \"incorporate more fields\" but differences beyond that indicate potential bugs\n- Maintaining two versions increases code complexity and testing burden\n\n## Research Required\n\nBefore removing v1, we need to investigate:\n\n### 1. **Cross-Store Analysis**\n- [ ] Audit all online stores that implement both v1 and v2 document retrieval\n- [ ] Document the specific differences in logic between v1 and v2 for each store\n- [ ] Identify which stores have consistent behavior vs. divergent behavior\n\n### 2. **API Compatibility Assessment**  \n- [ ] Analyze which version provides more comprehensive/correct results\n- [ ] Compare field coverage between v1 and v2 responses\n- [ ] Evaluate performance characteristics of both versions\n\n### 3. **Usage Analysis**\n- [ ] Identify current usage patterns of v1 vs v2 in the codebase\n- [ ] Check external documentation and examples using these APIs\n- [ ] Assess backward compatibility requirements\n\n### 4. **Store-Specific Investigation**\nFocus on stores mentioned with differences:\n- [ ] **PostgreSQL**: Detailed analysis of why v1/v2 return different dataframes\n- [ ] **Remote store**: Ensure consistency after [PR #5487](https://github.com/feast-dev/feast/pull/5487) implementation\n- [ ] **Other stores**: Milvus, Redis, DynamoDB, etc.\n\n## Proposed Solution\n\nBased on research findings:\n\n### Phase 1: Research \u0026 Documentation\n1. Complete the research items above\n2. Create a comprehensive comparison matrix of v1 vs v2 across all stores\n3. Identify the \"canonical\" version that should be preserved\n\n### Phase 2: Standardization\n1. Ensure v2 implementation is consistent and correct across all stores\n2. Update v2 to include any missing functionality from v1 (if needed)\n3. Add comprehensive tests for v2 across all stores\n\n### Phase 3: Migration \u0026 Removal\n1. Deprecate v1 methods with clear migration guidance\n2. Update all internal usage to v2\n3. Remove v1 implementation after appropriate deprecation period\n\n## Acceptance Criteria\n\n- [ ] All online stores have consistent document retrieval behavior\n- [ ] Single document retrieval API (v2) that works uniformly across stores\n- [ ] Comprehensive test coverage for document retrieval functionality\n- [ ] Migration guide for any external users of v1 API\n- [ ] Updated documentation reflecting the consolidated API\n\n## Context\n\nThis issue stems from the discussion in [PR #5487](https://github.com/feast-dev/feast/pull/5487#discussion_r2219134015) where @franciscojavierarceo noted that v1/v2 differences beyond additional fields indicate bugs, and @jyejare confirmed that different stores have different logic between versions.\n\n**Original comment:**\n\u003e \"v2 vs v1 should be approximately the same where v2 was meant to incorporate more fields. If there is a difference, it's a bug... we should remove v1 and move to v2 for all of the existing usage.\"\n\n## Priority\n\n**Medium-High** - This affects API consistency and maintainability, but doesn't block current functionality.","author":{"url":"https://github.com/jyejare","@type":"Person","name":"jyejare"},"datePublished":"2025-07-24T15:35:41.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/5537/feast/issues/5537"}