René's URL Explorer Experiment


Title: OnDemandFeatureView silently skips transformation if BatchSource defines column with same name · Issue #5534 · feast-dev/feast · GitHub

Open Graph Title: OnDemandFeatureView silently skips transformation if BatchSource defines column with same name · Issue #5534 · feast-dev/feast

X Title: OnDemandFeatureView silently skips transformation if BatchSource defines column with same name · Issue #5534 · feast-dev/feast

Description: Summary When an OnDemandFeatureView defines a transformed feature (e.g. revenue_plus_one), and the upstream BatchSource (usually through a FeatureView) already defines a column with the same name, Feast silently skips applying the ODFV t...

Open Graph Description: Summary When an OnDemandFeatureView defines a transformed feature (e.g. revenue_plus_one), and the upstream BatchSource (usually through a FeatureView) already defines a column with the same name, ...

X Description: Summary When an OnDemandFeatureView defines a transformed feature (e.g. revenue_plus_one), and the upstream BatchSource (usually through a FeatureView) already defines a column with the same name, ...

Opengraph URL: https://github.com/feast-dev/feast/issues/5534

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"OnDemandFeatureView silently skips transformation if BatchSource defines column with same name","articleBody":"## **Summary**\n\nWhen an `OnDemandFeatureView` defines a transformed feature (e.g. `revenue_plus_one`), and the upstream `BatchSource` (usually through a `FeatureView`) already defines a column with the **same name**, Feast **silently skips** applying the ODFV transformation. This can have negative impact if the existing column contains only `None` values/ other incorrect data**.\n\nThis behavior leads to **silent inconsistencies** in the offline path and contradicts the intent of using ODFVs for transformation logic.\n\n### **Current Behavior**\n\n* ODFVs apply their transformation in the **offline path only if** the output column **does not exist** in the `BatchSource`.\n* If the `BatchSource` includes a column with the same name (even with bad/missing values), Feast assumes it is the final value and skips transformation.\n* This affects reading features from offline store with `get_historical_features()`. \n* This might happen incidentally, because the `FeatureView` used as input to the ODFV points to a `BatchSource` that might include unexpected or unknown columns.\n\n---\n\n### **Steps to Reproduce**\n\n1. Create a `FeatureView` from a `BatchSource` that includes a column `\"revenue_plus_one\"` filled with `None` or incorrect values.\n2. Define an `OnDemandFeatureView` that expects to compute `\"revenue_plus_one\"` from base features (e.g. `revenue + 1`).\n3. Use the ODFV in a historical feature retrieval.\n\n```python\nfeatures = [\n    \"customer_stats:revenue\",\n    \"revenue_plus_one:revenue_plus_one\",  # from ODFV\n]\n\n# BatchSource has revenue_plus_one = None\ndf = store.get_historical_features(entity_df=..., features=features).to_df()\nprint(df[\"revenue_plus_one\"])  # Contains None instead of expected transformed values\n```\n\n---\n\n### **Expected Behavior**\n\n* The `OnDemandFeatureView` (ODFV) should **not unknowingly use a column** from an upstream `FeatureView`’s `BatchSource` just because the column name matches the ODFV’s output.\n* If a column with the same name exists in the `BatchSource`, Feast should:\n\n  * Either still apply the transformation from the ODFV,\n  * Or explicitly verify that the existing column is valid (non-null, correct type),\n  * Or *warn the user about the name collision and skipped transformation.\n* The behavior should be consistent and explainable, so users know when transformations were applied and when they were not.\n\n---\n\n### **Root Cause**\n\nFeast uses the output column name as a selector. If the column exists in the `BatchSource`, Feast treats it as final — regardless of whether the transformation logic would produce different or more complete results.\n\nThis causes subtle and difficult-to-detect **Training-Serving Skew**, especially in pipelines where `FeatureViews` and `BatchSources` are reused.\n\n---\n\n### **Proposed Solutions**\n\nTo avoid incorrect behavior when Feast skips On-Demand Feature View (ODFV) transformations due to existing columns in the batch source, I propose two possible solutions:\n\n#### 1. Marker Field to Track Transformation\n\nAdd an internal marker or metadata tag that indicates whether a feature value has already been transformed.\n\nThis can be used to:\n\nEnsure the transformation is only skipped if it really already happened.\n\nIn the simplest form, this marker just records if the transformation was ever applied.\n\nLonger-term, this could help build a full understanding of how each feature value was created.\n\n#### 2. Use the Compute Engine DAG to Manage Transformations Explicitly\n\nThe new DAG-based Compute Engine could explicitly control when and how each transformation is applied.\n\nInstead of relying on column names, the system would always run transformations defined in the DAG, unless they are marked as already applied (via the marker field above).\n\n---\n\n### **Additional Context**\n\nThis issue is especially confusing because the `FeatureView` may define a `BatchSource`, which silently passes through unknown columns. These columns **won’t be used** when the `FeatureView` is queried directly, but **will be used** if an `ODFV` is layered on top with the same output name.","author":{"url":"https://github.com/jfw-ppi","@type":"Person","name":"jfw-ppi"},"datePublished":"2025-07-22T19:24:51Z","url":"https://github.com/feast-dev/feast/issues/5534"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7e92efb0-bf63-e231-cefd-9f2abdf676ce
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8C36:BF02A:5AE1F9:7E7DC4:6AFEA853
html-safe-nonce5466e47fdf4c2cf4570d6fbafcfde6b076ce3472170208b28f09c00b45c70bed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzM2OkJGMDJBOjVBRTFGOTo3RTdEQzQ6NkFGRUE4NTMiLCJ2aXNpdG9yX2lkIjoiODA5MDQ5Njg2NDQwMDM1MzM2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca2eddb903ad85ed2e9683c5d1729ee6e0216215fc08224c7db8d158af1be829e
hovercard-subject-tagissue:3253819588
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/5534/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e4a5c7eb90588585f1d79f4d57b8b3604765ffbc0b06b5b5b4289af1798486f2/feast-dev/feast/issues/5534
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e4a5c7eb90588585f1d79f4d57b8b3604765ffbc0b06b5b5b4289af1798486f2/feast-dev/feast/issues/5534
og:image:altSummary When an OnDemandFeatureView defines a transformed feature (e.g. revenue_plus_one), and the upstream BatchSource (usually through a FeatureView) already defines a column with the same name, ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejfw-ppi
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/5534#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F5534
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F5534
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/5534
Reloadhttps://github.com/feast-dev/feast/issues/5534
Reloadhttps://github.com/feast-dev/feast/issues/5534
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/5534
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/5534
#7009https://github.com/feast-dev/feast/pull/7009
OnDemandFeatureView silently skips transformation if BatchSource defines column with same namehttps://github.com/feast-dev/feast/issues/5534#top
#7009https://github.com/feast-dev/feast/pull/7009
kind/bughttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Fbug%22
priority/p2https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22priority%2Fp2%22
https://github.com/jfw-ppi
jfw-ppihttps://github.com/jfw-ppi
on Jul 22, 2025https://github.com/feast-dev/feast/issues/5534#issue-3253819588
jfw-ppihttps://github.com/jfw-ppi
kind/bughttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Fbug%22
priority/p2https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22priority%2Fp2%22
on Jul 22, 2025https://github.com/feast-dev/feast/issues/5534#event-18759426041
https://github.com/haoxu0
haoxu0https://github.com/haoxu0
on Jul 24, 2025https://github.com/feast-dev/feast/issues/5534#issuecomment-3111981345
https://github.com/luc-pimentel
luc-pimentelhttps://github.com/luc-pimentel
on Oct 14, 2026https://github.com/feast-dev/feast/issues/5534#issuecomment-6159111835
#7009https://github.com/feast-dev/feast/pull/7009
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/5534
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/5534
kind/bughttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Fbug%22
priority/p2https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22priority%2Fp2%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.