Title: Code Standards / Linting checked & applied consistently for all langs · Issue #526 · feast-dev/feast · GitHub
Open Graph Title: Code Standards / Linting checked & applied consistently for all langs · Issue #526 · feast-dev/feast
X Title: Code Standards / Linting checked & applied consistently for all langs · Issue #526 · feast-dev/feast
Description: Is your feature request related to a problem? Please describe. Code standards expectations are by documentation for some project languages, and by automation for others. In cases of the former: Contributors don't realize they should foll...
Open Graph Description: Is your feature request related to a problem? Please describe. Code standards expectations are by documentation for some project languages, and by automation for others. In cases of the former: Con...
X Description: Is your feature request related to a problem? Please describe. Code standards expectations are by documentation for some project languages, and by automation for others. In cases of the former: Con...
Opengraph URL: https://github.com/feast-dev/feast/issues/526
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Code Standards / Linting checked \u0026 applied consistently for all langs","articleBody":"**Is your feature request related to a problem? Please describe.**\r\n\r\nCode standards expectations are by documentation for some project languages, and by automation for others. In cases of the former:\r\n\r\n 1. Contributors don't realize they should follow them\r\n 1. Contributors use different versions or settings for tools like formatters\r\n 1. Non-compliant code sometimes gets checked in and merged. When someone later fixes it i.e. by running a formatter, their PR may be inflated with many out-of-scope changes.\r\n\r\n**Describe the solution you'd like**\r\n\r\nFor all of Go, Java, and Python:\r\n\r\n- Standards are checked by CI, to address issues 1 and 3.\r\n- Development dependency versions and settings (linting and formatting tools) are managed by build automation, to alleviate issue 2.\r\n\r\nTry to fail fast for feedback, but without undue friction on development. For Java for example, we complain on `mvn test` but not `mvn compile` (nor `test-compile`). Perhaps better yet, on CI all the linting could be in one dedicated job / GH status check (though a failure should report all problems, not fail one language, fix and push, fail another language…).\r\n\r\nGit hooks could be an optional suggestion.\r\n\r\n@woop suggested on #508:\r\n\r\n\u003e How about we just have `make lint` or `make format` at the root of the Feast repo? That would be based on hardcoded configuration that everyone can see, and should ideally cover the whole repo (Java, Go, Python).\r\n\r\nSounds good to me.\r\n\r\n**Describe alternatives you've considered**\r\n\r\n**Additional context**\r\n\r\n#487 \r\n#508 \r\n","author":{"url":"https://github.com/ches","@type":"Person","name":"ches"},"datePublished":"2020-03-09T10:15:03.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/526/feast/issues/526"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:640a9bf4-4eb2-3a24-ab6c-fd197dff0aeb |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 88D0:34A19B:1511A17:1D905FE:697B9334 |
| html-safe-nonce | 65aeebbba51214d94b9a1cb7722252aad26bac35858db1c4e76cf1d5e15559e7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEQwOjM0QTE5QjoxNTExQTE3OjFEOTA1RkU6Njk3QjkzMzQiLCJ2aXNpdG9yX2lkIjoiMjcyOTczNDgyNTQ0MTk4OTQyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9975dae4207444dee00b45c9787536e91c59558a49020e5abfd857e69ecc2025 |
| hovercard-subject-tag | issue:577795031 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/526/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0efb028a0457772c084a83792649ddbb98000c2066be4d62dfd23410e053b59f/feast-dev/feast/issues/526 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0efb028a0457772c084a83792649ddbb98000c2066be4d62dfd23410e053b59f/feast-dev/feast/issues/526 |
| og:image:alt | Is your feature request related to a problem? Please describe. Code standards expectations are by documentation for some project languages, and by automation for others. In cases of the former: Con... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ches |
| hostname | github.com |
| expected-hostname | github.com |
| None | 50d60071257d18b32330d912202dc320d501c221ea1591db8fbf19715460d571 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dcefb04b18d0f0164691e133411da1c4c92e910c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width