Title: Shift ingestion feature metrics to after store write · Issue #489 · feast-dev/feast · GitHub
Open Graph Title: Shift ingestion feature metrics to after store write · Issue #489 · feast-dev/feast
X Title: Shift ingestion feature metrics to after store write · Issue #489 · feast-dev/feast
Description: Is your feature request related to a problem? Please describe. Existing metrics collection for ingestion is done in parallel to store writes: + | +-------+--------+ | | +------+-----+ +------+-----+ | | | | | store | | metrics | | write ...
Open Graph Description: Is your feature request related to a problem? Please describe. Existing metrics collection for ingestion is done in parallel to store writes: + | +-------+--------+ | | +------+-----+ +------+-----...
X Description: Is your feature request related to a problem? Please describe. Existing metrics collection for ingestion is done in parallel to store writes: + | +-------+--------+ | | +------+-----+ +------+-----...
Opengraph URL: https://github.com/feast-dev/feast/issues/489
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Shift ingestion feature metrics to after store write ","articleBody":"**Is your feature request related to a problem? Please describe.**\r\nExisting metrics collection for ingestion is done in parallel to store writes:\r\n```\r\n +\r\n |\r\n +-------+--------+\r\n | |\r\n+------+-----+ +------+-----+\r\n| | | |\r\n| store | | metrics |\r\n| write | | write |\r\n| | | |\r\n+------------+ +------------+\r\n```\r\n\r\nWhile this does give a rough gauge as to what data looks like in flight, it doesn't actually reflect the status of the data in the store, which is ultimately what we are concerned about, since write failures are common. \r\n\r\n**Describe the solution you'd like**\r\nIdeally we want to write metrics POST store writes, as so:\r\n```\r\n ...\r\n +\r\n |\r\n +-----+-----+\r\n | |\r\n | store |\r\n | write |\r\n | |\r\n +-----+-----+\r\n |\r\n +--------+--------+\r\n + +\r\n success failure\r\n + +\r\n | |\r\n+-----+-----+ +-----+-----+\r\n| write | | write |\r\n| sucess | | failure |\r\n| metrics | | metrics |\r\n+-----------+ +-----------+\r\n```\r\n\r\nMetrics collected post store writes would more accurately reflect the data in the stores. \r\n","author":{"url":"https://github.com/zhilingc","@type":"Person","name":"zhilingc"},"datePublished":"2020-02-24T04:22:18.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/489/feast/issues/489"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7596ab47-05ac-1c57-d93a-1e50469ac854 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9E8C:1C8DD9:86CA63:C076B3:697A21D0 |
| html-safe-nonce | e75815ba6500bec69a583eadbfd24e0e3bd91c6e3811f105d39a5f82370c6034 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RThDOjFDOEREOTo4NkNBNjM6QzA3NkIzOjY5N0EyMUQwIiwidmlzaXRvcl9pZCI6IjMyMzQ3Njk3NDMzMzE4NjA5NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 60318fb6f959e351657d25c85d32d37c13ce1ebd76afce0662e052a74fea1dd0 |
| hovercard-subject-tag | issue:569628432 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/489/issue_layout |
| twitter:image | https://opengraph.githubassets.com/547631bfb3f6c97d16e55034176af23e0c76b762da286aa3988c253d49d43fd9/feast-dev/feast/issues/489 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/547631bfb3f6c97d16e55034176af23e0c76b762da286aa3988c253d49d43fd9/feast-dev/feast/issues/489 |
| og:image:alt | Is your feature request related to a problem? Please describe. Existing metrics collection for ingestion is done in parallel to store writes: + | +-------+--------+ | | +------+-----+ +------+-----... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zhilingc |
| hostname | github.com |
| expected-hostname | github.com |
| None | e45f4a1aa1d2f5e476694a8ca3079eb927f0ea276035a2d5e78665f09121ff98 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8a5f67754bd81296f454ff3fa910631e09e4052c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width