Title: Optimize get_online_features by consolidating calls to online store across multiple feature views · Issue #4711 · feast-dev/feast · GitHub
Open Graph Title: Optimize get_online_features by consolidating calls to online store across multiple feature views · Issue #4711 · feast-dev/feast
X Title: Optimize get_online_features by consolidating calls to online store across multiple feature views · Issue #4711 · feast-dev/feast
Description: Is your feature request related to a problem? Please describe. I'm running some benchmarks to measure Python SDK performance and want to discuss a potential improvement on get_online_features implementation. When using the get_online_fea...
Open Graph Description: Is your feature request related to a problem? Please describe. I'm running some benchmarks to measure Python SDK performance and want to discuss a potential improvement on get_online_features imple...
X Description: Is your feature request related to a problem? Please describe. I'm running some benchmarks to measure Python SDK performance and want to discuss a potential improvement on get_online_features i...
Opengraph URL: https://github.com/feast-dev/feast/issues/4711
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Optimize get_online_features by consolidating calls to online store across multiple feature views","articleBody":"**Is your feature request related to a problem? Please describe.**\r\nI'm running some benchmarks to measure Python SDK performance and want to discuss a potential improvement on `get_online_features` implementation.\r\n\r\nWhen using the `get_online_features` method in the SDK with a Redis online store, performance suffers when handling a feature service that includes multiple feature views. The SDK iterates over each feature view within the feature service and calls `online_store.online_read(...)` for each view individually.\r\n\r\nAlthough the Redis online store implementation uses [Redis pipeline](https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/online_stores/redis.py#L399-L403) to reduce network roundtrips, the current SDK implementation separates pipeline calls per feature view, leading to inefficiencies that impact overall performance.\r\n\r\n**Describe the solution you'd like**\r\nI think online store interface should have a method to get online features by a list of feature views (or a feature service), and the [get_online_features](https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/online_stores/online_store.py#L146) should be changed accordingly.\r\n\r\n**Additional context**\r\nFeast's Java code follows a [different implementation](https://github.com/feast-dev/feast/blob/master/java/serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java#L85). It combines features that share same entity keys before calling online store. \r\n","author":{"url":"https://github.com/breno-costa","@type":"Person","name":"breno-costa"},"datePublished":"2024-10-28T21:41:01Z","url":"https://github.com/feast-dev/feast/issues/4711"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4e4121fa-edc6-8612-1abf-9cf63c72dbb6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D296:A7C31:EFB5BA:13BC261:6AFE99A5 |
| html-safe-nonce | 07ec1ed7274f391dca3e8754680f3d1df18d2ffa52cdc3db135a134c05d7f0fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjk2OkE3QzMxOkVGQjVCQToxM0JDMjYxOjZBRkU5OUE1IiwidmlzaXRvcl9pZCI6IjY2Nzg2OTMxOTUyNTUwMjgxMzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 788f19c1f200f39b76df4fd7959f22b9bcffc2f8d008cf5f37b6db4e39bee6bf |
| hovercard-subject-tag | issue:2619617286 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/4711/issue_layout |
| twitter:image | https://opengraph.githubassets.com/19a3837ce2cddcd7f2b161a144e7bb72e069725bb87b32da720fed09ade0f971/feast-dev/feast/issues/4711 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/19a3837ce2cddcd7f2b161a144e7bb72e069725bb87b32da720fed09ade0f971/feast-dev/feast/issues/4711 |
| og:image:alt | Is your feature request related to a problem? Please describe. I'm running some benchmarks to measure Python SDK performance and want to discuss a potential improvement on get_online_features imple... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | breno-costa |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width