René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incompatible `tslib` version imported by Feast UI","articleBody":"## Expected Behavior \r\n\r\nFeast UI dependencies should be resolved to compatible versions regardless of the package manager used.\r\n\r\n## Current Behavior\r\n\r\nWhen using the Feast UI package as a module in a project that has `npm` or `pnpm` as its package manager, I get this error when starting my application:\r\n\r\n```\r\n✘ [ERROR] No matching export in \"node_modules/tslib/tslib.es6.js\" for import \"__spreadArray\"\r\n\r\n    node_modules/@feast-dev/feast-ui/dist/feast-ui.module.js:9:44:\r\n      9 │ import { __assign as __assign$2, __extends, __spreadArray } from 'tslib';\r\n        │                                             ~~~~~~~~~~~~~\r\n        ╵                                             __spreadArrays\r\n\r\n  Did you mean to import \"__spreadArrays\" instead?\r\n\r\n    node_modules/tslib/tslib.es6.js:150:16:\r\n      150 │ export function __spreadArrays() {\r\n          ╵                 ~~~~~~~~~~~~~~\r\n```\r\n\r\n[`__spreadArray` was added in tslib 2.1.0](https://github.com/microsoft/tslib/releases/tag/2.1.0), so the error means the code is importing an older version of `tslib`.\r\n\r\nI don't see this error if I switch to Yarn 1 (Classic), presumably it resolves the `tslib` version to a later one due to different dependency resolution strategies.\r\n\r\n## Steps to reproduce\r\n\r\nI created [an example React app](https://github.com/peruukki/feast-ui-app) with [Vite](https://vitejs.dev/guide/#scaffolding-your-first-vite-project) (Create React App is no longer recommended). You can clone it and install the dependencies with `npm i` or `pnpm i`, and start the app with `npm dev` or `pnpm dev`. (Enable `pnpm` with [`corepack enable`](https://pnpm.io/installation#using-corepack) if needed.)\r\n\r\n### Specifications\r\n\r\n- Version: 0.40.0 (@feast-dev/feast-ui version)\r\n- Platform: WSL or macOS\r\n- Subsystem: -\r\n\r\n## Possible Solution\r\n\r\nAs shown by the error, `tslib` is a runtime dependency because code in `dist` imports from it. However, `tslib` is included in the project's `devDependencies`. Moving it to `dependencies` should ensure that a compatible version is always installed and referenced by Feast UI. Currently it picks up the version from its dependencies or from the consuming application.\r\n\r\n","author":{"url":"https://github.com/peruukki","@type":"Person","name":"peruukki"},"datePublished":"2024-09-15T15:44:05.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/4521/feast/issues/4521"}