Title: Running `feast materialize-incremental` for an end date far in future breaks incremental materializations up to that date · Issue #4222 · feast-dev/feast · GitHub
Open Graph Title: Running `feast materialize-incremental` for an end date far in future breaks incremental materializations up to that date · Issue #4222 · feast-dev/feast
X Title: Running `feast materialize-incremental` for an end date far in future breaks incremental materializations up to that date · Issue #4222 · feast-dev/feast
Description: Expected Behavior When running feast materialize-incremental it should not be possible for a materialize to run starting from a date that hasn't occurred yet. Would expect materialize-incremental to choose min(now, most_recent_materializ...
Open Graph Description: Expected Behavior When running feast materialize-incremental it should not be possible for a materialize to run starting from a date that hasn't occurred yet. Would expect materialize-incremental t...
X Description: Expected Behavior When running feast materialize-incremental it should not be possible for a materialize to run starting from a date that hasn't occurred yet. Would expect materialize-increment...
Opengraph URL: https://github.com/feast-dev/feast/issues/4222
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Running `feast materialize-incremental` for an end date far in future breaks incremental materializations up to that date","articleBody":"## Expected Behavior\r\n\r\nWhen running `feast materialize-incremental` it should not be possible for a materialize to run starting from a date that hasn't occurred yet. Would expect `materialize-incremental` to choose `min(now, most_recent_materialization_date)`\r\n\r\n## Current Behavior\r\n\r\nWhen running `feast materialize-incremental` for a future date, say `2025-04-08T00:00:00`, it will set that date as the next start date. This breaks all future `materialize-incremental` commands up until that date, if you run daily materializations they will no longer function until the actual date goes beyond this erroneously entered start date. Because the data is stored as a serialized protobuf in the SQL-based registry this is also non-trivial to change. \r\n\r\nYou can see code [here](https://github.com/feast-dev/feast/blob/1f17b9bcd635d1344e1f9be4dcb745d8e206e071/sdk/python/feast/feature_view.py#L444) showing that there is no validation checks for the start date, merely the latest date that has ever run.\r\n\r\n## Steps to reproduce\r\n\r\nRun a `materialize-incremental` command for a date far in the future. \r\n\r\nRun a second `materialize-incremental` command for a date less than the last start date. Watch Feast always find no date to materialize. \r\n\r\n### Specifications\r\n\r\n- Version: 0.34.1\r\n- Platform: Mac OSX\r\n- Subsystem: Sonoma 14.5\r\n\r\n## Possible Solution\r\n\r\nRefactor the above function to choose `min(now, most_recent_materialization_date)`. Happy to contribute to this fix. \r\n","author":{"url":"https://github.com/samhallam-reverb","@type":"Person","name":"samhallam-reverb"},"datePublished":"2024-05-23T19:54:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":10},"url":"https://github.com/4222/feast/issues/4222"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c33ba59e-68be-35ad-f3ed-907d6c435780 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E3F0:154B27:80CABE:B6A6F6:696F8A4F |
| html-safe-nonce | cfe57364da3533e626e3bf9ab448d8edc0d4f33321bfd1624152492b47f6f656 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0YwOjE1NEIyNzo4MENBQkU6QjZBNkY2OjY5NkY4QTRGIiwidmlzaXRvcl9pZCI6IjQ2NTA1OTYwMjczMDYzMTQzMTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fea52cbbce70f8df77b9255b9199b4c443bda48233c7a5f3f5872c24b264214f |
| hovercard-subject-tag | issue:2313715865 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/4222/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c9b72c0c5d83c6e1d0f7db888238e6998df2992f91172a300ad11d63273623ee/feast-dev/feast/issues/4222 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c9b72c0c5d83c6e1d0f7db888238e6998df2992f91172a300ad11d63273623ee/feast-dev/feast/issues/4222 |
| og:image:alt | Expected Behavior When running feast materialize-incremental it should not be possible for a materialize to run starting from a date that hasn't occurred yet. Would expect materialize-incremental t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | samhallam-reverb |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0ca8d8c65612640b9a1a588b3eed68222ca723ed2d028b18fe81b28936d535eb |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 95f60616ce2765d1114fe6da4af405a58c6d26d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width