René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Azure MSSQL Backend (and possibly others) Broken SQLAlchemy `Engine` objects interactions with `pandas.read_sql()`","articleBody":"## Expected Behavior \r\n\r\n`feast` cli commands like `feast plan` work when using a `mssql` offline store\r\n\r\n## Current Behavior\r\n\r\nCurrently, repos with `mssql` offline store are broken when appying feast cli commands. The following occurs:\r\n\r\n```\r\n  File \"/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/feast/repo_operations.py\", line 218, in plan\r\n    data_source.validate(store.config)\r\n  File \"/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/feast/infra/offline_stores/contrib/mssql_offline_store/mssqlserver_source.py\", line 215, in validate\r\n    self.get_table_column_names_and_types(config)\r\n  File \"/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/feast/infra/offline_stores/contrib/mssql_offline_store/mssqlserver_source.py\", line 243, in get_table_column_names_and_types\r\n    table_schema = pandas.read_sql(columns_query, conn)\r\n  File \"/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pandas/io/sql.py\", line 706, in read_sql\r\n    return pandas_sql.read_query(\r\n  File \"/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pandas/io/sql.py\", line 2736, in read_query\r\n    cursor = self.execute(sql, params)\r\n  File \"/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pandas/io/sql.py\", line 2670, in execute\r\n    cur = self.con.cursor()\r\nAttributeError: 'Engine' object has no attribute 'cursor'\r\n```\r\n## Steps to reproduce\r\n\r\nwith a feature store YAML of:\r\n\r\n```\r\nproject: myproject\r\nprovider: azure\r\nregistry:\r\n  registry_type: sql\r\n  path: ${SQL_REGISTRY_CONNECTION_STRING}\r\noffline_store: \r\n  type: mssql\r\n  connection_string: ${SQL_OFFLINE_CONNECTION_STRING}\r\nonline_store:\r\n  type: redis\r\n  redis_type: redis_cluster\r\n  connection_string: ${REDIS_CONNECTION_STRING}\r\nentity_key_serialization_version: 2\r\n```\r\nwhen we run `feast plan`  - we get the above errors.\r\n\r\nThis may impact other providers, but I've only confirmed it with `azure` provider\r\n### Specifications\r\n\r\n- Version: 0.35.0\r\n- Platform: Mac + Linux (probably others)\r\n- Subsystem:\r\n\r\n## Possible Solution\r\nI think this is a really a  `SQLAlchemy` versioning issue, I resolved the problem by pinning \r\n`SQLAlchemy\u003c1.4.52`\r\n\r\nIf we just update the `AZURE_REQUIRED` to:\r\n```\r\nAZURE_REQUIRED = [\r\n    \"azure-storage-blob\u003e=0.37.0\",\r\n    \"azure-identity\u003e=1.6.1\",\r\n    \"SQLAlchemy\u003e=1.4.19,\u003c1.4.52\",\r\n    \"pyodbc\u003e=4.0.30\",\r\n    \"pymssql\",\r\n] \r\n```\r\n\r\nI think we'd avoid this issue","author":{"url":"https://github.com/peter-resnick","@type":"Person","name":"peter-resnick"},"datePublished":"2024-04-02T18:47:19.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/4066/feast/issues/4066"}