René's URL Explorer Experiment


Title: performance issues of getting online features related to parsing protobuf data · Issue #3649 · feast-dev/feast · GitHub

Open Graph Title: performance issues of getting online features related to parsing protobuf data · Issue #3649 · feast-dev/feast

X Title: performance issues of getting online features related to parsing protobuf data · Issue #3649 · feast-dev/feast

Description: Is your feature request related to a problem? Please describe. The profiler of one application I am working on shows the from_proto method of the FeatureView class takes up 80% of the execution time. The result of cProfile is shown below...

Open Graph Description: Is your feature request related to a problem? Please describe. The profiler of one application I am working on shows the from_proto method of the FeatureView class takes up 80% of the execution tim...

X Description: Is your feature request related to a problem? Please describe. The profiler of one application I am working on shows the from_proto method of the FeatureView class takes up 80% of the execution tim...

Opengraph URL: https://github.com/feast-dev/feast/issues/3649

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"performance issues of getting online features related to parsing protobuf data","articleBody":"**Is your feature request related to a problem? Please describe.**\r\n\r\nThe profiler of one application I am working on shows the `from_proto` method of the `FeatureView` class takes up 80% of the execution time. The result of cProfile is shown below.\r\n```\r\n    ncalls  tottime  percall  cumtime  percall filename:lineno(function)\r\n         1    0.003    0.003   78.931   78.931 profiler.py:53(main)\r\n       100    0.018    0.000   78.849    0.788 get_features.py:122(get_xxxx_features)\r\n  1100/400    0.020    0.000   77.077    0.193 usage.py:274(wrapper)\r\n 444200/9800    1.713    0.000   72.206    0.007 __init__.py:1030(wrapper)\r\n       200    0.078    0.000   68.913    0.345 feature_store.py:1527(get_online_features)\r\n       200    0.087    0.000   68.835    0.344 feature_store.py:1590(_get_online_features)\r\n      3500    5.634    0.002   62.442    0.018 feature_view.py:369(from_proto)\r\n       200    0.005    0.000   59.362    0.297 feature_store.py:2149(_get_feature_views_to_use)\r\n       200    0.002    0.000   58.501    0.293 feature_store.py:281(_list_feature_views)\r\n       200    0.001    0.000   58.499    0.292 registry.py:523(list_feature_views)\r\n       200    0.016    0.000   58.495    0.292 proto_registry_utils.py:150(list_feature_views)\r\n```\r\nThere are 3 feature views accessed by `get_xxxx_features`, however 100 calls of `get_xxxx_features` lead to 3500 calls of `from_proto`. There are 17 feature views in the feature store of this application and 3 of them are used by `get_xxxx_features`.\r\n\r\nEnvironment: `continuumio/miniconda3:4.11.0` (linux/amd64) base image, `python==3.9.7`, `feast=0.31.1`, `protobuf==4.23.2`\r\n\r\n**Describe the solution you'd like**\r\n\r\nInstead of caching the protobuf blob of `FeatureView`, cache the `FeatureView` python object in memory.\r\n\r\n**Describe alternatives you've considered**\r\n\r\nmodify the `get_online_features` [method](https://github.com/feast-dev/feast/blob/v0.31.1/sdk/python/feast/feature_store.py#L1528) to\r\n```python\r\ndef get_online_features(\r\n    self,\r\n    features: Union[List[str], List[FeatureView], FeatureService],\r\n    entity_rows: List[Dict[str, Any]],\r\n    full_feature_names: bool = False,\r\n):\r\n``` \r\nso that the application developer has the option to cache the `FeatureView` objects and use them to get features directly (by passing the `get_feature_views_to_use` [step](https://github.com/feast-dev/feast/blob/v0.31.1/sdk/python/feast/feature_store.py#L1606-L1613) )\r\n  ","author":{"url":"https://github.com/heavenmarshal","@type":"Person","name":"heavenmarshal"},"datePublished":"2023-06-12T13:41:56Z","url":"https://github.com/feast-dev/feast/issues/3649"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e82e4d70-3c6f-2dc1-8b81-959f00940dcd
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9530:10CB0:F6FDB5:144E717:6AFE99A6
html-safe-nonce828cbd99218bc8ad10380e336f82920534b590829333ec790aa5f580deb2bd65
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTMwOjEwQ0IwOkY2RkRCNToxNDRFNzE3OjZBRkU5OUE2IiwidmlzaXRvcl9pZCI6IjUzNDY2NjEyNDIxODg1MDM0NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf16219e2274e57e365c2a5e075e4aa530d8119919550b1db1f1dd385a5bc36ba
hovercard-subject-tagissue:1752797109
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/3649/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2a1d1a1e50b758ec1aa7e630136105b9fc568e4b560925a1277be99361237608/feast-dev/feast/issues/3649
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2a1d1a1e50b758ec1aa7e630136105b9fc568e4b560925a1277be99361237608/feast-dev/feast/issues/3649
og:image:altIs your feature request related to a problem? Please describe. The profiler of one application I am working on shows the from_proto method of the FeatureView class takes up 80% of the execution tim...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameheavenmarshal
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/3649#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F3649
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F3649
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/3649
Reloadhttps://github.com/feast-dev/feast/issues/3649
Reloadhttps://github.com/feast-dev/feast/issues/3649
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/3649
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/3649
#3702https://github.com/feast-dev/feast/pull/3702
performance issues of getting online features related to parsing protobuf datahttps://github.com/feast-dev/feast/issues/3649#top
#3702https://github.com/feast-dev/feast/pull/3702
kind/featureNew feature or requesthttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Ffeature%22
https://github.com/heavenmarshal
heavenmarshalhttps://github.com/heavenmarshal
on Jun 12, 2023https://github.com/feast-dev/feast/issues/3649#issue-1752797109
methodhttps://github.com/feast-dev/feast/blob/v0.31.1/sdk/python/feast/feature_store.py#L1528
stephttps://github.com/feast-dev/feast/blob/v0.31.1/sdk/python/feast/feature_store.py#L1606-L1613
heavenmarshalhttps://github.com/heavenmarshal
kind/featureNew feature or requesthttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Ffeature%22
on Jun 12, 2023https://github.com/feast-dev/feast/issues/3649#event-9502914033
https://github.com/goodseog
goodseoghttps://github.com/goodseog
on Jun 14, 2023https://github.com/feast-dev/feast/issues/3649#issuecomment-1590374721
feast/sdk/python/feast/feature_store.pyhttps://github.com/feast-dev/feast/blob/c474ccdd23ca8161de5e2958f0a12826c020dc44/sdk/python/feast/feature_store.py#L2149-L2154
c474ccdhttps://github.com/feast-dev/feast/commit/c474ccdd23ca8161de5e2958f0a12826c020dc44
feast/sdk/python/feast/infra/registry/sql.pyhttps://github.com/feast-dev/feast/blob/c474ccdd23ca8161de5e2958f0a12826c020dc44/sdk/python/feast/infra/registry/sql.py#L244-L259
c474ccdhttps://github.com/feast-dev/feast/commit/c474ccdd23ca8161de5e2958f0a12826c020dc44
https://github.com/goodseog
goodseoghttps://github.com/goodseog
on Jun 14, 2023https://github.com/feast-dev/feast/issues/3649#issuecomment-1590391662
feast/sdk/python/feast/feature_store.pyhttps://github.com/feast-dev/feast/blob/c474ccdd23ca8161de5e2958f0a12826c020dc44/sdk/python/feast/feature_store.py#L2149-L2177
c474ccdhttps://github.com/feast-dev/feast/commit/c474ccdd23ca8161de5e2958f0a12826c020dc44
felixwang9817https://github.com/felixwang9817
completedhttps://github.com/feast-dev/feast/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#3702https://github.com/feast-dev/feast/pull/3702
on Sep 12, 2023https://github.com/feast-dev/feast/issues/3649#event-10350243442
Sign up for freehttps://github.com/signup?return_to=https://github.com/feast-dev/feast/issues/3649
Sign in to commenthttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/3649
kind/featureNew feature or requesthttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Ffeature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.