Title: Inconsistency in `ui`, docs and python `ui_server` · Issue #3497 · feast-dev/feast · GitHub
Open Graph Title: Inconsistency in `ui`, docs and python `ui_server` · Issue #3497 · feast-dev/feast
X Title: Inconsistency in `ui`, docs and python `ui_server` · Issue #3497 · feast-dev/feast
Description: Expected Behavior I would expect that the react app, python server, and docs are consistent in how they implement or (for the docs) describe how the registry is ingested. Current Behavior Right now: Docs: The docs suggest that the UI loa...
Open Graph Description: Expected Behavior I would expect that the react app, python server, and docs are consistent in how they implement or (for the docs) describe how the registry is ingested. Current Behavior Right now...
X Description: Expected Behavior I would expect that the react app, python server, and docs are consistent in how they implement or (for the docs) describe how the registry is ingested. Current Behavior Right now...
Opengraph URL: https://github.com/feast-dev/feast/issues/3497
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Inconsistency in `ui`, docs and python `ui_server`","articleBody":"## Expected Behavior \r\n\r\nI would expect that the react app, python server, and docs are consistent in how they implement or (for the docs) describe how the registry is ingested.\r\n\r\n## Current Behavior\r\n\r\nRight now:\r\n1. **Docs**: The docs suggest that the [UI loads a JSON dump of the registry](https://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/docs/reference/alpha-web-ui.md?plain=1#L82)\r\n2. **Python App**: The python app appears to use `get_registry_dump` to produce a [JSON dump of the registry](https://github.com/feast-dev/feast/blob/master/sdk/python/feast/ui_server.py#L108), but `get_registry_dump` is never called. Instead the UI fetches the `registry_proto` from `/registry` (see [here](https://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/sdk/python/feast/ui_server.py#L40) and [here](https://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/sdk/python/feast/ui_server.py#L74)).\r\n3. **UI**: `useLoadRegistry` looks like it used to [parse json](https://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/ui/src/queries/useLoadRegistry.ts#L34) -- as in #2352 -- but then #3208 replaced the `json` with the protobuf registry\r\n\r\n## Steps to reproduce\r\n\r\nNA\r\n\r\n### Specifications\r\n\r\n- Version: `main`\r\n\r\n## Possible Solution\r\n\r\nIf the intent of #3208 was to replace the json registry with the protobuf version, then the solution would be to:\r\n1. Update the docs to make this clear\r\n2. Update the python `ui_server` so it doesn't appear to produce the JSON dump via `get_registry_dump` \r\n\r\nOf these solutions, the first (updating docs) is probably the most valuable to the community.","author":{"url":"https://github.com/bjakubowskiVNSNY","@type":"Person","name":"bjakubowskiVNSNY"},"datePublished":"2023-02-15T20:49:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/3497/feast/issues/3497"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9d6a9de5-b5bb-e9ed-7869-2ce228a7e3f7 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9C18:1B11A3:76DA40:A78A10:6978AC1E |
| html-safe-nonce | fde8af1792803a66e2d52112a3f27545463aecb456d4ced8e5284540a67fc867 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzE4OjFCMTFBMzo3NkRBNDA6QTc4QTEwOjY5NzhBQzFFIiwidmlzaXRvcl9pZCI6Ijc2NDg3ODg3Njc4NzgxNzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 60ee0f0e3fe8d5cd5d6e4e41ba5c4bb7f2454d65cdc7391d4b0f3f72b91d2ec1 |
| hovercard-subject-tag | issue:1586539998 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/3497/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d4d550ce438c54755203b1be2b483eaf3ec729def16174aa5140bf278ddd02bd/feast-dev/feast/issues/3497 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d4d550ce438c54755203b1be2b483eaf3ec729def16174aa5140bf278ddd02bd/feast-dev/feast/issues/3497 |
| og:image:alt | Expected Behavior I would expect that the react app, python server, and docs are consistent in how they implement or (for the docs) describe how the registry is ingested. Current Behavior Right now... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bjakubowskiVNSNY |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8aa86d87c47054170094daaf9699b27a28a8448 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width