René's URL Explorer Experiment


Title: Inconsistency in `ui`, docs and python `ui_server` · Issue #3497 · feast-dev/feast · GitHub

Open Graph Title: Inconsistency in `ui`, docs and python `ui_server` · Issue #3497 · feast-dev/feast

X Title: Inconsistency in `ui`, docs and python `ui_server` · Issue #3497 · feast-dev/feast

Description: Expected Behavior I would expect that the react app, python server, and docs are consistent in how they implement or (for the docs) describe how the registry is ingested. Current Behavior Right now: Docs: The docs suggest that the UI loa...

Open Graph Description: Expected Behavior I would expect that the react app, python server, and docs are consistent in how they implement or (for the docs) describe how the registry is ingested. Current Behavior Right now...

X Description: Expected Behavior I would expect that the react app, python server, and docs are consistent in how they implement or (for the docs) describe how the registry is ingested. Current Behavior Right now...

Opengraph URL: https://github.com/feast-dev/feast/issues/3497

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Inconsistency in `ui`, docs and python `ui_server`","articleBody":"## Expected Behavior \r\n\r\nI would expect that the react app, python server, and docs are consistent in how they implement or (for the docs) describe how the registry is ingested.\r\n\r\n## Current Behavior\r\n\r\nRight now:\r\n1. **Docs**: The docs suggest that the [UI loads a JSON dump of the registry](https://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/docs/reference/alpha-web-ui.md?plain=1#L82)\r\n2. **Python App**: The python app appears to use `get_registry_dump` to produce a [JSON dump of the registry](https://github.com/feast-dev/feast/blob/master/sdk/python/feast/ui_server.py#L108), but `get_registry_dump` is never called. Instead the UI fetches the `registry_proto` from `/registry` (see [here](https://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/sdk/python/feast/ui_server.py#L40)  and [here](https://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/sdk/python/feast/ui_server.py#L74)).\r\n3. **UI**: `useLoadRegistry` looks like it used to [parse json](https://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/ui/src/queries/useLoadRegistry.ts#L34) -- as in #2352 -- but then #3208 replaced the `json` with the protobuf registry\r\n\r\n## Steps to reproduce\r\n\r\nNA\r\n\r\n### Specifications\r\n\r\n- Version: `main`\r\n\r\n## Possible Solution\r\n\r\nIf the intent of #3208 was to replace the json registry with the protobuf version, then the solution would be to:\r\n1. Update the docs to make this clear\r\n2. Update the python `ui_server` so it doesn't appear to produce the JSON dump via `get_registry_dump` \r\n\r\nOf these solutions, the first (updating docs) is probably the most valuable to the community.","author":{"url":"https://github.com/bjakubowskiVNSNY","@type":"Person","name":"bjakubowskiVNSNY"},"datePublished":"2023-02-15T20:49:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/3497/feast/issues/3497"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9d6a9de5-b5bb-e9ed-7869-2ce228a7e3f7
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9C18:1B11A3:76DA40:A78A10:6978AC1E
html-safe-noncefde8af1792803a66e2d52112a3f27545463aecb456d4ced8e5284540a67fc867
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzE4OjFCMTFBMzo3NkRBNDA6QTc4QTEwOjY5NzhBQzFFIiwidmlzaXRvcl9pZCI6Ijc2NDg3ODg3Njc4NzgxNzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac60ee0f0e3fe8d5cd5d6e4e41ba5c4bb7f2454d65cdc7391d4b0f3f72b91d2ec1
hovercard-subject-tagissue:1586539998
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feast-dev/feast/3497/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d4d550ce438c54755203b1be2b483eaf3ec729def16174aa5140bf278ddd02bd/feast-dev/feast/issues/3497
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d4d550ce438c54755203b1be2b483eaf3ec729def16174aa5140bf278ddd02bd/feast-dev/feast/issues/3497
og:image:altExpected Behavior I would expect that the react app, python server, and docs are consistent in how they implement or (for the docs) describe how the registry is ingested. Current Behavior Right now...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebjakubowskiVNSNY
hostnamegithub.com
expected-hostnamegithub.com
None2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef8aa86d87c47054170094daaf9699b27a28a8448
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/issues/3497#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F3497
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fissues%2F3497
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/issues/3497
Reloadhttps://github.com/feast-dev/feast/issues/3497
Reloadhttps://github.com/feast-dev/feast/issues/3497
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 182 https://github.com/feast-dev/feast/issues
Pull requests 67 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/3497
New issuehttps://github.com/login?return_to=https://github.com/feast-dev/feast/issues/3497
Inconsistency in ui, docs and python ui_serverhttps://github.com/feast-dev/feast/issues/3497#top
kind/bughttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Fbug%22
priority/p2https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22priority%2Fp2%22
wontfixThis will not be worked onhttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22wontfix%22
https://github.com/bjakubowskiVNSNY
https://github.com/bjakubowskiVNSNY
bjakubowskiVNSNYhttps://github.com/bjakubowskiVNSNY
on Feb 15, 2023https://github.com/feast-dev/feast/issues/3497#issue-1586539998
UI loads a JSON dump of the registryhttps://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/docs/reference/alpha-web-ui.md?plain=1#L82
JSON dump of the registryhttps://github.com/feast-dev/feast/blob/master/sdk/python/feast/ui_server.py#L108
herehttps://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/sdk/python/feast/ui_server.py#L40
herehttps://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/sdk/python/feast/ui_server.py#L74
parse jsonhttps://github.com/feast-dev/feast/blob/0f9d115f34dafadd87f18c97d2bfe5d592842f9d/ui/src/queries/useLoadRegistry.ts#L34
feat: Initial merge of Web UI logic #2352https://github.com/feast-dev/feast/pull/2352
chore: Replace zod by protobufjs #3208https://github.com/feast-dev/feast/pull/3208
#3208https://github.com/feast-dev/feast/pull/3208
kind/bughttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22kind%2Fbug%22
priority/p2https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22priority%2Fp2%22
wontfixThis will not be worked onhttps://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3A%22wontfix%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.