René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SQL Registry is broken due to caching","articleBody":"## Expected Behavior \r\nSQL registry works\r\n\r\n## Current Behavior\r\nWhen calling `feature_store.get_online_features()`, we should get back the features.\r\n\r\n## Steps to reproduce\r\nUse any SQL registry and call `feature_store.get_online_features()`. \r\n\r\nTraceback (apologies for the REDACTED stuff, that has to do with Databricks redacting some stuff which it thinks are secrets:\r\n\r\n```python\r\n/databricks/python/lib/python3.8/site-packages/feast/usage.py in wrapper(*args, **kwargs)\r\n    297 \r\n    298                 if traceback:\r\n--\u003e 299                     raise exc.with_traceback(traceback)\r\n    300 \r\n    301                 raise exc\r\n\r\n/databricks/python/lib/python3.8/site-packages/feast/usage.py in wrapper(*args, **kwargs)\r\n    286 \r\n    287             try:\r\n--\u003e 288                 return func(*args, **kwargs)\r\n    289             except Exception:\r\n    290                 if ctx.exception:\r\n\r\n/databricks/python/lib/python3.8/site-packages/feast/feature_store.py in get_online_features(self, features, entity_rows, full_feature_names)\r\n   1586                     raise ValueError(\"All entity_rows must have the same keys.\") from e\r\n   1587 \r\n-\u003e 1588         return self._get_online_features(\r\n   1589             features=features,\r\n   1590             entity_values=columnar,\r\n\r\n/databricks/python/lib/python3.8/site-packages/feast/feature_store.py in _get_online_features(self, features, entity_values, full_feature_names, native_entity_values)\r\n   1654             requested_request_feature_views,\r\n   1655             requested_on_demand_feature_views,\r\n-\u003e 1656         ) = self._get_feature_views_to_use(\r\n   1657             features=features, allow_cache=True, hide_dummy_entity=False\r\n   1658         )\r\n\r\n/databricks/python/lib/python3.8/site-packages/feast/feature_store.py in _get_feature_views_to_use(self, features, allow_cache, hide_dummy_entity)\r\n   2203             fv.name: fv\r\n   2204             for fv in [\r\n-\u003e 2205                 *self._list_feature_views(allow_cache, hide_dummy_entity),\r\n   2206                 *self._[REDACTED].list_stream_feature_views(\r\n   2207                     project=self.project, allow_cache=allow_cache\r\n\r\n/databricks/python/lib/python3.8/site-packages/feast/feature_store.py in _list_feature_views(self, allow_cache, hide_dummy_entity)\r\n    287     ) -\u003e List[FeatureView]:\r\n    288         feature_views = []\r\n--\u003e 289         for fv in self._[REDACTED].list_feature_views(\r\n    290             self.project, allow_cache=allow_cache\r\n    291         ):\r\n\r\n/databricks/python/lib/python3.8/site-packages/feast/infra/[REDACTED]/sql.py in list_feature_views(self, project, allow_cache)\r\n    535     ) -\u003e List[FeatureView]:\r\n    536         if allow_cache:\r\n--\u003e 537             self._refresh_cached_[REDACTED]_if_necessary()\r\n    538             return proto_[REDACTED]_utils.list_feature_views(\r\n    539                 self.cached_[REDACTED]_proto, project\r\n\r\n/databricks/python/lib/python3.8/site-packages/feast/infra/[REDACTED]/sql.py in _refresh_cached_[REDACTED]_if_necessary(self)\r\n    232 \r\n    233             if expired:\r\n--\u003e 234                 self.refresh()\r\n    235 \r\n    236     def get_stream_feature_view(\r\n\r\nTypeError: refresh() missing 1 required positional argument: 'project'\r\n```\r\n\r\nThis seems to be caused by triggering a refresh of the registry cache, which expects a `project` parameter, which type hint states that it is optional, but because the method spec does not define a default value, will require a value to be passed in. However, this value is not passed in, causing `self.refresh()` to fail.\r\n\r\n## Possible Solution\r\nIn https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/registry/sql.py#L234, change `self.refresh()` to `self.refresh(None)`. Alternatively, change the `refresh` method to have a default value for the `project` parameter (not sure why the parameter is required; it doesn't seem to be used).","author":{"url":"https://github.com/jiewpeng","@type":"Person","name":"jiewpeng"},"datePublished":"2023-01-12T04:17:41.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/3445/feast/issues/3445"}